Andy Brett
3877721209
Merge pull request #6631 from Matt-Yorkley/actionmailer-deliver
...
[Deprecation] Replace ActionMailer#deliver with ActionMailer#deliver_now
2021-01-08 17:42:31 -08:00
Matt-Yorkley
ff962c1c9b
Change various Mailer invocations from #deliver_now to #deliver_later
2021-01-08 23:18:55 +00:00
Luis Ramos
2e4a206825
Add new offenses to exceptions file
2021-01-08 22:43:15 +00:00
Luis Ramos
0b45533237
Update rubocop todo list
2021-01-08 22:43:15 +00:00
Matt-Yorkley
3e6445c51c
Replace deprecated ActionMailer#deliver with ActionMailer#deliver_now
...
DEPRECATION WARNING: `#deliver` is deprecated and will be removed in Rails 5. Use `#deliver_now` to deliver immediately or `#deliver_later` to deliver through Active Job.
2021-01-08 20:35:47 +00:00
Andy Brett
3d8c7cc9f0
Merge pull request #6522 from arku/feat/stripe-credit-card-removal
...
Extract Stripe credit card deletion logic to a service object
2021-01-02 14:56:00 -08:00
Pau Pérez Fabregat
f26507b897
Merge pull request #6454 from arku/fix/signup-route
...
Remove /signup routes
2020-12-14 16:38:23 +01:00
Arun Kumar Mohan
020df3619f
Add tests for Stripe::CreditCardRemover
2020-12-12 21:39:21 -05:00
Andy Brett
92aeab2ec3
Merge pull request #6490 from openfoodfoundation/dependabot/bundler/capybara-3.15.1
...
Bump capybara from 2.18.0 to 3.15.1
2020-12-12 13:16:04 -08:00
Arun Kumar Mohan
1edebade78
Extract Stripe credit card deletion logic to a service object
2020-12-11 19:52:59 -05:00
Luis Ramos
480dfdf961
Handle redirect case
...
For some reason the process is now working correctly, the authorization step succeeds and a redirect link is stored in the payment with state pending. The payment state is correctly left at pending. Here we add a check for the redirect path sent by stripe and fail the authorization if there is one (it means the payment would need an extra auth step only available in the frontoffice now and probably through email to customer at some point in the future). For some reason the flash with the authorization failure message is not showing up for the user
2020-12-11 23:14:23 +00:00
Andy Brett
3b7313f7e3
add spec for deleting the default card
2020-12-10 12:31:58 -08:00
Andy Brett
655512adab
add missing require statements
2020-12-10 12:17:42 -08:00
Andy Brett
8c747e4812
refactor destroy_clones to separate class
2020-12-10 11:22:02 -08:00
Andy Brett
9c544ef2f4
remove cloned cards after removing the platform card
2020-12-08 07:52:42 -08:00
Andy Brett
bc3fd8c50c
remove unused method
2020-12-08 07:52:42 -08:00
Andy Brett
b517d2f0c7
guard against a stripe customer already being deleted
2020-12-08 07:52:41 -08:00
Andy Brett
6fdcd6218d
add remove_shop_authorizations method to controller
2020-12-08 07:46:10 -08:00
Arun Kumar Mohan
81b03906f9
Remove /signup routes
2020-12-03 20:43:28 -05:00
Luis Ramos
0f27f57cbb
Use new Admin::ResourceController
2020-12-03 15:32:20 -08:00
Luis Ramos
0fb9f44dda
Make all controllers use new Admin::ResourceController
2020-12-03 15:32:20 -08:00
Luis Ramos
99fd99cd33
Move spree admin resource controller to admin resource controller
2020-12-03 15:32:20 -08:00
Luis Ramos
6e08fccbbe
Merge resource_controller url helpers with parent version
2020-12-03 15:32:20 -08:00
Luis Ramos
fc4cf6a9a7
Merge resource_controller model_class method with parent version
2020-12-03 15:32:20 -08:00
Luis Ramos
de19efca64
Fix rubocop issue and add missing exceptions to manual_todo to get a green rubocop run
2020-12-03 06:38:24 -08:00
Matt-Yorkley
7408c45980
Merge pull request #6297 from openfoodfoundation/rails-4-1
...
[Rails 4.1] Merge Rails 4.1 branch into master
2020-12-01 10:56:08 +01:00
Pau Pérez Fabregat
07a72eccd4
Merge pull request #6391 from Matt-Yorkley/paypal-stock-clashes
...
Paypal stock clashes
2020-11-27 17:08:15 +01:00
Matt-Yorkley
ea5c7c5990
Fix broken redirect after bulk product update
...
Error:
As an Administrator
I want to be able to manage products in bulk
updating when a filter has been applied
Failure/Error: expect(page.find("#status-message")).to have_content "Changes saved."
expected to find text "Changes saved." in "Saving.."
# ./spec/features/admin/bulk_product_update_spec.rb:451:in `block (2 levels) in <top (required)>'
2020-11-27 14:00:29 +00:00
Luis Ramos
3ebc8145df
Avoid calling update with nil values
2020-11-27 13:59:46 +00:00
Luis Ramos
6814eb663f
Fix respond_with error
2020-11-27 13:59:46 +00:00
Matt-Yorkley
3bfa903912
Revert "Move Spree::Admin::BaseController to Admin::BaseController"
2020-11-27 14:11:57 +01:00
Matt-Yorkley
0ba670b180
Ensure order is cleanly reset to cart state when redirecting to cart
2020-11-27 11:42:46 +00:00
Matt-Yorkley
2fa2a30c67
Add spec coverage, refactor, avoid double-render errors
...
👍
2020-11-22 18:37:31 +00:00
Matt-Yorkley
cabec7e73f
Fix Rubocop warnings and tidy up
2020-11-22 18:02:54 +00:00
Matt-Yorkley
87df44764f
Extract stock-check logic to controller concern and inject prior to final Paypal payment confirmation.
2020-11-22 18:02:52 +00:00
Andy Brett
85d99f3bf2
Merge branch 'master' into controllers
2020-11-20 08:12:03 -08:00
Matt-Yorkley
010c1c799d
Add some notes on paypal checkout flow
2020-11-18 14:55:29 +00:00
Matt-Yorkley
2faea65f82
Bring in Spree::PaypalController#confirm method
...
Original method from the gem. This handles the post-payment response from paypal.
2020-11-18 14:51:23 +00:00
Matt-Yorkley
dd8f139c1b
Memoize Spree::PaypalController#payment_method
...
This gets called 4 or 5 times in a single request just to read basic attributes from the object. The query doesn't need to be repeated each time
2020-11-18 13:45:14 +00:00
Matt-Yorkley
6d0d4b5096
Bring in Spree::PaypalController#payment_method
...
Original method from the gem. Modified in preceding commit.
2020-11-18 13:45:13 +00:00
Matt-Yorkley
0b18b0dc0a
Include Calculator attributes in PaymentMethod nested attributes and DRY repeated code
2020-11-17 19:04:26 +00:00
Matt-Yorkley
36f4f40e84
Refactor and fix PaymentMethod strong params
2020-11-17 18:51:48 +00:00
Andy Brett
17202ff39c
move gateway_error require to lib/spree/core.rb
2020-11-10 14:55:56 -08:00
Luis Ramos
c785d0d1d7
Make engine's routes append to main app instead of prepend
2020-11-04 12:15:45 +00:00
Luis Ramos
09aef524f3
Make route helpers use spree helper
2020-11-04 12:15:45 +00:00
Luis Ramos
1b4a4a8113
Bring code from spree_paypal_express to make it use spree url_helper
2020-11-04 12:15:45 +00:00
Luis Ramos
c9972189d0
Change usage of Spree::Admin::BaseController to Admin::BaseController
2020-10-31 09:56:59 +00:00
Luis Ramos
66ba9ff73d
Move Spree::Admin::BaseController to Admin::BaseController
2020-10-31 09:51:37 +00:00
Luis Ramos
55e8dace44
Fix sort_by issue on relation by calling to_a
2020-10-30 10:12:56 +00:00
Luis Ramos
7b06fdd943
Convert to array before using sort_by!
2020-10-30 10:12:56 +00:00
