Maikel Linke
600c8fcd4c
Send confirmation emails immediately
...
Using deferred methods on the user model breaks delayed jobs when the
user is deleted while the job still exists. We could create a proper job
referencing a user id for sending these emails instead. But since the
user has to wait for the confirmation email anyway, we can send it
within the current request. This should be revised if performance
becomes an issue.
Sending the email directly also has the advantage that we can tell the
user if emailing failed. See the following commits.
This change impacts a bunch of specs as we now need a working email
setup to create unconfirmed users. This commit introduces a custom
matcher to unify testing for confirmation emails.
2018-09-27 13:33:08 +10:00
Maikel
9d48ea7b62
Merge pull request #2759 from luisramos0/del_old_spec_helper
...
Removed deprecated spec helper have_select2_option and fixed its last usage
2018-09-24 11:25:51 +10:00
luisramos0
33d2b65d65
Removed deprecated spec helper have_select2_option and fixed its last usage
2018-09-20 23:01:23 +01:00
luisramos0
2a68184c01
Deleted unused test helper for rabl views
2018-09-20 20:09:14 +01:00
Kristina Lim
cd41498da9
Ask to login when not authenticated for order page
...
Redirect the user to the login page, instead of responding with HTTP
401.
2018-09-06 16:26:48 +08:00
luisramos0
910297572e
Removed unnecessary currency from CartService constructor, using order.currency instead
2018-08-23 12:40:18 +01:00
luisramos0
05bfc098ff
/controllers/spree/order_populator_decorator (with a class_eval) is now /services/CartService with no dependency to Spree::OrderPopulator.
2018-08-23 12:39:55 +01:00
Maikel Linke
30fad228c5
Remove code duplication in spec helper
2018-08-07 09:24:31 +10:00
Maikel Linke
962c54b606
Remove unnecessary expectation
...
The `iframe` is rendered in pure HTML and should always be there.
2018-07-19 10:45:33 +10:00
Maikel Linke
8a3a617870
DRY specs with new EmbeddedPagesHelper
2018-07-19 10:44:43 +10:00
Maikel Linke
599f1a966b
Use embedded shops example for tests
2018-07-13 16:36:19 +10:00
Maikel Linke
ed747ec612
Use embedded groups example for tests
2018-07-13 15:37:19 +10:00
Rob Harrington
ffa8a8c7d6
Create Api::BaseController to allow use of ActiveModelSerializers
...
Also add index action to Api::CustomersController
2018-06-22 15:39:47 +10:00
Keir Osborn
bd7e072938
embedded groups layout changes
2018-06-22 14:03:00 +10:00
Keir Osborn
f626a21c5e
embedded groups initial test
2018-06-22 14:03:00 +10:00
Maikel Linke
682b92e617
Avoid deprication warning for using stub
2018-05-18 11:27:46 +10:00
Daniel Dominguez
9d9a974295
Switched gem FactoryGirl to FactoryBot as FactoryGirl is deprecated.
...
- Change FactoryGirl to FactoryBot everywhere on code.
2018-05-04 11:52:08 -03:00
Pau Perez
f5a5d735fd
Auto correct Rubocop's Layout/EmptyLinesAroundModuleBody cop
2018-04-09 18:47:18 +02:00
Pau Perez
746fcd5802
Auto correct Rubocop's Layout/EmptyLinesAroundAccessModifier cop
2018-04-09 18:47:17 +02:00
Rob Harrington
733dc76c6c
Order Cycles can be assigned to schedules via new/edit form
2018-02-09 14:43:29 +11:00
Pau Perez
719c45b408
Apply Rails 4 patch at boot time not only specs
...
This makes this patch available also for things like database-related
rake tasks. It moves the patch to an initializer.
2018-02-07 16:21:16 +11:00
Maikel Linke
b70edd5424
Enabling non-privileged postgres users to run specs
...
Addressing issue #245 .
A combination of fixtures and foreign key constraints requires the postgres
user to be superuser. Otherwise an attempt to disable constraints fails.
This got fixed in Rails 4 and this patch brings the same behaviour back to
Rails 3. It will allow us to run the specs with a nosuperuser postgres user.
See:
- https://github.com/matthuhiggins/foreigner/issues/61
- 9bb27f7ffe
2018-02-07 16:21:16 +11:00
Pierre de Lacroix
0fb66ab258
Fix CodeClimate issues
2017-12-01 13:37:30 +11:00
Pierre de Lacroix
f67a8c1f2d
Add tests
2017-12-01 13:37:24 +11:00
Andy Palmer
131bf842a9
Update matchers to non-deprecated protocol
2017-11-10 08:47:12 +11:00
Andy Palmer
8ec1c2e04a
No longer use expensive page.evaluate_script for imperative methods
2017-11-10 08:47:12 +11:00
Julius Pabrinkis
cec0a8c2e7
Specify page object for Capybara#find methods
2017-11-10 08:47:12 +11:00
Rob Harrington
c691e260cf
Rspec matcher enqueue_job for Delayed::Job supports block expectations
2017-11-10 08:47:12 +11:00
Pierre de Lacroix
508dfa4f23
Fix failing tests assuming localizeCurrency has no "delimiter"
2017-10-13 10:26:13 +11:00
Julius Pabrinkis
1fe20eba45
Add backend to be able to switch language by param and persist in cookies and user db
2017-09-20 13:23:15 +10:00
Julius Pabrinkis
ec6a365227
Add test coverage for switching language in darkswarm and admin
2017-08-02 09:57:33 +10:00
Rob Harrington
9f6931ba18
Move embedded shopfronts iframe view into spec/support/views
...
Was causing issues with zeus where it was (in spec/dummy)
Didn't get to the bottom of what was happening, this was
just a quick, simple and zero-cost solution
2017-07-28 11:54:48 +10:00
Rob Harrington
c7ed27286a
Rubocop: Correct Lint/ParenthesesAsGroupedExpression offences
2017-06-23 17:02:20 +10:00
Rob Harrington
7bb58342fc
Rubocop: Auto-correct Style/EmptyLineBetweenDefs offences
2017-06-23 16:49:08 +10:00
Rob Harrington
b277ff03ea
Rubocop: Auto-correct Style/TrailingBlankLines offences
2017-06-23 16:49:07 +10:00
Enrico Stano
3c1eae1f47
Do not blindly clear the whole Rails cache
2017-06-09 10:32:57 +10:00
enricostano
699da16049
Remove unused spec support method
2017-05-31 15:22:30 +10:00
Rob Harrington
6fc4a297a0
Fixing race condition on link click in spec/features/consumer/shopping/products_spec.rb
2017-05-19 13:15:30 +10:00
Julius Pabrinkis
f25e3bc6f7
Implement with_currency rspec helper for money amounts
2017-05-04 18:02:38 +01:00
Julius Pabrinkis
e63f1c2991
Refactor time and currency symbol getters
2017-05-03 12:59:16 +01:00
Rohan Mitchell
071ba5285d
Put timecop config in spec support
2016-11-25 14:28:05 +11:00
Rohan Mitchell
a1535d6c04
Catch flash messages after fadeout
2016-11-04 09:39:17 +11:00
Maikel Linke
7b2b285ba7
Rescue spec fails within enqueue_job matcher
...
Failing code tested by the enqueue_job matcher made it fail with:
expected ConfirmOrderJob to be enqueued matching {} (??? others enqueued)
That was not helpful and masking the real failure. That failure is now
passed on. The hidden intermittent failure happened in 5% of runs on
Travis.
2016-10-05 14:04:08 +11:00
Rohan Mitchell
b0eebc2e45
Round FlatPercentItemTotal calcs per-item before summing full quantity
2016-08-26 09:28:29 +10:00
Rohan Mitchell
0dc12d8791
Parameterise add_product_to_cart spec helper method
2016-08-26 09:28:29 +10:00
Rohan Mitchell
b13360d2d0
Extract filter helpers from individual spec to spec helper
2016-07-29 11:01:52 +10:00
Maikel Linke
c253d73d11
Refactoring with feedback on pr #1073
2016-06-29 15:46:51 +10:00
Maikel Linke
08fdc8a5bd
Load producers of all or selected order cycles into shop
2016-06-29 12:57:09 +10:00
Maikel Linke
5cd269411d
Trigger order button instead of click
2016-06-10 09:46:56 +10:00
Maikel Linke
21b8445753
Include job name in failure message
2016-05-25 11:58:57 +10:00
