Neal Chambers
5b6f45931c
Fix Layout/LineLength
2023-06-26 13:06:56 +09:00
Matt-Yorkley
3ef7d2c9ff
Remove master variant from product
2023-06-16 21:23:44 +01:00
Matt-Yorkley
6b9b5ea347
Stop storing unit_value and unit_description on master variant
2023-06-16 21:21:40 +01:00
Cillian O'Ruanaidh
5cde4de512
Ignore leading and trailing whitespace in spreadsheet when importing products
2023-06-09 16:23:18 +01:00
vviekk
e10ea4b686
Merge branch 'openfoodfoundation:master' into 9978
2023-03-11 11:00:03 +05:30
Jean-Baptiste Bellet
d9b534b829
+ update spec as well
2023-03-06 14:52:32 +01:00
vviekk
fc951e92ac
Updating price, on_hand, on_demand validations for product import
2023-02-18 13:52:35 +05:30
cyrillefr
b3ad5aeaca
Remove I18n keys in model specs
2023-02-16 14:28:14 +01:00
Vinicius Uehara
6da442eb97
Fix trailing whitespace
2022-10-30 21:42:48 -03:00
Vinicius Uehara
f6cc9fca26
Prioritize attribute errors over product validations
...
With product validations being prioritized, custom and
insightful error messages were being overwriten by
general and ambiguous model validations, which
were confusing users
2022-10-30 20:02:08 -03:00
Luis Ramos
23627c5453
Run rubocop -a (safe corrections) removing all exceptions so all possible fixes are applied
...
9290 issues fixed
2021-06-17 22:19:26 +01:00
Luis Ramos
5453a1c0fa
Adapt importer error to new ruby version 2.7
2021-06-04 22:42:27 +01:00
Luis Ramos
5b00868c6f
Allow mutable strings in some specs
2020-12-03 06:38:24 -08:00
Luis Ramos
2b8f0abe49
Try some mass auto-correct adding frozen-string-literal to all specs
2020-12-03 06:38:24 -08:00
Luis Ramos
fa6cf0f281
Fix prod importer spec in rails 4.1
2020-11-27 13:59:46 +00:00
Luis Ramos
1af4bf6994
Replace usage of create_enterprise_user with :user factory
2020-07-27 14:44:23 +01:00
Luis Ramos
1e5975c6e2
Fix rubocop issues
2020-06-22 17:39:20 +01:00
Luis Ramos
06a37d8ff0
Merge pull request #5566 from rioug/5132-no-error-when-product-csv-malformed
...
Add handling of CSV::MalformedCSVError for product_importer
2020-06-17 19:58:35 +01:00
Gaetan Riou
d3943bc92a
refactor error handling of CSV::MalformedCSVError and fix some typos
2020-06-11 16:47:58 +10:00
Gaetan Riou
9b8a97aadd
Add handling of CSV::MalformedCSVError for product_importer
2020-06-08 16:21:02 +10:00
Luis Ramos
8c367a2ed2
Merge branch 'master' into 3-0-stable-mar6
2020-03-09 13:20:19 +00:00
Matt-Yorkley
38215c2a88
Delete some dead code
...
This feature for assigning defaults via the UI was previously removed
2020-02-27 19:28:25 +01:00
Matt-Yorkley
53645517af
Update deprecated #find_by_* methods
2020-02-22 11:06:51 +00:00
Matt-Yorkley
f7bb609546
Fix flaky product import spec
2019-10-22 12:02:11 +01:00
luisramos0
a3c179bd3f
Fix some more simple rubocop issues
2019-07-31 09:36:48 +01:00
Matt-Yorkley
034e8b180a
Use let for CSV data
2019-06-25 10:24:53 +01:00
Matt-Yorkley
8dfb628d88
Add test for ignoring non-updatable description field in validations when updating
2019-06-25 10:19:05 +01:00
Kristina Lim
70614de955
Require product import rows to match unit of preceding rows
2019-06-10 04:20:03 +08:00
Kristina Lim
73b388da87
Simplify product import all_entries method
2019-06-10 04:20:03 +08:00
luisramos0
86b0d71c7e
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
2019-05-28 12:57:29 +01:00
Matt-yorkley
bc349faf8c
Fix on_hand failure
2019-05-05 12:00:46 +01:00
Matt-Yorkley
c04c54ebf6
Refactor importer setup and fix shipping_category usage
2019-05-05 12:00:46 +01:00
Matt-Yorkley
fd31a76fba
Test shipping_category presence validation
2019-05-05 12:00:46 +01:00
luisramos0
e9491cecab
Fix flaky spec by having only one variant with display name small bag
2019-04-06 10:14:19 +01:00
luisramos0
258a9efa0d
Adapt product_importer_spec to ofn v2 where there’s no product.count_on_hand and on_hand does not default to infinity if product.on_demand
2019-04-05 22:09:46 +01:00
luisramos0
ecc60f3b61
Merge branch 'master' into 2-0-stable-Mar29
2019-04-05 15:47:46 +01:00
Pau Pérez Fabregat
c515a8f115
Merge pull request #3537 from Matt-Yorkley/pi/on_demand_error
...
Fix nil values in on_hand column
2019-04-03 11:56:06 +02:00
luisramos0
5ce762a600
Uncomment product import specs so we can make them work in v2
2019-03-26 11:34:04 +00:00
luisramos0
5d51ad71b0
Merge branch 'master' into 2-0-stable-Feb20
2019-02-20 14:32:36 +00:00
Matt-Yorkley
09655b9f88
Fix nil values in on_hand column
2019-02-16 01:05:20 +00:00
Matt-Yorkley
0c5cc23415
Fix hash merge for recording already created products by name
2019-02-14 21:38:18 +00:00
Pau Pérez Fabregat
fce92090db
Merge pull request #3479 from luisramos0/2-0-stable-Feb12
...
[Spree Upgrade] Merging master into 2-0-stable (2nd run in Feb2019)
2019-02-14 09:40:28 +01:00
luisramos0
c652cfe4d5
Merge branch 'master' into 2-0-stable-Feb12
2019-02-12 16:03:33 +00:00
luisramos0
935c8cb0ce
Move ProductImporter spec to xdescribe until all its specs are green (spree upgrade phase 2)
2019-02-12 10:38:03 +00:00
luisramos0
fc1004cb3a
Added now mandatory shipping_category_id to CSVs in most tests in models/product_importer_spec
2019-01-29 14:55:18 +00:00
Matt-Yorkley
a3b9936f37
Improve matching inventory using 'items' unit type
2019-01-17 09:33:39 +00:00
Matt-Yorkley
3f62d82afc
Add more inventory testing for visibility in the inventory UI
2019-01-11 11:26:38 +00:00
luisramos0
fcdb5cd7af
Merge branch 'master' into 2-0-stable-nov-8th
2018-11-08 11:18:54 +00:00
luisramos0
5b6b0f408f
Move all specs in product_importer_spec temporarily to pending. There were 11 temporarily pending tests but more were failing
2018-10-21 22:02:34 +01:00
luisramos0
87cd73ddba
Merge branch 'master' into 2-0-stable-oct
2018-10-15 17:09:26 +01:00
