raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-27 01:43:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify product import all_entries method

Browse Source
This commit is contained in:
Kristina Lim
2019-06-07 03:05:12 +08:00
parent 38519b2bae
commit 73b388da87
2 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/models/product_import/product_importer.rb
View File

@@ -13,7 +13,7 @@ module ProductImport
include ActiveModel::Conversion
include ActiveModel::Validations
attr_reader :updated_ids, :import_settings
attr_reader :entries, :updated_ids, :import_settings
def initialize(file, current_user, import_settings = {})
unless file.is_a?(File)
@@ -90,10 +90,6 @@ module ProductImport
@processor.total_enterprise_products
end
def all_entries
@entries
end
def entries_json
entries = {}
@entries.each do |entry|

2
spec/models/product_importer_spec.rb
View File

@@ -343,7 +343,7 @@ describe ProductImport::ProductImporter do
expect(filter('valid', entries)).to eq 0
expect(filter('invalid', entries)).to eq 2
@importer.all_entries.each do |entry|
@importer.entries.each do |entry|
expect(entry.errors.messages.values).to include [I18n.t('admin.product_import.model.not_updatable')]
end
end