luisramos0
a66a4c3edb
Remove unnecessary passing of scopes around in controllers
2019-12-12 18:44:45 +00:00
luisramos0
8179252924
Replace the use of this with
2019-12-12 18:44:45 +00:00
luisramos0
0bec492208
Fix some rubocop issues
2019-12-12 18:44:45 +00:00
luisramos0
5cf50f0adf
Convert the manipulation of arrays into active record relations: let the DB do the matching job
2019-12-12 18:44:45 +00:00
luisramos0
197fb36524
Extract ExchangeProductsRenderer from ExchangesProductsController
2019-12-12 18:44:45 +00:00
luisramos0
62e6f09d94
Make exchange products more simple
2019-12-12 18:44:45 +00:00
luisramos0
79b2460664
Make simple create and edit OC load exchange products on init
...
Simple create makes a new type of call to exchange products with no exchange_id and no prder_cycle_id, it simply lists supplied products for a given enterprise
2019-12-12 18:44:44 +00:00
luisramos0
66f3656bb5
Register products panel listeners after OrderCycle is loaded instead of using recurrent timeouts
...
Also, use this same approach for the case where a new distributor or new supplier is added to the list of exchanges
2019-12-12 18:44:44 +00:00
luisramos0
6b087adab8
Add route to process requests to exchanges/products without exchange id
...
This is needed when products for an exchange that is not yet saved are requested
2019-12-12 18:44:44 +00:00
luisramos0
3653b88da6
Make exchanges_products_controller more independent of the exchange field
2019-12-12 18:44:44 +00:00
luisramos0
3223bf930d
Make total number of products in exchange work again.
...
Currently we are just loading the products from the server and count them.
This can be improved easily in two ways:
- we can switch this to a specific product count call to the server so that we dont load all products all the time
- or we paginate the products result and fetch the total_number from the payload of the first page.
2019-12-12 18:44:44 +00:00
luisramos0
2b3bc6d1ff
Remove supplied products from enterprise serializer and from UI side
...
This list of products s now loaded in a specific call to ExchangeProducts and for each specific exchange
2019-12-12 18:44:44 +00:00
luisramos0
24d7672abb
Use new exchange products endpoint for outgoing exchanges and make the exchange products panel work for outgoing exchanges
2019-12-12 18:44:44 +00:00
luisramos0
89628c27f3
Move exchange products endpoint to api namespace and make it work for outgoing exchanges
2019-12-12 18:44:44 +00:00
luisramos0
9adbdc377d
Add new admin/exchange/products endpoint that replaces Enterprise/for_order_cycle#supplied_products
2019-12-12 18:44:44 +00:00
luisramos0
883cd81058
Load enterprise supplied products when the exchange products panel is opened for the first time
2019-12-12 18:44:44 +00:00
Konstantin Shlyk
c5229dd763
billing address in pdf invoice fixed
2019-12-11 23:10:51 +03:00
Luis Ramos
7ccfdc8d21
Merge pull request #4546 from kshlyk/fix_cart_link_on_mobile
...
Cart link in header on mobile leads to cart page instead of checkout …
2019-12-11 13:45:56 +00:00
Luis Ramos
58a93c27ae
Merge pull request #4539 from luisramos0/subs_s3
...
Make weight calculator work for SubscriptionLineItems
2019-12-11 11:20:53 +00:00
Luis Ramos
9f351607d1
Merge pull request #4538 from mkllnk/4537-paginated-product-order
...
Make product order deterministic
2019-12-10 18:00:45 +00:00
Luis Ramos
71bf3f5f71
Merge pull request #4514 from luisramos0/backend_ctrl_overview
...
Bring spree_backend overview controller to OFN
2019-12-09 23:36:32 +00:00
Konstantin Shlyk
ef142de5f2
Cart link in header on mobile leads to cart page instead of checkout page
2019-12-09 22:58:00 +03:00
luisramos0
f64e8bf50e
Make user aware of server side errors when saving subscription products and unit test products_panel_controller
2019-12-09 17:49:38 +00:00
luisramos0
e9e6aa77d8
Make weight calculator work for SubscriptionLineItems by making it test if line_item responds to final_weight_volume field (final_weight_volume_present?)
...
We also add logic to weight_per_variant so that we use variant.unit_value if final_weight_volume is not available but variant_unit is weight
Adapt some test case to test unit_value (in grams) instead of weight (in kgs)
2019-12-08 17:36:21 +00:00
Matt-Yorkley
54a40fe79c
Handle validation messages when saving new fees
2019-12-07 14:51:17 +01:00
Maikel Linke
d4512904ea
Make product order deterministic
...
When products are sorted by name and two products have the same name,
their order is undefined. With pagination, two pages can have a
different order of products with the same name which then means that two
pages can return the same product.
Sorting by product id makes sure that the result is always in the same
order, for every page.
2019-12-05 15:37:10 +11:00
Luis Ramos
302de04e73
Merge pull request #4526 from kristinalim/fix/3149-fix_tool_tips_in_orders_list
...
3149 Fix tooltips in orders list
2019-12-04 10:38:28 +00:00
Luis Ramos
6db15a0a20
Merge pull request #4524 from Matt-Yorkley/packing_reports
...
Packing reports performance
2019-12-02 17:32:52 +00:00
Luis Ramos
c8395a487a
Merge pull request #4523 from luisramos0/permissions_improve
...
Replace pluck with select in permissions to avoid extra queries and extract Permissions::Orders from Permissions
2019-12-02 16:31:04 +00:00
Kristina Lim
2673a6efee
Fix Angular tracking of row in orders list
...
The tooltip content for the order in index n in page x was being used
for the order in index n in page y.
This was because ng-repeat was tracking the items/rows by index.
As far as ng-repeat is aware, rows with the same index in any page
were the same items/rows, so it didn't bother relinking the ofn-with-tip
directive.
2019-11-30 03:53:20 +08:00
Kristina Lim
6ffe7f1a99
Set width and enable wrapping for tooltips
2019-11-30 03:53:16 +08:00
Matt-Yorkley
38c327dae0
Improve N+1 issues around #suppliers_of_products_distributed_by
...
There's still some real mess here with repeating queries, but resolving it is out of scope for this quick PR
2019-11-29 20:16:03 +01:00
luisramos0
cc3368704a
Fix rubocop issues in reports_controller_decorator and in report line_items
2019-11-29 13:54:30 +00:00
luisramos0
3959f16d65
Switch some more references from Permissions to Permissions::Order
2019-11-29 12:22:50 +00:00
luisramos0
da6d035a1d
Rename some reports permissions to order_permissions
2019-11-29 11:23:17 +00:00
luisramos0
5cb77c443b
Fix rubocop issues
2019-11-29 10:53:40 +00:00
luisramos0
82b274e522
Make selector more specific to avoid sql error 'ambiguos column'
2019-11-29 10:49:58 +00:00
luisramos0
bb2e6324bd
Rename order permissions to just order
2019-11-29 10:49:27 +00:00
luisramos0
89056e13ed
Extract order permissions to a separate class
2019-11-29 10:48:58 +00:00
luisramos0
842e191c5f
Remove toggle_state action that is not used in OFN
2019-11-28 16:20:35 +00:00
Luis Ramos
e0e833b2f3
Merge pull request #4454 from luisramos0/sort_products
...
Sort products alphabetically in OC edit page
2019-11-27 22:27:42 +00:00
luisramos0
c8d359a0da
Merge spree/admin/overview_controller with its decorator
2019-11-27 22:08:46 +00:00
luisramos0
210757641c
Add overview_controller from spree_backend so that we can now merge it with the OFN's decorator
2019-11-27 22:08:06 +00:00
luisramos0
68bf599a1a
Merge spree/admin/adjustments_controller with decorator
2019-11-27 21:59:15 +00:00
luisramos0
a10966b66b
Add adjustments_controller from spree_backend so that we can now merge it with the OFN's decorator
2019-11-27 21:59:15 +00:00
Luis Ramos
7cc034c2bc
Merge pull request #4136 from mkllnk/4018-synchronise-checkout
...
Lock variants during checkout to avoid race condition
2019-11-27 15:40:28 +00:00
luisramos0
15bcde36cb
Remove order by filter on outgoing exchanges list of products
...
The products are now coming from the server already sorted
2019-11-26 17:59:30 +00:00
Matt-Yorkley
ff076fd7be
Eager-load option_values in Api::ProductsController
2019-11-23 10:58:18 +01:00
Matt-Yorkley
d30192207b
Eager-load option_values in ProducerMailer
2019-11-23 10:58:18 +01:00
Matt-Yorkley
19afc1a6da
Eager-load option_values in Api::VariantsController
2019-11-23 10:58:18 +01:00
