raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-02 21:57:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary passing of scopes around in controllers

Browse Source
This commit is contained in:
luisramos0
2019-11-22 14:29:41 +00:00
parent 8179252924
commit a66a4c3edb
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/admin/order_cycles/controllers/incoming_controller.js.coffee
View File

@@ -9,7 +9,7 @@ angular.module('admin.orderCycles').controller 'AdminOrderCycleIncomingCtrl', ($
enterprise = $scope.enterprises[exchange.enterprise_id]
return enterprise.numVariants if enterprise.numVariants?
$scope.loadExchangeProducts($scope, exchange)
$scope.loadExchangeProducts(exchange)
return unless enterprise.supplied_products?
enterprise.numVariants = $scope.countVariants(enterprise.supplied_products)

10
app/assets/javascripts/admin/order_cycles/controllers/order_cycle_exchanges_controller.js.coffee
View File

@@ -36,14 +36,14 @@ angular.module('admin.orderCycles')
$scope.removeDistributionOfVariant = (variant_id) ->
OrderCycle.removeDistributionOfVariant(variant_id)
$scope.loadExchangeProducts = (scope, exchange) ->
return if scope.enterprises[exchange.enterprise_id].supplied_products_fetched?
scope.enterprises[exchange.enterprise_id].supplied_products_fetched = true
$scope.loadExchangeProducts = (exchange) ->
return if $scope.enterprises[exchange.enterprise_id].supplied_products_fetched?
$scope.enterprises[exchange.enterprise_id].supplied_products_fetched = true
incoming = true if $scope.view == 'incoming'
params = { exchange_id: exchange.id, enterprise_id: exchange.enterprise_id, order_cycle_id: $scope.order_cycle.id, incoming: incoming}
Product.index params, (products) ->
scope.enterprises[exchange.enterprise_id].supplied_products = products
$scope.enterprises[exchange.enterprise_id].supplied_products = products
# Register listeners to capture first toggle open of the products panel of the exchange
$scope.exchangeListChanged = ->
@@ -57,5 +57,5 @@ angular.module('admin.orderCycles')
$scope.initializeExchangeProductsPanel = (selection, $element) ->
scope = $element.scope()
return if $scope.exchangeProdutsPanelInitialized[scope.exchange.enterprise_id]
$scope.loadExchangeProducts(scope, scope.exchange)
$scope.loadExchangeProducts(scope.exchange)
$scope.exchangeProdutsPanelInitialized[scope.exchange.enterprise_id] = true