David Cook
224b6f514b
Remove concept of master variant
...
from old bulk product screen. Hmm I just realised we're deleting that screen soon anyway.
But this helps clean up the spec before I refactor it further.
2023-10-24 15:21:13 +11:00
David Cook
be6481dac3
Refactor spec: combine expectations
...
These expectations have the same conditions, so why set it up three times?
2023-10-24 15:21:13 +11:00
David Cook
3710aa2149
Refactor spec
...
Better to explicitly test for the change, and specify expected values.
2023-10-24 15:21:13 +11:00
David Cook
a2f8b0db16
Update ansible group name
2023-10-24 10:37:32 +11:00
Maikel
42f5469de5
Merge pull request #11674 from mkllnk/money
...
Format money amounts according to locale, not currency
2023-10-24 09:47:37 +11:00
Gaetan Craig-Riou
9f426add8d
Merge pull request #11690 from openfoodfoundation/dependabot/npm_and_yarn/tom-select-2.2.3
...
chore(deps): bump tom-select from 2.2.2 to 2.2.3
2023-10-23 09:48:48 +11:00
filipefurtad0
e645ef72a7
Update all locales with the latest Transifex translations
v4.4.16
2023-10-20 12:27:28 +01:00
Konrad
2ba5ab7dc1
Merge pull request #11577 from jibees/10956-use-cable_ready-instead-of-morph
...
Admin, Orders list: when capturing an order, fix an issue that makes the tooltip invisible (+ errors in the console)
2023-10-20 11:56:53 +02:00
dependabot[bot]
c734f982a1
chore(deps): bump tom-select from 2.2.2 to 2.2.3
...
Bumps [tom-select](https://github.com/orchidjs/tom-select ) from 2.2.2 to 2.2.3.
- [Release notes](https://github.com/orchidjs/tom-select/releases )
- [Commits](https://github.com/orchidjs/tom-select/compare/v2.2.2...v2.2.3 )
---
updated-dependencies:
- dependency-name: tom-select
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-20 09:06:10 +00:00
Maikel
d45fe44c9f
Remove unused Code Climate badge
...
It always gave us a good score anyway because we ignored the bad code.
2023-10-20 10:22:42 +11:00
David Cook
8fad8b9f80
Merge pull request #11687 from filipefurtad0/fix_flaky_spec_#11686
...
Moves assertions within before do block
2023-10-20 09:57:41 +11:00
David Cook
801c30f4d5
Merge pull request #11685 from openfoodfoundation/dependabot/bundler/roadie-rails-3.1.0
...
chore(deps): bump roadie-rails from 3.0.0 to 3.1.0
2023-10-20 09:55:42 +11:00
David Cook
2d68d49c1f
Merge pull request #11683 from openfoodfoundation/dependabot/npm_and_yarn/babel/traverse-7.23.2
...
chore(deps): bump @babel/traverse from 7.21.5 to 7.23.2
2023-10-20 09:51:32 +11:00
David Cook
3805988c6e
Merge pull request #11682 from filipefurtad0/assert_status_on_order_confirmation_screen
...
Adds coverage on order confirmation page
2023-10-20 09:49:10 +11:00
Maikel
5d2d925eb6
Merge pull request #11547 from filipefurtad0/legal_invoices_associations_comparator_spec
...
Adds coverage on order-associated attributes
2023-10-20 08:52:27 +11:00
filipefurtad0
8d6ed5ec23
Moves assertions within before do block
...
Doing so, assures the removal of the invoice is finished, before clicking the 'Next - Order summary' button
2023-10-19 17:38:27 +01:00
filipefurtad0
c05716cea9
Addresses review suggestions from @dacook
...
I've noticed that it was necessary to include a reference to the order like 'order.adjustments << create(:adjustment, order:)' for the tests to pass
Updates test case description
2023-10-19 15:49:28 +01:00
dependabot[bot]
91f94505c2
chore(deps): bump roadie-rails from 3.0.0 to 3.1.0
...
Bumps [roadie-rails](https://github.com/Mange/roadie-rails ) from 3.0.0 to 3.1.0.
- [Changelog](https://github.com/Mange/roadie-rails/blob/master/Changelog.md )
- [Commits](https://github.com/Mange/roadie-rails/compare/v3.0.0...v3.1.0 )
---
updated-dependencies:
- dependency-name: roadie-rails
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-19 09:22:55 +00:00
dependabot[bot]
f35388ef3a
chore(deps): bump @babel/traverse from 7.21.5 to 7.23.2
...
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse ) from 7.21.5 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse )
---
updated-dependencies:
- dependency-name: "@babel/traverse"
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-19 02:28:53 +00:00
filipefurtad0
27ecd4224e
Sets tests as shared example (further DRYes spec)
2023-10-18 19:12:58 +01:00
filipefurtad0
461ef48c3a
DRYes spec
2023-10-18 18:26:42 +01:00
filipefurtad0
80f0b30e5c
Adds coverage on order confirmation page
...
Related to the changes from PRs #11668 and #11114 .
2023-10-18 16:02:31 +01:00
Filipe
caa655f500
Merge pull request #11668 from drummer83/master
...
Don't show credit owed when = 0 in order confirmation
2023-10-18 12:16:54 +01:00
Konrad
448eb8b3b1
Merge branch 'openfoodfoundation:master' into master
2023-10-18 12:41:12 +02:00
filipefurtad0
2004abc8be
Sets pending test - issue #11350
...
changing the payment_total should not generate a new invoice; rather, it should update the current invoice
2023-10-18 11:20:48 +01:00
filipefurtad0
530cdacc77
Restructures tests as shared examples
...
Merges test files
2023-10-18 11:20:06 +01:00
filipefurtad0
8a1a14112b
Moves tests to shared examples file
2023-10-18 11:20:05 +01:00
filipefurtad0
8b249ee050
Adds unit tests for different attributes
2023-10-18 11:19:03 +01:00
Maikel
0477bef53a
Merge pull request #11657 from mkllnk/report-job-retries
...
Notify user about errors raised in reports
2023-10-18 15:38:34 +11:00
Rachel Arnould
aecb55beb3
Merge pull request #11660 from dacook/products_v3_path
...
Hide old products screen when admin_style_v3 enabled
2023-10-17 10:45:01 +02:00
Gaetan Craig-Riou
d2952d46a6
Add the highlighted version of the "ship" icon
2023-10-17 13:35:01 +11:00
Gaetan Craig-Riou
7ce3fea7d5
Refactor tooltip on the backoffice orders page
2023-10-17 13:35:01 +11:00
Gaetan Craig-Riou
6a1664d2fd
Refactor "What's this" tooltip
2023-10-17 13:33:15 +11:00
Gaetan Craig-Riou
01a13a814a
Improve tooltip partial
2023-10-17 13:33:15 +11:00
Gaetan Craig-Riou
4639e53673
Remove insertToolTipMarkup
...
It's not great to have Stimulus controller rendering markup on `connect`
Stimulus is intended to add behavior to existing markup.
Plus add some documentation
2023-10-17 13:33:15 +11:00
Gaetan Craig-Riou
31c537c5e0
Revert to using morph instead of cable_ready
...
The issue is with with the stimilus tooltip controller, it add some
element to the DOM which create issue when it's modified by
StimulusReflex. See here for a more detailed explanation:
https://github.com/stimulusreflex/stimulus_reflex/issues/314#issuecomment-702479357
2023-10-17 13:33:15 +11:00
Jean-Baptiste Bellet
3525320590
We should use cable_ready.inner_html instead of morph
...
To be sure that every stimulus controllers attached to the DOM that is replaced is will connected.
What I saw is that when using `morph`, the stimulus controller (specially `tooltip_controller`) were not attached to the DOM (and not disconnected as well) that triggered some errors in the console.
Adds test case for payment capture thanks to @filipefurtad0
2023-10-17 13:33:15 +11:00
David Cook
ad9048c595
Merge pull request #11627 from dacook/reflex-locale
...
Ensure dynamic modals always use selected locale
2023-10-17 10:23:58 +11:00
Maikel Linke
c0938d1607
Simplify view with number helpers
2023-10-16 16:37:47 +11:00
Maikel Linke
fcb6e36480
Format money amounts according to locale
...
It used to be formatted according to the currency. So even if the
default currency is USD but your locale is French then you should see it
formatted as $10.000,00 instead of the US formatting of $10,000.00.
2023-10-16 11:19:11 +11:00
Maikel
c87a10a855
Merge pull request #11672 from openfoodfoundation/dependabot/bundler/bullet-7.1.2
...
chore(deps-dev): bump bullet from 7.1.1 to 7.1.2
2023-10-16 10:54:38 +11:00
Maikel
ba00106e38
Merge pull request #11671 from openfoodfoundation/dependabot/bundler/acts-as-taggable-on-10.0.0
...
chore(deps): bump acts-as-taggable-on from 9.0.1 to 10.0.0
2023-10-16 10:54:12 +11:00
dependabot[bot]
d76dbb3592
chore(deps-dev): bump bullet from 7.1.1 to 7.1.2
...
Bumps [bullet](https://github.com/flyerhzm/bullet ) from 7.1.1 to 7.1.2.
- [Changelog](https://github.com/flyerhzm/bullet/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flyerhzm/bullet/compare/7.1.1...7.1.2 )
---
updated-dependencies:
- dependency-name: bullet
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-15 23:24:48 +00:00
dependabot[bot]
c4adcf93c0
chore(deps): bump acts-as-taggable-on from 9.0.1 to 10.0.0
...
Bumps [acts-as-taggable-on](https://github.com/mbleigh/acts-as-taggable-on ) from 9.0.1 to 10.0.0.
- [Release notes](https://github.com/mbleigh/acts-as-taggable-on/releases )
- [Changelog](https://github.com/mbleigh/acts-as-taggable-on/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mbleigh/acts-as-taggable-on/compare/v9.0.1...v10.0.0 )
---
updated-dependencies:
- dependency-name: acts-as-taggable-on
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-15 23:23:51 +00:00
Maikel
9c5b986ab6
Merge pull request #11664 from openfoodfoundation/dependabot/bundler/rubocop-1.57.1
...
chore(deps-dev): bump rubocop from 1.57.0 to 1.57.1
2023-10-16 10:05:14 +11:00
Maikel
08e799c5fa
Merge pull request #11663 from dacook/tag_release
...
Update tag_release script
2023-10-16 10:02:41 +11:00
drummer83
c2b82651ee
Don't show credit owed when = 0
2023-10-13 20:51:12 +02:00
Konrad
246fceb214
Merge pull request #11634 from lauriejefferson/11610-left-align-all-table-content
...
[BUU] Left-align headers of new orders table
2023-10-13 19:58:09 +02:00
David Cook
6e6854f564
Fix payment state indicator
...
Now the correct class is added, we can see the little coloured circles again.
2023-10-13 19:25:12 +02:00
lauriejefferson
e234b71b25
removed empty spaces
2023-10-13 19:25:12 +02:00