Rob Harrington
c835b4eb1a
Replacing stub_model objects with actual factory generated instances
2017-11-10 08:47:12 +11:00
Rob Harrington
ef9e43fbd3
Replacing mock_model objects with instance_doubles
2017-11-10 08:47:12 +11:00
Rob Harrington
f083433854
Explicitly specifying 'type: :helper' for all helper specs
2017-11-10 08:47:12 +11:00
Rob Harrington
9052b1c3db
A few updates to spec where 'be true' and 'be false' didn't cut it
2017-11-10 08:47:12 +11:00
Rob Harrington
59578a73af
Changing all references to 'be_true' and 'be_false' to 'be true' and 'be false'
...
See next commit for changes where this substitution was broken
2017-11-10 08:47:12 +11:00
Rob Harrington
c691e260cf
Rspec matcher enqueue_job for Delayed::Job supports block expectations
2017-11-10 08:47:12 +11:00
Rob Harrington
82072c8970
Explicitly specifying 'type: :controller' for all controller specs
2017-11-10 08:47:12 +11:00
Rob Harrington
d0c52ac176
Updating outdated guard gems
2017-11-10 08:47:12 +11:00
Rob Harrington
6811a62568
Updating RSpec Gems
2017-11-10 08:47:12 +11:00
Buildkite
8653d03969
Merge remote-tracking branch 'origin/master' into HEAD
2017-11-09 13:49:39 +00:00
lin-d-hop
90d5a04368
Adding UK About pages to menus
2017-11-09 11:06:58 +00:00
Pau Perez
84e4ebef08
Do not notify Bugsnag of a cache miss
...
It's not the responsibility of a error tracking software to track
neither cache misses nor logs. That is what log monitoring is for.
2017-11-09 10:22:31 +01:00
Pau Perez
98603c4042
Do not test private methods
2017-11-09 10:22:31 +01:00
Pau Perez
26a4ee0171
Do not stub object under test
2017-11-09 10:22:31 +01:00
Pau Perez
4f03a2d25c
Remove unnecessary require
2017-11-09 10:22:31 +01:00
Pau Perez
6a830a3843
Isolate ArraySerializer case in injection helper
...
This makes this special case with the ArraySerializer stand out so that
the reader notices it.
2017-11-09 10:22:30 +01:00
Pau Perez
3ffd049135
Remove commented out code
2017-11-09 10:22:30 +01:00
Rob Harrington
e6d1b38b82
Remove upgrade_bundler script by reverting 250062bd2, 3f2299e52 and 5dfac10599
2017-11-09 19:46:41 +11:00
Rob Harrington
f8a892faf2
Remove upgrade_bundler script by reverting 250062bd2, 3f2299e52 and 5dfac10599
2017-11-09 18:24:22 +11:00
Pierre de Lacroix
54e141489a
Add noindex meta tag for invisible shops and staging environment
2017-11-09 12:04:27 +11:00
Pau Perez
e64fd1d308
Lower log level in prod to :info so we can debug
...
Otherwise, there are no log lines for any request, which makes it
impossible to find out anything about the app in production.
Obviously this increases the size of the log files but this has to be
dealt with log rotation. The data is our most important asset.
2017-11-09 11:13:32 +11:00
Matt-Yorkley
01647c3df9
Disable allow_backorders by default in test environment
2017-11-02 17:43:46 +11:00
Rob Harrington
cd6d7c76f6
Fix spec that requires preference persistence
2017-11-02 17:43:04 +11:00
Rob Harrington
efa71c4ac8
Use Spree's approach for handling config when testing
2017-11-02 17:43:04 +11:00
Rob Harrington
d4eb27a4ed
Fix race condition in shipping method order spec
2017-11-01 16:37:12 +11:00
Duende13
eca18ba6ee
Test to control order of shipping methods by name
2017-11-01 15:30:42 +11:00
Duende13
31fa49feed
Added orderBy 'name' to the list of shipping methods offered.
2017-11-01 15:30:42 +11:00
yasirazgar
b68aafdb72
1799 - adding missing translations in new shipping methods page
2017-11-01 10:50:21 +11:00
Andy Palmer
fd09a63e48
Imperative specs as per review comments
2017-10-24 17:56:04 +11:00
Andy Palmer
afc50863cd
Replace Deface with update to overridden template
2017-10-24 17:39:34 +11:00
Andy Palmer
fea2240c39
Disabled product links in cart for openfoodfoundation/openfoodnetwork#1075
2017-10-24 14:56:35 +11:00
Rob H
9642e8295e
Merge transifex translations
2017-10-21 00:23:40 +11:00
Enrico Stano
1424d44eab
Merge pull request #1919 from nicolauduran/add-dev-doc
...
Add more development documentation
2017-10-20 14:31:43 +02:00
Nicolau Duran
0a5f0a518d
Add development doc
2017-10-20 13:18:21 +02:00
Transifex-Openfoodnetwork
ff1672e411
Updating translations for config/locales/nb.yml [skip ci]
2017-10-20 19:50:21 +11:00
Transifex-Openfoodnetwork
32d8368990
Updating translations for config/locales/fr.yml [skip ci]
2017-10-20 19:42:24 +11:00
Lynne
e7f8102eb9
Update en-GB.yml
2017-10-20 08:29:18 +01:00
Rob Harrington
24e1d0b775
Fix mistyped translation key for 'dashboard'
2017-10-20 16:26:08 +11:00
Rob Harrington
ceadd386aa
Update order spec to test an order with a total > 0
...
This is necessary because the previous commit changed the logic
around payment state, meaning that a complete order with a total
of 0 and no complete paymnents is considered to have a payment
state of 'paid'. I don't think this is problematic, since it is
not possible to check out an order without line items.
This way the spec tests an order modelled on the real world.
2017-10-20 15:21:59 +11:00
Rob Harrington
d42dc2b286
Fix #1902 : ensure correct payment state when failed payments are present
...
Problem: order payments didn't seem to be loaded in any particular order,
and OrderUpdater#update_payment_state was relying on payment order to de-
termine payment state.
Strategy: Adapt a version of this method from a future version of Spree.
I tried to select a version where I would have to make the absolute mini-
mum number of changes to get it to work. See comments in code for justif-
ications of the changes that I did make.
2017-10-20 15:21:59 +11:00
Continuous Integration
e9c8e17710
Merge remote-tracking branch 'origin/master' into HEAD
2017-10-19 20:42:35 +11:00
Lynne
bfd845915c
Update en-GB.yml
2017-10-19 10:41:21 +01:00
Rob Harrington
b7976a2356
Do not update finalized fee adjustments
2017-10-19 16:54:39 +11:00
Rob Harrington
cd744dab68
Ignore .byebug_history after recent update of byebug gem
2017-10-19 10:45:24 +11:00
Transifex-Openfoodnetwork
02e3aac3f0
Updating translations for config/locales/fr.yml [skip ci]
2017-10-19 04:38:24 +11:00
Transifex-Openfoodnetwork
50075f02a0
Updating translations for config/locales/es.yml [skip ci]
2017-10-18 19:29:14 +11:00
Enrico Stano
05d8cd09e3
Merge pull request #1890 from coopdevs/add-node-version
...
Track node version in .node-version
2017-10-18 09:24:06 +02:00
Justyna Field
02fd87158e
Add display flex on active table row to fix misalignment
2017-10-18 15:05:55 +11:00
Pierre de Lacroix
165af4b812
Use I18n "lazy" lookup
2017-10-18 14:38:40 +11:00
Pierre de Lacroix
dba8e36752
Change key for uncapitalized "items" translation
2017-10-18 14:38:40 +11:00
