Maikel
8837f1caa2
Revert "Allow negative stock levels for on-demand products"
2024-06-19 15:18:57 +10:00
Maikel Linke
d5b77a4f80
Ensure all assets are compiled on test page visit
2024-06-19 11:45:28 +10:00
Maikel Linke
10f0eeef0b
Update spec for quotation mark replacement
...
I'm not sure why, but the pre-compiling of assets triggered Rails to
render `style="..."` instead of `style='...'` in this case. But when
assets are compiled on-demand, we get the single quotes. So I changed
the spec to be agnostic of this detail. We actually just want to know
about the link and its href.
2024-06-19 11:40:09 +10:00
filipefurtad0
fe93e3ed97
Restructures spec
...
Separating into different contexts, with and without invoices feature enabled
2024-06-18 19:32:44 -06:00
Maikel
1e189207ed
Merge pull request #12583 from dacook/add-attachment-translation
...
Add translation key for Spree::Image#attachment
2024-06-19 11:20:07 +10:00
Maikel
af2e7db155
Merge pull request #12582 from cyrillefr/FixRails_UnusedRenderContentIssues
...
Fixes offenses raised by Rails/UnusedRenderContent
2024-06-19 11:19:22 +10:00
Maikel
2188e96dfb
Merge pull request #12575 from zanetagebka/RedundantInterpolationCops
...
Solve Rubocop RedundantInterpolation cops
2024-06-19 11:01:42 +10:00
David Cook
6ce442a42e
Add translation key for Spree::Image#attachment
2024-06-19 09:49:15 +10:00
David Cook
2676891322
Merge pull request #12546 from dacook/buu/change-columns-11055
...
[BUU] Change product columns to be shown
2024-06-19 09:25:47 +10:00
Gaetan Craig-Riou
55ae1ba29f
Merge pull request #12579 from openfoodfoundation/dependabot/npm_and_yarn/ws-6.2.3
...
chore(deps): bump ws from 6.2.2 to 6.2.3
2024-06-19 09:17:53 +10:00
David Cook
6fd3cada8c
Fix classname
2024-06-19 09:13:53 +10:00
zanetagebka
b4bfcb7cc8
rubocop_todo recreate
2024-06-18 14:34:03 +02:00
zaneta.gebka
5cc33d1e0c
Merge branch 'master' into RedundantInterpolationCops
2024-06-18 14:33:12 +02:00
zanetagebka
c6254a5b7e
rubocop_todo recreate
2024-06-18 14:32:41 +02:00
cyrillefr
a155630b1c
Fixes offenses raised by Rails/UnusedRenderContent
...
- in any cases, adding status: :no_content dropes content from response
- replaced by head :no_content (HTTP 204)
2024-06-18 13:33:19 +02:00
Rachel Arnould
0c6cc9b822
Merge pull request #12558 from cyrillefr/BUUUploadingCorruptProductImagesFailsSilently
...
BUU Display error messages when file not valid
2024-06-18 12:12:51 +02:00
David Cook
b8f8d6d042
Show/hide columns with CSS selectors instead
...
Well, that made the JS way simpler.
Adds a lot of classes though. Maybe we could do it based on column index instead, but this will do for now.
table.hide-col0 { td:nth-child(0) { display: none; } }
2024-06-18 15:35:53 +10:00
David Cook
4023dc2265
Cache yarn dependencies
...
I don't know what this actually does, because it doesn't install the dependencies, that still needs to happen next.
But surely any cache is a good thing?
2024-06-18 13:09:45 +10:00
dependabot[bot]
9543b597d0
chore(deps): bump ws from 6.2.2 to 6.2.3
...
Bumps [ws](https://github.com/websockets/ws ) from 6.2.2 to 6.2.3.
- [Release notes](https://github.com/websockets/ws/releases )
- [Commits](https://github.com/websockets/ws/compare/6.2.2...6.2.3 )
---
updated-dependencies:
- dependency-name: ws
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-18 02:16:27 +00:00
Ahmed Ejaz
d2737bd8b0
11987: refactored code
2024-06-18 00:44:10 +05:00
Ahmed Ejaz
05fe7cd4b9
11987: add flash messages for product clone
2024-06-17 23:17:32 +05:00
Ahmed Ejaz
30528cab0f
11987: add slide-in animation for product clone
2024-06-17 22:58:36 +05:00
Ahmed Ejaz
539ffb1f35
11987: add product clone turbo partial
2024-06-17 21:59:26 +05:00
Ahmed Ejaz
df2bad9b8f
11987: add product_variant_row partial
2024-06-17 21:59:07 +05:00
Ahmed Ejaz
fa3b84b71f
11987: add clone action
2024-06-17 21:58:07 +05:00
Ahmed Ejaz
2ca4febf90
11987: add product clone route
2024-06-17 21:57:19 +05:00
cyrillefr
8616847793
Update button should change status on modified white label
...
- swap position between users & white label so that user's inner form
- does not interfere with white_label own position in outer form
- modified spec so that lowermost user is clickable
2024-06-17 17:11:19 +02:00
zanetagebka
dd7ae1330f
Merge remote-tracking branch 'origin/RedundantInterpolationCops' into RedundantInterpolationCops
...
# Conflicts:
# .rubocop_todo.yml
2024-06-17 15:40:03 +02:00
zanetagebka
93eda48138
recreate rubocop_todo
2024-06-17 15:39:29 +02:00
zanetagebka
ad92d4b129
Solve Rubocop RedundantInterpolation cops
2024-06-17 15:37:39 +02:00
zanetagebka
422965748f
Solve Rubocop RedundantInterpolation cops
2024-06-17 15:32:25 +02:00
David Cook
aff50f66c4
Name and Producer columns grow to fill and other tweaks
...
If neither are visible, the first column on the left (eg image) will grow. But that's not a likely scenario.
Min-widths help manage sizes on smaller screens in Chrome.
The title for Inherits Properties gets cut off, but I think it's better than cutting off content.
Oh look, it fixed a spec too!
2024-06-17 12:27:06 +10:00
Gaetan Craig-Riou
cc45b9a0d3
Merge pull request #12557 from filipefurtad0/feature_parity_buu
...
Updating specs for BUU (feature parity)
2024-06-17 09:39:01 +10:00
cyrillefr
e07cf6c628
Do not use rescue as control flow
2024-06-16 23:38:38 +02:00
Maikel Linke
885f679eb1
Update all locales with the latest Transifex translations
2024-06-14 11:26:09 +10:00
Maikel
70ad8c80e1
Merge pull request #12568 from openfoodfoundation/revert-12458-12374-bulkk-sending-invoice-must-show-error-if-abn-require-and-not-set
...
Revert "[Invoices] Notify if any order cannot be invoiced on bulk invoice sending"
2024-06-14 11:23:52 +10:00
Maikel Linke
6a4a238378
Avoid flakiness with Capybara features
...
Capybara should be clever enought to scroll to an element. The old
method failed nine times in CI. I couldn't reproduce it locally but
let's see if this is better.
2024-06-14 10:47:35 +10:00
Maikel Linke
3c9f77dc2b
Restore image display with absolute width
...
The `min-width` property is ignored by Firefox. And we don't need the
column to grow any bigger than the picture size anyway. An absolute
width is correct here.
The specification says:
> Applies to all elements but non-replaced inline elements, table rows,
> and row groups.
Firefox is totally right in ignoring it.
2024-06-14 09:48:55 +10:00
filipefurtad0
9cd1977cf8
Removes product creation test
...
This is already covered some lines above and on e22bec014b/spec/system/admin/products_spec.rb (L29)
2024-06-13 12:15:24 -06:00
filipefurtad0
9e5c21f7cd
Corrects test case by adding expect
...
has_select? only returns true or false, it requires an assertion to assure the test is evaluated
Improves syntax
2024-06-13 12:06:34 -06:00
Filipe
df30c1af98
Revert "[Invoices] Notify if any order cannot be invoiced on bulk invoice sending"
2024-06-13 08:55:59 -06:00
Filipe
e22bec014b
Merge pull request #12538 from cyrillefr/UpdateAndRecalculateFeesAfterOrderAdjustedInBackend
...
Update and Recalculate Fees after Order Adjusted in Backoffice
2024-06-13 08:53:43 -06:00
cyrillefr
0470efa502
Requested changes: turbo_stream for success
...
- must respond via turbo for create and update for success
- changed the spec accordingly
2024-06-13 15:22:54 +02:00
Maikel Linke
81a8ee5a31
Error messages don't block bottom of page clicks
...
The flash container was set to 100% width to center the messages on the
screen. The messages were covering only part of the screen though. So
the container beyond the actual message box was covering part of the
page, blocking clicks on elements.
A new way of centering the container with CSS translate means that the
width of the container can be the same as the content, not covering
anyting accidentally.
And moving the whole container up instead of only moving the contained
message allows us to interact with elements below the flash message as
well.
2024-06-13 11:20:54 +10:00
David Cook
5d0e241f8c
Pending spec
...
Probably due to column tweaks, revealing different existing problems.
2024-06-13 11:12:31 +10:00
David Cook
b25d2ed32a
Refactor to fix Metrics/AbcSize linter
2024-06-13 10:51:35 +10:00
David Cook
db27fc5a2b
Remove dead code
...
I'm pretty sure that case doesn't happen, and besides there's no spec for it.
2024-06-13 10:51:00 +10:00
David Cook
a7ef243262
Enable all columns by default
2024-06-13 10:43:33 +10:00
David Cook
e7774d7a24
Lint fix
...
Sorry didn't have time to go back and rebase
2024-06-13 10:39:19 +10:00
David Cook
9ae4d347aa
Update widths
...
For some reason, minimum widths work now (I swear they didn't before).
Hmm i would really like to shorten that stimulus controller name.
2024-06-13 10:36:28 +10:00
