Gaetan Craig-Riou
1e6fbadd8b
Fix Vine::VoucherRedeemerService to handle exceptions
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
d102652c03
Fix Vine::VoucherValidatorService to handle exceptions
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
1b50217242
Re worked the Vine::ApiService to raise exception on error
...
Log Client and Server error, and re raise exception for the caller
to handle
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
73819a4638
Fix unique validator for vouche code
...
Paranoia doesn't support unique validation including deleted records:
https://github.com/rubysherpas/paranoia/pull/333
We use a custom validator, ScopedUniquenessValidator to avoid the issue
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
9ab2a3ae3d
Per review, fix a some minor issues
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
d413a142c9
Update various voucher related file to use the new Vouchers::Vine
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
48ad7ed8a0
Add voucher used by multiple enterprise and recycle code scenario
...
Plus optimise code with `find_or_initialize_by` as suggested in review
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
a2c4c44eea
Move Vine voucher to Vouchers::Vine
...
A Vine voucher is really a specific type of FlatRate voucher but because
a Vine voucher can be used by mutiple enterprise, it can be considered
different enough to warrant it's own class.
It still share a lot of the behaviour of a FlatRate voucher, so to avoid
duplication, all the shared functionality have been moved to a
Vouchers::FlatRatable concern.
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
e7ece294cc
Better error for VineVoucherValidatorService
...
Co-authored-by: David Cook <david@redcliffs.net >
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
d7313ffec9
Per review, improve Vine::VoucherValidatorService
...
plus specs
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
b42cba8c37
Add vine_voucher factory
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
7726c7d129
Per review, rename not_vine scope to local
...
- use IS DISTINCT FROM instead of two conditions
- added spec for scope
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
12cf62c2ff
Refactor, add OrderManagement::Order::Updater#update_voucher
...
Move the logic to update a voucher and associated order to
`OrderManagement`
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
0569b30e0d
Refactor Vine related services
...
Move them under Vine module to keep the code nicely organised
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
9f3da1af4f
Reddeem VINE voucher when firing "capture_and_complete_order"o
...
'Spree::Payment#capture_and_complete!' will try to complete the order,
so we want to redeem any VINE voucher associated with the order first.
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
afb336d789
Add spec for fire event "capture_and_complete_order"
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
92c4cb9b7f
Redeem VINE voucher when creating a new payment
...
Creating a new payment will try to complete the order, so we want to
redeem any VINE voucher associated with the order first
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
724d5a2ca0
Add spec for creating a payment from admin page
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
cf13dc2ff6
Add system spec when completing order with VINE voucher
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
4906c19c8e
Checkout Summary, remove shared example
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
129ccc33f8
CheckoutController, add VINE voucher redemption
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
9399c7e129
Add VineVoucherRedeemerService
...
It handles redeeming a voucher
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
b30096317c
VineApiService, add voucher_redemptions
...
It is used to redeem a voucher
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
c89b4fb86b
Add system spec fot adding VINE voucher to order
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
3a367ceb6e
Handle adding a VINE voucher to an order
...
Plus specs
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
f9fb7bf399
Add VineVoucherValidatorService and spec
...
It handles validating and creating vine voucher
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
7cbe77668a
VineApiService, add voucher_validation
...
It is used to validate a voucher using the given short code
2024-11-28 13:35:01 +01:00
Rachel Arnould
479eacc956
Merge pull request #12964 from chahmedejaz/task/12890-add-data-to-dfc-affiliate-sales-endpoint
...
Add cities and countries to DFC affiliate sales data endpoint
2024-11-28 10:46:20 +01:00
Filipe
a493d70f5c
Merge pull request #12950 from macanudo527/unlock_bigdecimal
...
Fix rounding issues by upgrading decimal maths library
2024-11-25 19:18:19 -06:00
Ahmed Ejaz
7ca544540b
12890: fix product names
2024-11-24 15:24:39 +05:00
Maikel
3ec8cd24d3
Merge pull request #12960 from mkllnk/dfc-link-backorder
...
Store link to open backorder
2024-11-22 10:22:43 +11:00
Filipe
22f3afc7f7
Merge pull request #12930 from chahmedejaz/task/12878-add-variant-name-in-od-report
...
Report Orders and Distributors should display variant
2024-11-20 12:23:36 -06:00
Maikel Linke
46048dcd18
Handle empty backorder
...
Backorder can become empty after a customer cancels their order. Then we
don't want to fail but also don't need to place an order.
2024-11-19 15:53:59 +11:00
Maikel Linke
a8fb6492f4
Lookup backorder for updates with saved link
2024-11-19 15:53:59 +11:00
Maikel Linke
4610141ed8
Add shortcut to order's exchange
2024-11-19 15:53:59 +11:00
Maikel Linke
8098131dba
Store link to open backorder
...
We don't use the link yet, but it's there.
2024-11-19 15:53:59 +11:00
Maikel Linke
597d9ad314
Add semantic links to Exchange
2024-11-19 15:53:59 +11:00
Maikel Linke
1ce0b25bb0
Switch SemanticLink to use new association
...
And ActiveRecord magic does the rest when used correctly.
2024-11-19 15:53:58 +11:00
Maikel Linke
c07ec6cdfd
Polymorphically associate SemanticLinks to variant
2024-11-19 15:53:58 +11:00
Ahmed Ejaz
6b3b29ac39
12776: refactor spec
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
9bcdac8f30
12776: rename vat to tax
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
e2d999da8d
12776: use EnterpriseFeeCalculator in specs
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
298c0e8d7f
fix reported issues:
...
- wrong enterprise fees
- always 0 tax on fees
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
ed559b5257
update specs to have more line items
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
ec0d2d346b
use to_date for locale based formating
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
654263a823
add systems spec
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
4349e42a84
12776: add specs
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
39fa8e0ace
12878: fix migration class name
2024-11-14 11:04:28 +05:00
Neal Chambers
7a5074cc90
Refactor option_value_value_unit_scaled for correct unit value scaling and update sales tax report spec for clarity
2024-11-13 16:28:18 +09:00
Neal Chambers
3302f0e78d
Improve Precision of Spec for New Version of BigDecimal
2024-11-13 16:28:18 +09:00
