Abdellani
7a015bad96
populate destroyed_by on produce_v3_controller#destory
2024-06-19 15:14:32 +01:00
Maikel
af2e7db155
Merge pull request #12582 from cyrillefr/FixRails_UnusedRenderContentIssues
...
Fixes offenses raised by Rails/UnusedRenderContent
2024-06-19 11:19:22 +10:00
David Cook
2676891322
Merge pull request #12546 from dacook/buu/change-columns-11055
...
[BUU] Change product columns to be shown
2024-06-19 09:25:47 +10:00
cyrillefr
a155630b1c
Fixes offenses raised by Rails/UnusedRenderContent
...
- in any cases, adding status: :no_content dropes content from response
- replaced by head :no_content (HTTP 204)
2024-06-18 13:33:19 +02:00
David Cook
b25d2ed32a
Refactor to fix Metrics/AbcSize linter
2024-06-13 10:51:35 +10:00
David Cook
db27fc5a2b
Remove dead code
...
I'm pretty sure that case doesn't happen, and besides there's no spec for it.
2024-06-13 10:51:00 +10:00
David Cook
e7774d7a24
Lint fix
...
Sorry didn't have time to go back and rebase
2024-06-13 10:39:19 +10:00
Maikel
5b95ef3bd9
Merge pull request #12525 from mkllnk/fdc-import
...
Add compatibility to the DFC product import for FDC (Shopify) API
2024-06-13 09:51:05 +10:00
David Cook
ae66a85cc5
Show error messages
...
There shouldn't normally be errors, but I got one due to bad data during development, and this helped sort it out.
2024-06-12 14:58:09 +10:00
David Cook
89cedc4287
Submit and render with Turbo Stream
2024-06-12 14:49:59 +10:00
David Cook
68da9c9e04
Add form to save column preferences
2024-06-12 14:49:53 +10:00
zanetagebka
a2a670c848
Fix cops StringConcatenation
2024-06-11 15:17:32 +10:00
Gaetan Craig-Riou
8b31fa1ee5
Merge pull request #12541 from openfoodfoundation/dependabot/bundler/rubocop-1.64.1
...
chore(deps-dev): bump rubocop from 1.63.5 to 1.64.1
2024-06-11 10:30:28 +10:00
David Cook
9c0f55ad22
Refactor
2024-06-05 09:45:30 +10:00
Maikel Linke
d9f013abbc
Style/SendWithLiteralMethodName
...
Use method call directly instead of `public_send` with fixed argument.
The cop is declared unsafe. I think that is because it can also replace
`send` but we replace only `public_send` here.
2024-06-05 09:38:21 +10:00
Ahmed Ejaz
ce60a2a1e0
12398: add lazylookup for translations
2024-05-30 14:44:34 +05:00
Ahmed Ejaz
c2fa993432
12398: fix lint issues
2024-05-30 14:24:51 +05:00
Ahmed Ejaz
8ee833d2d8
12398: add flash.now
2024-05-29 01:19:50 +05:00
Maikel Linke
fae7a089ee
Import products from the FDC (Shopify) API
2024-05-28 17:00:06 +10:00
Maikel Linke
635234a889
Enable POSTing DFC data
2024-05-28 15:10:05 +10:00
Ahmed Ejaz
fb07794cf3
12398: add slide-out animation
2024-05-28 01:10:30 +05:00
Ahmed Ejaz
a0f290c09f
12398: add turbo stream to delete variants
2024-05-24 02:41:51 +05:00
Ahmed Ejaz
2bdf8e2853
rename destroy.turbo_stream to make it more generic
2024-05-24 02:40:34 +05:00
Ahmed Ejaz
039b0d80ee
12398: implement the destroy action for products
2024-05-24 01:55:21 +05:00
Ahmed Ejaz
53fb77eb23
12398: add destroy action with turbo stream
2024-05-24 01:16:14 +05:00
Filipe
5455e68620
Merge pull request #12504 from dacook/buu/edit-image-turbo-12399
...
[BUU] Remove StimulusReflex from Image Edit
2024-05-23 17:32:59 +01:00
David Cook
536b5608ab
Show edit form for new images
2024-05-22 17:08:58 +10:00
Maikel Linke
45c164d5ae
Avoid submitting duplicate connected apps
...
Simple Rails forms prevent double-clicking on submit already. Converting
the StimulusReflex interaction to a simple form submit to a controller
solves the race condition.
The UX is slightly worse because the whole page is reloaded instead
rendering only the connected app panel. But we can solve that when we
add more apps and want to activate them independently. By then, we may
have good patterns for working with Turbo.
Technically, the new buttons are a form within a form which is invalid
HTML, but it works.
2024-05-15 17:14:52 +10:00
Ahmed Ejaz
86f88792c2
11058: add sortable products by name
2024-05-08 12:56:41 +05:00
Ahmed Ejaz
da34e7b780
11060 - fix undefined method tax_category_options error in specs
2024-05-07 14:59:14 +02:00
Ahmed Ejaz
b577a81f48
11060 - add tax category field
2024-05-07 14:59:14 +02:00
David Cook
f17b0d176b
Enable Turbo Drive on products page
...
Forms now load without a full page rebuild.
This is not really faster, but a bit smoother because it avoids a full page render in the browser. The default Turbo loading indicator is shown (blue line at top).
But the bulk_update form breaks... hmm
On to the next level!
2024-04-17 15:17:59 +10:00
David Cook
72ce3a01a9
Ensure search terms and filters are retained when saving
2024-04-17 15:17:59 +10:00
David Cook
2adb69edb0
Merge pull request #12334 from dacook/buu/optimise
...
[BUU] Optimisation
2024-04-16 09:53:53 +10:00
David Cook
32b33de707
Optimise by pre-loading required columns
...
Oh boy, that's a big change.
2024-04-11 10:31:23 +10:00
Ahmed Ejaz
ec61cff387
12332 - Fix rubocop Rails/I18nLocaleTexts errors
...
- Add en locales for the hardcodded strings
2024-04-11 10:14:50 +10:00
David Cook
1425d524b9
Fix product filtering
...
Merges change from fb09a7f1e6
2024-04-10 15:17:56 +01:00
David Cook
54d0dfb141
Prevent duplicate products in search results
...
Dunno why, but the product was appearing once for each variant.
2024-04-10 15:17:56 +01:00
David Cook
fd8be37a62
Use shared page controls on products screen
...
This has an auto submit and can potentially work with Turbo, like on the Orders screen.
2024-04-10 15:17:56 +01:00
David Cook
0fc3d39106
Ensure pagination is retained when saving or discarding
...
But we have more work to do.
2024-04-10 15:17:56 +01:00
David Cook
8696e05e66
Move index and bulk_update actions to good ol' HTTP requests
...
We've found that we just can't rely in StimulusReflex (and the underlying WebSockets stack) to guarantee a response to a request.
Because of this, there was intermittent issues when the server was overloaded with large requests, and the response never arrived, leaving an infinite loader, and a poor user wondering if anything was still happening.
2024-04-10 15:17:56 +01:00
cyrillefr
84747ea064
Fix Rails::NegateInclude issues
...
- cop class: RuboCop::Cop::Rails::NegateInclude
- replaced !array.include?(2) by array.exclude?(2)
2024-04-04 14:42:42 +02:00
Maikel
4c1268b3ce
Merge pull request #12274 from mkllnk/dfc-product-import
...
Import products from DFC catalog
2024-03-22 09:25:02 +11:00
Anthony Musyoki
25e3f30f97
Fix Rubocop Rails issue: Rails/FindEach
2024-03-20 15:34:30 +03:00
Feruz Oripov
9d919938f3
Group Order && OrderCycle related services and specs
2024-03-16 19:07:08 +05:00
Maikel Linke
3af7fa7521
Offer nice select box for enterprise id
2024-03-15 16:46:41 +11:00
Maikel Linke
1c09b5d16c
Move DFC API request logic to service object
...
I'm planning to add more to it.
2024-03-15 16:46:41 +11:00
Maikel Linke
d6da52929f
Allow local DFC import in development
2024-03-15 16:46:41 +11:00
Maikel Linke
30e8f9eb28
Importing products from DFC catalog
...
Technical demonstration of a complete product export-import roundtrip
which we could now do between OFN instances.
2024-03-15 16:46:41 +11:00
Maikel Linke
96ccea3691
Add controller to handle import of DFC products
...
It's not doing anything yet, but this is the basic setup.
2024-03-15 11:40:10 +11:00
