Matt-Yorkley
0d620aac94
Move paypal_controller out of spree namespace
2021-12-10 11:46:52 +00:00
Matt-Yorkley
dcad00d047
Merge pull request #8484 from Matt-Yorkley/stripe-session-checks
...
Stripe checkout alerting
2021-12-05 12:04:00 +00:00
Matt-Yorkley
527a53bd0f
Merge pull request #8485 from Matt-Yorkley/stripe-addresses
...
Checkout address handling
2021-11-18 15:19:27 +00:00
Matt-Yorkley
ac5766b00b
Report current order info on all checkout failures
2021-11-14 20:01:32 +00:00
Matt-Yorkley
f8349434bf
Skip address setup logic if we're coming from Stripe
...
The code here runs from a callback which was originally designed to make sure the checkout page was set up correctly in the "normal" checkout workflow. It wasn't really designed to be run when the page is being loaded a second time due to the user being redirected back from Stripe (with SCA). The things it's doing here are necessary in the former case, but a really bad idea in the latter (potentially messing up the order's ship and bill addresses in certain cases like guest checkout).
2021-11-14 16:54:44 +00:00
Matt-Yorkley
f83d0a766f
Memoize Checkout#valid_payment_intent_provided?
2021-11-14 14:24:23 +00:00
Matt-Yorkley
bbb47964db
Notify Bugsnag if the order loaded at checkout is invalid after being redirected back from Stripe during payment processing.
2021-11-14 13:58:15 +00:00
Matt-Yorkley
1bf4e6fa56
Reorder conditions for performance
...
A little micro-optimisation: `@order.checkout_allowed?` requires a database query, whereas `@order.completed?` does not. So in cases where the order is completed we can return early here before hitting the database.
2021-11-14 13:58:15 +00:00
Matt-Yorkley
8d0cbe886a
Rename method for clarity
2021-11-14 13:58:15 +00:00
Matt-Yorkley
48acc0ecd0
Add Bugsnag notice when an OC closes during checkout completion
...
This info could be useful to know whilst debugging order completion issues.
2021-11-14 13:58:15 +00:00
Matt-Yorkley
d0f572b051
Remove dead code: session[:guest_token]
...
This `session[:guest_token]` doesn't seem to ever be assigned anywhere in the codebase, and it doesn't seem to be read at any point either..? There are some various places where `current_order.token` is used and `session[:access_token]` is used, but not this.
As far as I can tell: it was part of an old version of Spree and related to the spree_auth_devise gem (which we no longer use).
2021-11-14 12:02:07 +00:00
Matt-Yorkley
00862844d5
Memoize Checkout#valid_payment_intent_provided?
2021-11-14 11:39:36 +00:00
Matt-Yorkley
439a2318fb
Move API response under top-level :data node
2021-11-04 14:55:23 +00:00
Matt-Yorkley
924f6568d6
Replace data loading with new Reports::QueryInterface
2021-11-04 14:55:23 +00:00
Matt-Yorkley
817f0942dd
Pull in reports POC work replacing Packing reports
2021-11-04 14:55:23 +00:00
Maikel
43514f61ea
Merge pull request #8312 from mariodz95/8249_fix_snail_on_shipping_method_fees
...
Fix snail on shipping method fees
2021-10-29 12:04:25 +11:00
Maikel
1b79fdd333
Merge pull request #8409 from luisAzcuaga/task/rubocop
...
[6055] Task: Run rubocop over existing todo
2021-10-29 12:01:12 +11:00
Maikel
2e8f4c1538
Merge pull request #8367 from bellvat/bug-show-error
...
Add test and change order_cycle#show to redirect to edit page.
2021-10-28 16:36:47 +11:00
Luis Azcuaga
e8fd89a6d2
Run rubocop over existing todo
2021-10-25 21:28:28 -05:00
Monica Sirathanarun
ebaf96ddae
Add test and change order_cycle#show to redirect to edit page.
2021-10-19 23:20:54 +07:00
mariodz95
578efa945e
Fix snail when editing enterprise fees
2021-10-19 10:26:44 +02:00
mariodz95
d1160ec66a
Fix snail on shipping method fees
2021-10-19 09:56:35 +02:00
Maikel Linke
129c4c92fa
Catch JS error on OC page
...
Calling `when variant.id in enterprise_rules` raised an error when
enterprise_rules was null.
Fixing this then revealed a missing require statement in a controller.
2021-10-06 15:29:41 +11:00
Maikel
c9d36e6f5c
Merge pull request #8204 from meronokbay/6942-fix-payment-method-fee-bug-all
...
Fix payment method fee bug for all calculator types
2021-09-28 08:39:05 +10:00
Maikel
a3c31f7d86
Revert "Kill stripe connect"
2021-09-20 08:39:34 +10:00
Meron Ogbai
cd992ee866
Validate preferred values all calculators
2021-09-17 18:50:29 +03:00
Meron Ogbai
957f834694
Rename preferred amount to preferred value
2021-09-17 18:49:57 +03:00
Meron Ogbai
d73df78f43
Extract gateway_params to a private method
2021-09-17 16:48:53 +03:00
Matt-Yorkley
f4c86a1b51
Merge pull request #8061 from Matt-Yorkley/turbo-checkout
...
Split Checkout new toys
2021-09-17 10:48:59 +02:00
Luis Ramos
60a8ae6675
Remove Stripe Connect gateway and related code
2021-09-10 14:43:24 +05:30
Maikel
9affc6a945
Merge pull request #8108 from Matt-Yorkley/andand
...
Remove `andand` gem
2021-09-10 15:06:00 +10:00
Andy Brett
9124e03c11
Merge pull request #8144 from meronokbay/6942-fix-payment-method-fee-bug
...
6942 fix payment method fee bug
2021-09-09 09:28:40 -07:00
Matt-Yorkley
48d4341e2d
Merge pull request #8112 from cillian/eager-load-permissions-with-enterprise-relationships
...
Eager load the EnterpriseRelationship :permissions association on the enterprise permissions page
2021-09-08 19:46:14 +02:00
Matt-Yorkley
1d5077061e
Remove andand
...
This old gem implemented some functionality for handling nils which is no longer needed, as it's provided natively by Ruby with the &. operator.
2021-09-08 14:28:31 +01:00
Matt-Yorkley
8bf3f72ad3
Extract CableCar responses code to a concern
2021-09-08 10:34:34 +01:00
Matt-Yorkley
5ef34347a3
Implement optional non-Angular flash messages
2021-09-08 10:34:34 +01:00
Matt-Yorkley
e48b9d84e5
Extract boilerplate code
2021-09-08 10:34:34 +01:00
Matt-Yorkley
03abc395f2
Update responses to use cable_ready
2021-09-08 10:34:34 +01:00
Matt-Yorkley
9be73a8ff1
Respond with HTTP error code on update failure
2021-09-08 10:34:34 +01:00
Matt-Yorkley
3bcfc673f7
Ensure selected shipping method is actually selected
...
Hashes with symbol keys != hashes with string keys 🙈
2021-09-06 20:58:22 +01:00
Matt-Yorkley
fb7a3a681b
Validate attributes per checkout step and decouple order-advancing
2021-09-06 14:25:16 +01:00
Matt-Yorkley
71412f8d4b
Update validations
2021-09-06 14:22:28 +01:00
Matt-Yorkley
70513ae989
Don't transition to address before page load
2021-09-05 20:19:22 +01:00
Meron Ogbai
5ca552d380
Show flash error if preferred amount isn't valid
2021-09-05 01:11:12 +03:00
Matt-Yorkley
9d6e5e9420
Remove currently unused code
2021-09-01 15:04:53 +01:00
Matt-Yorkley
1fca7d2a6c
Remove error-clearing from edit action
2021-09-01 15:04:53 +01:00
Matt-Yorkley
4cff185b4b
Extract params handling to service
2021-09-01 15:04:53 +01:00
Matt-Yorkley
57504f42d8
Move validations to state transitions
2021-09-01 15:04:53 +01:00
Matt-Yorkley
9800483433
Simplify displaying selected shipping method
2021-09-01 15:04:33 +01:00
Matt-Yorkley
b7e1882bd8
Simplify setting address params
2021-09-01 15:04:33 +01:00
