raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-25 20:46:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reorder conditions for performance

Browse Source 
A little micro-optimisation: `@order.checkout_allowed?` requires a database query, whereas `@order.completed?` does not. So in cases where the order is completed we can return early here before hitting the database.
This commit is contained in:
Matt-Yorkley
2021-11-14 12:41:14 +00:00
parent 8d0cbe886a
commit 1bf4e6fa56
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/controllers/checkout_controller.rb
View File

@@ -89,9 +89,7 @@ class CheckoutController < ::BaseController
end
def order_invalid_for_checkout?
!@order ||
!@order.checkout_allowed? ||
@order.completed?
!@order || @order.completed? || !@order.checkout_allowed?
end
def valid_order_line_items?