Andy Brett
92aeab2ec3
Merge pull request #6490 from openfoodfoundation/dependabot/bundler/capybara-3.15.1
...
Bump capybara from 2.18.0 to 3.15.1
2020-12-12 13:16:04 -08:00
Andy Brett
94d10a45a7
Merge pull request #6486 from openfoodfoundation/dependabot/bundler/factory_bot_rails-5.2.0
...
Bump factory_bot_rails from 4.10.0 to 5.2.0
2020-12-12 08:58:53 -08:00
Luis Ramos
1ea775cffb
Keep factory bot v4 behaviour
...
In v5 the default value is true, that means that all parent objects (for example the order od a line item) will be built using the same strategy as the object (build or create), in v4 and now with this config, the parent is always created
We can revert this and use the default value but that will require some adaptions, quite a lot of specs are broken with that behaviour activated
2020-12-12 00:23:24 +00:00
Luis Ramos
367622cea8
Capybara v3 is not cleaning up the html into text so the permissions that are inside html li elements are not matched with the matcher have_table_row when there are multiple permissions. So, in this case, we need to do the work ourselves: looking up the correct row and then asserting the permissions are the ones required
2020-12-12 00:07:33 +00:00
Luis Ramos
ada25fa2b2
Improve stripe spec
...
I am not sure why this was passing without these stubbed requests for
the second order, but now they were correctly failing. This commit fixes
the spec.
2020-12-11 23:15:08 +00:00
Luis Ramos
480dfdf961
Handle redirect case
...
For some reason the process is now working correctly, the authorization step succeeds and a redirect link is stored in the payment with state pending. The payment state is correctly left at pending. Here we add a check for the redirect path sent by stripe and fail the authorization if there is one (it means the payment would need an extra auth step only available in the frontoffice now and probably through email to customer at some point in the future). For some reason the flash with the authorization failure message is not showing up for the user
2020-12-11 23:14:23 +00:00
Andy Brett
a745fceb53
Merge pull request #6469 from andrewpbrett/sca-backend
...
Allow SCA cards to be setup and charged offline for subscriptions
2020-12-11 14:23:12 -08:00
Pau Perez
182f0f66b6
Refactor FeatureToggle to toggle depending on user
...
This enables showing features to individual users only, which enables us
to deploy features that are not yet released to gather feedback from
product and testing, while no users have access to it.
2020-12-11 09:13:07 +01:00
Luis Ramos
62715a8060
Adapt matcher to capybara v3
2020-12-11 00:21:46 +00:00
Luis Ramos
26165cc08d
Adapt matcher to capybara v3
2020-12-11 00:20:58 +00:00
Luis Ramos
f19946af8d
Remove unnecessary test step that is breaking in capybara v3
2020-12-11 00:16:31 +00:00
Luis Ramos
c92e8de51f
Adapt matchers to capybara v3
2020-12-11 00:13:46 +00:00
Luis Ramos
ed4a7bd361
Adapt matchers to capybara v3
2020-12-11 00:09:34 +00:00
Luis Ramos
6d37a15488
Adapt matchers to capybara v3
2020-12-11 00:02:22 +00:00
Luis Ramos
79c538fad9
Fix syntax for nil property
2020-12-10 23:44:24 +00:00
Luis Ramos
b287d67f6b
Adapt matchers to capybara v3
2020-12-10 23:36:40 +00:00
Luis Ramos
5ae955c27f
Adapt matchers to capybara v3
2020-12-10 23:35:34 +00:00
Luis Ramos
fd5adab0d5
Adapt matchers to capybara v3
2020-12-10 23:27:56 +00:00
Luis Ramos
773f733c8e
Adapt matchers to capybara v3
2020-12-10 23:05:15 +00:00
Luis Ramos
80e59a920e
Adpat matcher to capybara v3
2020-12-10 23:01:01 +00:00
Luis Ramos
b58fddf098
Adapt matcher to capybara v3
2020-12-10 22:59:37 +00:00
Luis Ramos
bcf7cc1013
Replace ignore with transient according to changes in factory bot v5
2020-12-10 22:16:17 +00:00
Andy Brett
3b7313f7e3
add spec for deleting the default card
2020-12-10 12:31:58 -08:00
Andy Brett
3daccb6420
update specs with new method signature
2020-12-10 12:17:55 -08:00
Maikel Linke
3f6288d5c7
Load rake task under test for all its specs
...
If you ran only the second spec without the first, the rake file wasn't
loaded and the test failed.
2020-12-10 15:35:05 +11:00
Luis Ramos
9728b088f9
Fix syntax for nil properties
2020-12-09 23:38:16 +00:00
Luis Ramos
c17998774e
Adapt factories to factory_bot_rails v5 syntax
2020-12-09 23:09:33 +00:00
Andy Brett
7a03882314
re-refactor cart_service
2020-12-08 14:37:16 -08:00
Andy Brett
b713bd7aa7
spec updates
2020-12-08 14:37:16 -08:00
Andy Brett
eddf8da107
update subscription spec with new method name
2020-12-08 07:52:42 -08:00
Andy Brett
3d47ad7e33
add stubs for stripe requests
2020-12-08 07:52:42 -08:00
Andy Brett
cc00f24569
add spec for clearing authorizations to credit_card_controller_spec
2020-12-08 07:46:10 -08:00
Andy Brett
1f8b4e05bb
allow charges in subscriptions spec
2020-12-08 07:46:10 -08:00
Andy Brett
f875e406a8
update karma specs for setting default card
2020-12-08 07:46:10 -08:00
Andy Brett
e866e983f6
add spec for partially refunded SCA orders
2020-12-07 14:51:47 -08:00
Andy Brett
96462325d2
fix #5829
2020-12-04 18:13:43 -08:00
Matt-Yorkley
0ceba7c0a8
Update orders closing message
2020-12-03 15:29:14 -08:00
Luis Ramos
f71de8123a
Dont show 'closing in' message when oc closes in more than 3 months
2020-12-03 15:29:14 -08:00
Luis Ramos
5b00868c6f
Allow mutable strings in some specs
2020-12-03 06:38:24 -08:00
Luis Ramos
bfd4adbcee
Adapt code to work with frozen strings
2020-12-03 06:38:24 -08:00
Luis Ramos
611de912a8
Switch frozen_string_literal to false so that price code keeps working
2020-12-03 06:38:24 -08:00
Luis Ramos
2b8f0abe49
Try some mass auto-correct adding frozen-string-literal to all specs
2020-12-03 06:38:24 -08:00
Luis Ramos
7a5a4f956a
Replace use of Faker with FFaker
2020-12-02 11:40:50 -08:00
Andy Brett
936f5c1a0c
remove extraneous page call
2020-12-02 11:38:10 -08:00
Tsara Sudrajat
fb769d37f9
Fix error when setting stock for new product
2020-12-02 11:38:10 -08:00
Andy Brett
c4cd574242
fix currency spec
2020-12-02 11:37:25 -08:00
Matt-Yorkley
7408c45980
Merge pull request #6297 from openfoodfoundation/rails-4-1
...
[Rails 4.1] Merge Rails 4.1 branch into master
2020-12-01 10:56:08 +01:00
Matt-Yorkley
2b2f1ac0cd
Improve specificity of expectation in reset password email test
2020-11-27 14:00:29 +00:00
Matt-Yorkley
60aaf8100a
Fix some Rubocop offences
2020-11-27 14:00:29 +00:00
Matt-Yorkley
2b884be8dd
Update specs to work with ActionMailer::DeliveryJob
2020-11-27 14:00:29 +00:00
