Matt-Yorkley
5593da2928
Delete dead code #update_hooks
...
These hooks allow Spree core to be modified by other gems and apps without changing Spree code. We don't use it. #YAGNI
2021-01-15 16:49:45 +00:00
Maikel
fbda1fffd7
Merge pull request #6653 from Matt-Yorkley/dead-code-available-payment
...
Dead code: #has_available_payment
2021-01-14 17:33:07 +11:00
Matt-Yorkley
8d338a06f3
Delete dead code #has_available_payment
...
This is removed in Spree 2.2, as it serves no purpose.
See: 0617bdce30
2021-01-13 15:48:02 +00:00
Pau Perez
04930877dd
Test that payment_total is stored after payment
...
CustomerWithBalance totally relies on `spree_orders.payment_total` so we
better cover it with tests.
2021-01-11 15:50:19 +01:00
Matt-Yorkley
ff962c1c9b
Change various Mailer invocations from #deliver_now to #deliver_later
2021-01-08 23:18:55 +00:00
Matt-Yorkley
3e6445c51c
Replace deprecated ActionMailer#deliver with ActionMailer#deliver_now
...
DEPRECATION WARNING: `#deliver` is deprecated and will be removed in Rails 5. Use `#deliver_now` to deliver immediately or `#deliver_later` to deliver through Active Job.
2021-01-08 20:35:47 +00:00
Luis Ramos
5b00868c6f
Allow mutable strings in some specs
2020-12-03 06:38:24 -08:00
Luis Ramos
2b8f0abe49
Try some mass auto-correct adding frozen-string-literal to all specs
2020-12-03 06:38:24 -08:00
Matt-Yorkley
91908a0e4c
Switch from state_machine to state_machines gem
...
The old version is completely unmaintained and does not work with Rails 4.2
2020-11-27 14:00:28 +00:00
Andy Brett
17202ff39c
move gateway_error require to lib/spree/core.rb
2020-11-10 14:55:56 -08:00
Luis Ramos
c2c12b34f9
Fix more rubocop issues with auto correct
2020-10-30 17:10:23 +00:00
Luis Ramos
b267f542d1
Merge pull request #5980 from luisramos0/spree_clean_up
...
[Bye bye spree] Some clean up fixes to make it all work without spree
2020-10-20 18:52:54 +01:00
Luis Ramos
d54ddacc05
Merge pull request #5887 from luisramos0/orders
...
[Bye bye Spree] Bring models order, line_item and other related from spree_core
2020-10-15 08:49:05 +01:00
Pau Pérez Fabregat
427d1aaeff
Merge pull request #6079 from arku/perf/test-prof-setup
...
Set up test_prof gem
2020-10-06 10:30:43 +02:00
Arun Kumar Mohan
4858f5fb80
Improve order specs' performance
2020-10-01 01:43:08 -05:00
Matt-Yorkley
70bd2161ba
Rename Stripe Connect factory for clarity
2020-09-19 12:55:31 +01:00
Luis Ramos
a5ff4d6853
Remove unneeded setup code and remove unnecessary reference to FactoryGirl
2020-09-17 14:06:51 +01:00
Luis Ramos
c49dbec85a
Adapt order_spec to new updater code
2020-09-17 14:06:51 +01:00
Luis Ramos
4215dcb927
Run transpec on the new specs from spree_core
2020-09-17 14:06:50 +01:00
Luis Ramos
31f9cd3caf
Fix spec/models/spree/order specs
2020-09-17 14:06:50 +01:00
Luis Ramos
8643cbd8ce
Delete unused order.merge! and fix specs
2020-09-17 14:06:50 +01:00
Luis Ramos
2753e86325
Run rubocop autocorrect
2020-09-17 14:06:50 +01:00
Luis Ramos
cc87e8c9a2
Remove code related to promotions
2020-09-17 14:06:50 +01:00
Luis Ramos
47d2f698ef
Bring models related to Order from spree_core
...
EPIC COMMIT ALERT :-)
2020-09-17 14:05:29 +01:00
Luis Ramos
b84212023b
Require code from spree/core explicitly
2020-09-17 13:58:10 +01:00
Luis Ramos
d673f278ce
Add unit test to order.charge_shipping_and_payment_fees!
2020-07-27 21:27:23 +01:00
Luis Ramos
5e8438c446
Move all calculators outside the spree namespace
2020-07-07 17:26:23 +01:00
Luis Ramos
f848a89a00
Rename update_attributes to update #rails4
2020-06-22 16:51:43 +01:00
François Turbelin
9abe41f6cb
Use OrderTaxAdjustmentsFetcher service
2020-06-16 14:01:27 +02:00
Luis Ramos
be4104d6f3
Merge branch 'master' into 3-0-stable-may-5
2020-05-05 19:11:20 +01:00
Matt-Yorkley
e33de8a20e
Update specs and refactor a bit
2020-04-27 19:27:07 +02:00
Luis Ramos
ff799b6e82
Avoid using update_attributes that save the order to the DB
2020-04-07 11:13:29 +01:00
Luis Ramos
4ceaebf098
Add order.email regexp validation and add some tests for it
2020-04-04 16:13:23 +01:00
luisramos0
e4a6b3880f
Fix some more simple rubocop issues
2019-07-31 09:36:48 +01:00
Kristina Lim
2c279fd02d
Remove line item adjustments if line item deleted
2019-07-13 03:58:01 +10:00
Kristina Lim
8a048cc155
Add proof line item adjustments remain after line item removal
2019-07-13 01:43:07 +08:00
Maikel Linke
5bbd63bcd8
Add spec for rescuing order saving shipment
2019-06-26 11:32:01 +10:00
luisramos0
86b0d71c7e
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
2019-05-28 12:57:29 +01:00
luisramos0
04801e5c2e
Run transpec in spec/models
2019-05-09 22:25:29 +01:00
Maikel
99a4878bdf
Merge pull request #3653 from mkllnk/2520-spree2-order-subscription
...
2520 Remove `process_payments!` override
2019-04-19 07:34:30 +10:00
Maikel Linke
278190a25c
Update specs for Spree v2 payment requirement
...
This pull request removed the override of `process_payments!` which was based on v1. Spree v2 has an additional check: An order in payment state requires a payment. Some specs didn't care and didn't create payments before transitioning to `complete`.
2019-04-16 10:30:14 +10:00
Maikel Linke
6f12eee8ae
Reduce the override of Order for subscriptions
...
Orders belonging to subscriptions get completed without payment. That
requires overriding Spree's functionality.
In Spree 2, an order in payment state without pending orders is invalid.
Instead we skip the payment state by not requiring a payment for
automatically generated orders until the order cycle is closed.
2019-04-16 10:30:14 +10:00
luisramos0
87327f7aa9
Fix specs testing order cancelation email. The email template now needs a order distributor for the signoff part
2019-04-04 13:41:07 +01:00
luisramos0
c1d14686a6
Merge branch 'master' into 2-0-stable-Mar22
2019-03-22 10:55:17 +00:00
luisramos0
60ee17204b
Merge branch 'master' into 2-0-stable-Mar16
2019-03-16 16:17:38 +00:00
luisramos0
3117dbf624
Remove product distributions from order model
2019-03-13 11:50:35 +00:00
luisramos0
5ab4ae88f5
Remove distribution change in order_spec, order distributor cannot be changed, if distributor or oc is changed, the order is emptied
2019-03-02 13:08:39 +00:00
luisramos0
36e2786a1e
Delete Accounts and Billing dead feature code
2019-02-25 14:37:16 +00:00
luisramos0
5d51ad71b0
Merge branch 'master' into 2-0-stable-Feb20
2019-02-20 14:32:36 +00:00
Pau Perez
caf4441fa3
Do not mutate config's state in specs
2019-02-14 17:01:43 +01:00