Maikel Linke
dcb6f4676d
Remove all unnecessary spec_helper require statements
...
The `.rspec` file is doing this for us.
2026-01-21 12:35:34 +11:00
cyrillefr
a7eb95afc5
Fixes RSpecRailsInferredSpecType in base controllers
2025-05-20 12:45:34 +02:00
Maikel Linke
6317fe1b71
Disable RSpec monkey patching
2024-05-09 12:24:41 +10:00
Maikel Linke
bd6b0ddbf3
Enforce RSpec expect(..).not_to over to_not
2024-03-07 16:57:54 +11:00
Neal Chambers
42a6a02353
Fix Style/HashSyntax
2023-09-19 08:25:56 +09:00
Matt-Yorkley
5e6dd1e6e1
Move #check_order_cycle_expiry method to OrderStockCheck and don't call it from BaseController :before_action callback
2022-01-31 15:55:35 +00:00
Matt-Yorkley
48acc0ecd0
Add Bugsnag notice when an OC closes during checkout completion
...
This info could be useful to know whilst debugging order completion issues.
2021-11-14 13:58:15 +00:00
Nihal Mohammed
0b12b398ba
Update spec test for the changed redirect path
2021-05-14 03:32:14 +05:30
Luis Ramos
53d758ca21
Replace render text with render plain for rails 5.1
2021-03-16 23:13:58 +00:00
Luis Ramos
7cea4138c2
Fix spec setup
2021-01-27 22:44:52 +00:00
Luis Ramos
c604f4c0c6
Remove dead endpoint
2021-01-27 22:05:04 +00:00
Luis Ramos
2b8f0abe49
Try some mass auto-correct adding frozen-string-literal to all specs
2020-12-03 06:38:24 -08:00
Maikel Linke
4b1f5ae060
Avoid loading variant overrides for no reason
2020-11-05 14:31:19 +11:00
Luis Ramos
72f5b1b251
Revert "Remove unreachable order recovery code"
...
This reverts commit 355c5f5c55
2020-08-19 17:36:36 +01:00
Maikel Linke
355c5f5c55
Remove unreachable order recovery code
...
Every page load creates a cart order if none is present. So when a user
logs in, they always have an order stored in their session. And
therefore, we never got to recover an old order.
We could have fixed the code to restore old orders. But as far as I can
tell, order recovery hasn't been working for years and I couldn't find
any issue requesting this feature.
If we wanted to implement order recovery, it should probably be designed
more carefully and included in the `current_order` method.
2020-08-19 12:06:58 +10:00
Maikel Linke
e8139d3948
Keep old incomplete (cart) orders
...
We used to delete old cart orders so that they wouldn't re-appear after
a successful checkout of another order. Keeping them ensures that we
don't remove an order that is still used by another device. It also
makes sure that we keep references of failed payments.
2020-08-14 10:02:48 +10:00
Maikel Linke
5761014205
Restore Spree customisations for controllers
2020-08-13 16:59:15 +10:00
Maikel Linke
90bf4f312b
Document and spec current controller behaviour
...
When we imported and merged Spree's controller modules with our
decorators, Rails started using Spree's original code again.
This was first included in v3.2.0 and deployed on 28 July 2020.
2020-08-13 16:59:15 +10:00
Lucas Hiago
e9e43c985f
add missing i18n key for closed OC
2020-06-16 19:48:24 -03:00
luisramos0
86b0d71c7e
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
2019-05-28 12:57:29 +01:00
Julius Pabrinkis
5dd7ddc288
Refactor base controller with new rspec syntax
2017-11-10 08:47:12 +11:00
Rob Harrington
ef9e43fbd3
Replacing mock_model objects with instance_doubles
2017-11-10 08:47:12 +11:00
Rob Harrington
3b7700131c
Specify controller specs as such
2016-01-15 09:07:47 +11:00
Rohan Mitchell
704955a185
Load active distributors where they're needed rather than in most controllers
2015-05-27 15:44:01 +10:00
Rohan Mitchell
43bac4079f
Show hubs that are not ready for checkout so that we can view SEFH - Sample :/
2014-11-13 15:21:02 +11:00
Rohan Mitchell
fdbb274667
Allow browsing products (but not cart/checkout) for hubs that are not ready for checkout
2014-11-05 14:29:36 +11:00
Rohan Mitchell
15b05de7f2
Fix specs: Distributors require shipping and payment method
2014-11-01 10:42:38 +11:00
Rohan Mitchell
8488b8e469
When user has selected a hub that is not ready for checkout, unselect it
2014-10-31 15:02:58 +11:00
Will Marshall
b9561ecf20
Minor refactoring from code review with Rohan
2014-06-19 11:41:24 +10:00
Will Marshall
224a70c11f
Refactoring JSON injection a bit further
2014-06-18 16:43:57 +10:00
Will Marshall
dbf4f503a9
Restoring my clever flash refactoring
2014-06-10 11:14:52 +10:00
Rohan Mitchell
be644bdcc3
Revert "Reworking flash messages hooray"
...
This reverts commit c9d0091cd9
2014-06-06 16:59:47 +10:00
Will Marshall
c9d0091cd9
Reworking flash messages hooray
2014-06-06 16:41:28 +10:00
Will Marshall
151702d685
Catching order cycle expiry and redirecting
2014-05-14 11:51:25 +10:00
