David Rodríguez
4c6d894bc0
Bump RuboCop to 1.86.6
...
There were a few changes needed:
* Plugins are now specified through `plugin:` config keyword.
* All plugin gems need to be specified explicitly in Gemfile since they
are no longer dependencies of plugins already specified explicitly.
* All plugin gems need to be updated in other to use the new APIs.
* One cop was renamed.
* New offenses safe to correct were corrected directly with `bundle exec
rubocop -a`.
* New offenses unsafe to correct were added to the TODO configuration
with `bundle exec rubocop --auto-gen-config --auto-gen-only-exclude
--exclude-limit 1400 --no-auto-gen-timestamp`.
2025-10-27 11:30:33 +01:00
Ashish Gaur
5fc3fe03ee
13221 Add spec for checking flash error is shown when editing a shipped order
2025-05-05 20:37:59 +05:30
Ashish Gaur
8d96411741
13221 Fix rubocop issues
2025-05-05 20:03:47 +05:30
Ashish Gaur
c533111509
13221 Don't allow shipped orders to process update request
2025-05-05 20:03:47 +05:30
piyush828-design
3202d0ea81
fixed test failure
2025-04-16 18:24:32 +05:30
Gaetan Craig-Riou
0ae855047d
Fix User controlled method execution
...
Add white list for the fire endpoint to limit which action can be taken.
Add specs for fire endpoint
2025-02-18 14:42:26 +11:00
Maikel Linke
88837b55b9
Amend backorder also when resuming order
2024-12-11 12:40:46 +11:00
Maikel Linke
9ca1b48d2e
Move backorder amendment out of order callback
...
Triggering it for each order is inefficient when we cancel them in bulk.
The callback doesn't allow us to optimise this.
2024-12-11 12:40:46 +11:00
Feruz Oripov
9d919938f3
Group Order && OrderCycle related services and specs
2024-03-16 19:07:08 +05:00
Mohamed ABDELLANI
f047deaf12
load the latest invoice when user tries to print an order
2023-10-08 21:47:17 +02:00
Mohamed ABDELLANI
3f4eab2a0a
update the invoice renderer to check if the feature is enable for individual user
2023-10-08 21:47:17 +02:00
Mohamed ABDELLANI
614c8a5060
update order mailer to check if invoices feature is enabled for the current user
2023-10-08 21:47:17 +02:00
Mohamed ABDELLANI
bd2a1b3e22
check if invoices feature is enabled for the current user before printing a single invoice
2023-10-08 21:47:17 +02:00
Matt-Yorkley
d3a31bd0bd
Rename @invoice_presenter instance variable to @order in invoice templates
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
d86173c509
add feature toggle
...
seperate the invoice templates that rely on presenters from the old ones.
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
0fbf88190e
Generate invoice model
...
There are three main components:
1. The invoice model
2. order serializers: serialize the order for the invoice
3. data presenters: the object that will be use to access the order's serialize data
2023-06-18 21:03:13 +02:00
Matt-Yorkley
983353e078
Remove dead code
...
I'm pretty sure this was here because advancing the order was adding order errors in some cases
2023-06-07 13:01:37 +01:00
Matt-Yorkley
f3ee10dd5a
Simplify by moving conditional to guard clause
2023-06-07 13:01:37 +01:00
Matt-Yorkley
c7bb24e2a0
Remove dead code and clarify update logic
2023-06-07 00:58:43 +01:00
Matt-Yorkley
67c3e09dba
Use RESTful routes for orders controller actions
2023-06-07 00:35:47 +01:00
Mohamed ABDELLANI
77554e21fc
move advance_to_payment on order's details page from edit to update
2023-06-06 10:23:01 +01:00
Matt-Yorkley
e34c2acba8
Move CablecarResponses include to ApplicationController
2023-05-26 10:35:41 +01:00
Matt-Yorkley
abf00353ea
Permit explicit params
2023-05-21 00:15:32 +01:00
Matt-Yorkley
4ddde65a04
Reimplement saving and restoring submitted search filters between page loads
2023-05-21 00:15:32 +01:00
Matt-Yorkley
048df6230b
Remove angular from admin orders index page
2023-05-21 00:15:32 +01:00
Jean-Baptiste Bellet
0f54d3950d
Save can have a context: simplify then
2023-04-19 10:15:35 +02:00
Jean-Baptiste Bellet
7e306693a8
Use Rails standard naming: same name for the route and the method
2023-04-19 10:15:35 +02:00
Jean-Baptiste Bellet
ac666a6fce
Validate presence of distributor and order_cycle in set_distribution step
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
ba1d985932
update the set_distribution form on the same path
...
and use the same method `OrdersController#set_distribution`
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
0f28d318ac
Fix rubocop error and prefer using a return clause
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
6172d1f2e5
Extract method on_update that will be used elsewhere
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
05a040b4c3
No need to ensure if the distribution is set on new action
...
This will be handled by validation on set_distribution action
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
73a81310f8
Create a new url /orders/ORDER_ID/distribution
...
That handles the step when distributor and order_cycle must be selected
2023-04-18 14:21:23 +02:00
Konrad
f7f49377b4
Merge pull request #10297 from cyrillefr/convert-admin-order-cancellation-workflow-to-stimulus-reflex
...
Convert admin order cancellation workflow to stimulus reflex
2023-02-20 21:38:33 +01:00
Ana Nunes da Silva
8dc50caaa8
Remove print ticket action
2023-02-14 08:08:20 +00:00
cyrillefr
1682f6788d
Delete unused code
...
Delete now unused code for Angular style bulk orders cancelling
- the Angular controller file
- the bulk_cancel method from controller
- the corresponding entry in route
2023-02-07 15:40:40 +01:00
binarygit
25ae10dbe8
Create bulk orders cancellation feature
2022-10-04 16:57:31 +02:00
Jean-Baptiste Bellet
e3683d25ca
Change second step order: Customer Details instead of Order Details
...
This second step comes from a first one, which is Set Distribution
2022-07-28 09:31:42 +02:00
Jean-Baptiste Bellet
e4be757d96
use the can_invoice method that check both ABN and configuration boolean
...
+ specs Specify an empty ABN number
+ update specs
2022-07-04 15:35:49 +02:00
GeorgeThoppil
8903496a1b
Optional restocking items
2022-05-06 10:55:24 -04:00
Jean-Baptiste Bellet
6a48bdbb82
Send email cancelation by default
2022-03-29 10:12:00 +02:00
Jean-Baptiste Bellet
50f547af98
Add an attribute that conditions the sending of the cancellation email
...
true by default to not change the default behavior.
Can be set to false when sending params send_cancellation_email
2022-02-10 14:39:00 +01:00
Matt-Yorkley
a6af9b3ad5
Disable CSP on order ticket printing via QZ
2022-01-18 12:22:06 +00:00
Andy Brett
aa8067f96b
process payments separately from completing the order
2021-06-29 11:54:48 -07:00
Luis Ramos
e52937c113
Use rubocop auto correct to add frozen string literal to all files
...
This is an unsafe auto corection, we will need to trust our build here
2021-06-17 23:07:26 +01:00
Matt-Yorkley
0f5c39317a
Re-apply taxes in Admin::OrdersController#update
...
Ensures taxes are updated properly when hitting the "Update and Recalculate Fees" button on the order edit page.
2021-06-06 20:16:03 +01:00
Matt-Yorkley
834140f0a2
Don't dump massive binary PDF data into the job queue
...
Here we were rendering an entire PDF, then passing that PDF into the job queue as an *argument* containing the entire binary of the PDF in a massive string. This means the job object itself would contain that entire PDF. That's bad queueing!
We now create the PDF *during* the job (not before it), and pass simple arguments.
2021-05-29 16:06:29 +01:00
Matt-Yorkley
aa013ef76a
Update redirect_back syntax for Rails 5
...
Introduced in 5.0, the old syntax is removed in 5.2
2021-05-03 14:17:54 +01:00
Matt-Yorkley
123e96eb1e
Merge pull request #7284 from jibees/styleguide
...
Implements our StyleGuide
2021-04-22 18:14:40 +02:00
Jean-Baptiste Bellet
9a670c7821
Print order needs render_with_wicked_pdf
...
and call WickedPdf::PdfHelper explicitly
2021-04-22 15:18:27 +02:00