raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-04-03 06:59:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve line item code by merging multiple destroy hooks into a single hook: update_inventory_on_destroy. This makes the code easier to read

Browse Source
This commit is contained in:
luisramos0
2018-12-23 09:22:45 +00:00
parent 429e513a77
commit d44c4778e1
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
app/models/spree/line_item_decorator.rb
View File

@@ -18,8 +18,7 @@ Spree::LineItem.class_eval do
before_save :calculate_final_weight_volume, if: :quantity_changed?, unless: :final_weight_volume_changed?
after_save :update_units
before_destroy :make_quantity_zero, :update_inventory
after_destroy :reload_order_shipments, :update_order
before_destroy :update_inventory_before_destroy
delegate :unit_description, to: :variant
@@ -137,16 +136,16 @@ Spree::LineItem.class_eval do
end
alias_method_chain :update_inventory, :scoping
# This is necessary before destroying the line item
# so that update_inventory will restore stock to the variant
def make_quantity_zero
def update_inventory_before_destroy
# This is necessary before destroying the line item
# so that update_inventory will restore stock to the variant
self.quantity = 0
end
# TThis is necessary after destroying the line item
# because update_inventory may delete the last shipment in the order
# and that makes update_order fail if we don't reload the shipments
def reload_order_shipments
update_inventory
# This is necessary after updating inventory
# because update_inventory may delete the last shipment in the order
# and that makes update_order fail if we don't reload the shipments
order.shipments.reload
end