raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-10 23:07:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused email logic in login_modal controller and clean up UI

Browse Source
This commit is contained in:
wandji20
2024-10-30 22:33:49 +01:00
parent 1b70ff904f
commit ca82f62ea2
4 changed files with 4 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/views/layouts/_forgot_tab.html.haml
View File

@@ -6,7 +6,7 @@
.row
.large-12.columns
= form.label :email, t(:signup_email)
= form.email_field :email, { tabindex: 1, inputmode: "email", "data-login-modal-target": "email", "data-action": "input->login-modal#emailOnInput" }
= form.email_field :email, { tabindex: 1, inputmode: "email" }
.row
.large-12.columns
= form.submit t(:reset_password), { class: "button primary", tabindex: 2 }

2
app/views/layouts/_login_tab.html.haml
View File

@@ -10,7 +10,7 @@
.row
.large-12.columns
= form.label :email, t(:email)
= form.email_field :email, { tabindex: 1, inputmode: "email", autocomplete: "off", "data-login-modal-target": "email", "data-action": "input->login-modal#emailOnInput" }
= form.email_field :email, { tabindex: 1, inputmode: "email", autocomplete: "off" }
.row
.large-12.columns
= form.label :password, t(:password)

2
app/views/layouts/_signup_tab.html.haml
View File

@@ -8,7 +8,7 @@
.row
.large-12.columns
= form.label :email, t(:signup_email)
= form.email_field :email, { tabindex: 1, "data-login-modal-target": "email", "data-action": "input->login-modal#emailOnInput" }
= form.email_field :email, { tabindex: 1 }
= form.error_message_on :email
.row
.large-12.columns

10
app/webpacker/controllers/login_modal_controller.js
View File

@@ -1,8 +1,7 @@
import { Controller } from "stimulus";
export default class extends Controller {
static targets = ["background", "modal", "email"];
static values = { email: String };
static targets = ["background", "modal"];
connect() {
if (this.hasModalTarget) {
@@ -19,13 +18,6 @@ export default class extends Controller {
window.dispatchEvent(new Event("login:modal:open"));
}
emailOnInput(event) {
this.emailValue = event.currentTarget.value;
this.emailTargets.forEach((element) => {
element.value = this.emailValue;
});
}
open = () => {
if (!location.hash.substr(1).includes("/login")) {
history.pushState({}, "", "#/login");