mirror of
https://github.com/openfoodfoundation/openfoodnetwork
synced 2026-01-24 20:36:49 +00:00
Move set_current_order override to new location in lib (Spree 1.3 Upgrade), and update home controller test
This commit is contained in:
@@ -1,25 +0,0 @@
|
||||
module Spree
|
||||
BaseController.class_eval do
|
||||
|
||||
# Override definition in spree/auth/app/controllers/spree/base_controller_decorator.rb
|
||||
# Do not attempt to merge incomplete and current orders when they have differing distributors
|
||||
# Instead, destroy the incomplete orders, otherwise they are restored after checkout, causing much confusion
|
||||
def set_current_order
|
||||
if current_user
|
||||
if current_user.respond_to?(:last_incomplete_order)
|
||||
last_incomplete_order = current_user.last_incomplete_order
|
||||
if session[:order_id].nil? && last_incomplete_order
|
||||
session[:order_id] = last_incomplete_order.id
|
||||
elsif current_order && last_incomplete_order && current_order != last_incomplete_order
|
||||
if current_order.distributor.nil? || current_order.distributor == last_incomplete_order.distributor
|
||||
current_order.set_distributor! last_incomplete_order.distributor if current_order.distributor.nil?
|
||||
current_order.merge!(last_incomplete_order)
|
||||
else
|
||||
last_incomplete_order.destroy
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
20
lib/spree/core/controller_helpers/order_decorator.rb
Normal file
20
lib/spree/core/controller_helpers/order_decorator.rb
Normal file
@@ -0,0 +1,20 @@
|
||||
Spree::Core::ControllerHelpers::Order.class_eval do
|
||||
# Override definition in spree/auth/app/controllers/spree/base_controller_decorator.rb
|
||||
# Do not attempt to merge incomplete and current orders when they have differing distributors
|
||||
# Instead, destroy the incomplete orders, otherwise they are restored after checkout, causing much confusion
|
||||
def set_current_order
|
||||
if user = try_spree_current_user
|
||||
last_incomplete_order = user.last_incomplete_spree_order
|
||||
if session[:order_id].nil? && last_incomplete_order
|
||||
session[:order_id] = last_incomplete_order.id
|
||||
elsif current_order && last_incomplete_order && current_order != last_incomplete_order
|
||||
if current_order.distributor.nil? || current_order.distributor == last_incomplete_order.distributor
|
||||
current_order.set_distributor! last_incomplete_order.distributor if current_order.distributor.nil?
|
||||
current_order.merge!(last_incomplete_order)
|
||||
else
|
||||
last_incomplete_order.destroy
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
@@ -31,8 +31,8 @@ describe Spree::HomeController do
|
||||
incomplete_order = double(:order, distributor: 1)
|
||||
current_order = double(:order, distributor: 2)
|
||||
|
||||
user = double(:user, last_incomplete_order: incomplete_order)
|
||||
controller.stub(:current_user).and_return(user)
|
||||
user = double(:user, last_incomplete_spree_order: incomplete_order)
|
||||
controller.stub(:try_spree_current_user).and_return(user)
|
||||
controller.stub(:current_order).and_return(current_order)
|
||||
|
||||
incomplete_order.should_receive(:destroy)
|
||||
@@ -48,8 +48,8 @@ describe Spree::HomeController do
|
||||
incomplete_order = double(:order, distributor: 1)
|
||||
current_order = double(:order, distributor: nil)
|
||||
|
||||
user = double(:user, last_incomplete_order: incomplete_order)
|
||||
controller.stub(:current_user).and_return(user)
|
||||
user = double(:user, last_incomplete_spree_order: incomplete_order)
|
||||
controller.stub(:try_spree_current_user).and_return(user)
|
||||
controller.stub(:current_order).and_return(current_order)
|
||||
|
||||
current_order.should_receive(:set_distributor!).with(1)
|
||||
|
||||
Reference in New Issue
Block a user