Fix deprecated #includes in join without reference

DEPRECATION WARNING: It looks like you are eager loading table(s) (one of: variant_overrides, enterprises, enterprise_roles) that are referenced in a string SQL snippet. For example:

    Post.includes(:comments).where("comments.title = 'foo'")

Currently, Active Record recognizes the table in the string, and knows to JOIN the comments table to the query, rather than loading comments in a separate query. However, doing this without writing a full-blown SQL parser is inherently flawed. Since we don't want to write an SQL parser, we are removing this functionality. From now on, you must explicitly tell Active Record when you are referencing a table from a string:

    Post.includes(:comments).where("comments.title = 'foo'").references(:comments)

If you don't rely on implicit join references you can disable the feature entirely by setting `config.active_record.disable_implicit_join_references = true`. (called from collection at /home/user/Github/openfoodnetwork/app/controllers/admin/variant_overrides_controller.rb:77)
This commit is contained in:
Matt-Yorkley
2019-12-23 13:57:33 +01:00
committed by Luis Ramos
parent 6c22d655c8
commit c0ecdb9e3a

View File

@@ -73,7 +73,10 @@ module Admin
end
def collection
@variant_overrides = VariantOverride.includes(:variant).for_hubs(params[:hub_id] || @hubs)
@variant_overrides = VariantOverride.
includes(:variant).
for_hubs(params[:hub_id] || @hubs).
references(:variant)
@variant_overrides.select { |vo| vo.variant.present? }
end