Show order and admin page despite broken image

Avoiding:

    ActiveStorage::InvariableError

Affects the admin order page and the customer's order confirmation page.
This commit is contained in:
Maikel Linke
2022-06-10 15:32:58 +10:00
parent 87c275a1f7
commit bec2a873de
2 changed files with 1 additions and 8 deletions

View File

@@ -1,6 +1 @@
- if variant.product.images.length == 0
= image_tag("/noimage/mini.png")
- else
- # A Rails bug makes it necessary to call `main_app.url_for` here.
- # https://github.com/rails/rails/issues/31325
= image_tag(main_app.url_for(variant.product.images.first.variant(:mini)))
= image_tag(variant.product.images.first&.url(:mini) || "/noimage/mini.png")

View File

@@ -43,8 +43,6 @@ describe "spree/orders/show.html.haml" do
end
it "handles broken images" do
pending "https://github.com/openfoodfoundation/openfoodnetwork/issues/9279"
image, = order.line_items.first.variant.product.images << Spree::Image.new(
attachment: fixture_file_upload("logo.png", "image/png")
)