Fix 'Ship Order': requested changes

- deletes local variables in view
- factor logic in helper

app/helpers/spree/admin/orders_helper.rb

@@ -34,6 +34,10 @@ module Spree
         links
       end
 
+      def order_shipment_ready?(order)
+        order.ready_to_ship?
+      end
+
       private
 
       def complete_order_links(order)

app/views/spree/admin/shared/_order_links.html.haml

@@ -6,10 +6,8 @@
           %i.icon-check
           = I18n.t 'admin.actions'
       %div.menu{"data-action": "click->dropdown#closeOnMenu"}
-        - shipment_ready = false
         - order_links(@order).each do |link|
           - if link[:name] == t(:ship_order)
-            - shipment_ready = true 
             %a.menu_item{ href: link[:url], target: link[:target] || "_self", data: { "modal-link-target-value": dom_id(@order, :ship), "action":  "click->modal-link#open", "controller": "modal-link" } }
               %span
                 %i{ class: link[:icon] }
@@ -21,6 +19,6 @@
               %span=link[:name]
 
 = render 'spree/admin/shared/custom-confirm'
-- if shipment_ready
+- if order_shipment_ready?(@order)
   %form
     = render ShipOrderComponent.new(order: @order)