Simplify reports controller code branching

This commit is contained in:
Maikel Linke
2024-08-09 16:12:04 +10:00
parent c31416c536
commit aed78f3138
2 changed files with 3 additions and 6 deletions

View File

@@ -21,14 +21,15 @@ module Admin
def show
@report = report_class.new(spree_current_user, params, render: false)
@rendering_options = rendering_options # also stores user preferences
@rendering_options = rendering_options
show_report
end
def create
@report = report_class.new(spree_current_user, params, render: true)
@rendering_options = rendering_options # also stores user preferences
@rendering_options = rendering_options
update_rendering_options
render_in_background
end

View File

@@ -88,13 +88,9 @@ module ReportsActions
display_header_row: false
}
end
update_rendering_options
@rendering_options
end
def update_rendering_options
return unless request.post?
@rendering_options.update(
options: {
fields_to_show: params[:fields_to_show],