Rename methods to follwo ruby convention and improve readability

This commit is contained in:
Luis Ramos
2020-09-22 18:39:54 +01:00
parent f3ba0ebdbb
commit ad592785cf
2 changed files with 4 additions and 4 deletions

View File

@@ -1,11 +1,11 @@
# frozen_string_literal: true
module TermsAndConditionsHelper
def terms_and_conditions_activated
def terms_and_conditions_activated?
current_order.distributor.terms_and_conditions.file?
end
def terms_and_conditions_already_accepted
def terms_and_conditions_already_accepted?
customer_terms_and_conditions_accepted_at = spree_current_user.
customer_of(current_order.distributor)&.terms_and_conditions_accepted_at

View File

@@ -1,4 +1,4 @@
- if terms_and_conditions_activated
- if terms_and_conditions_activated?
%p
%input{ type: 'checkbox', id: 'accept_terms', ng: { model: "terms_and_conditions_accepted", init: "terms_and_conditions_activated=#{terms_and_conditions_activated}; terms_and_conditions_accepted=#{terms_and_conditions_already_accepted}" } }
%input{ type: 'checkbox', id: 'accept_terms', ng: { model: "terms_and_conditions_accepted", init: "terms_and_conditions_activated=#{terms_and_conditions_activated?}; terms_and_conditions_accepted=#{terms_and_conditions_already_accepted?}" } }
%label.small{for: "accept_terms"}= t('.message_html', terms_and_conditions_link: link_to( t( '.link_text' ), current_order.distributor.terms_and_conditions.url, target: '_blank'))