Merge branch 'caching' into new_cart

Conflicts:
	app/serializers/api/variant_serializer.rb
This commit is contained in:
Will Marshall
2014-07-18 11:23:25 +10:00
7 changed files with 70 additions and 5 deletions

View File

@@ -8,10 +8,16 @@ class ShopController < BaseController
end
def products
unless @products = current_order_cycle.andand
# Can we make this query less slow?
#
if @products = current_order_cycle.andand
.valid_products_distributed_by(current_distributor).andand
.select { |p| !p.deleted? && p.has_stock_for_distribution?(current_order_cycle, current_distributor) }.andand
.sort_by {|p| p.name }
render status: 200,
json: ActiveModel::ArraySerializer.new(@products, each_serializer: Api::ProductSerializer,
current_order_cycle: current_order_cycle, current_distributor: current_distributor).to_json
else
render json: "", status: 404
end
end

View File

@@ -0,0 +1,4 @@
class Api::MasterVariantSerializer < ActiveModel::Serializer
attributes :id, :is_master, :count_on_hand, :name_to_display, :unit_to_display, :count_on_hand, :on_demand
has_many :images, serializer: Api::TaxonImageSerializer
end

View File

@@ -0,0 +1,41 @@
class Api::ProductSerializer < ActiveModel::Serializer
# TODO
# Prices can't be cached? How?
def serializable_hash
cached_serializer_hash.merge uncached_serializer_hash
end
private
def cached_serializer_hash
Api::CachedProductSerializer.new(object, @options).serializable_hash
end
def uncached_serializer_hash
Api::UncachedProductSerializer.new(object, @options).serializable_hash
end
end
class Api::UncachedProductSerializer < ActiveModel::Serializer
attributes :price
def price
object.master.price_with_fees(options[:current_distributor], options[:current_order_cycle])
end
end
class Api::CachedProductSerializer < ActiveModel::Serializer
cached
delegate :cache_key, to: :object
attributes :id, :name, :permalink, :count_on_hand, :on_demand, :group_buy,
:notes, :description
has_many :variants, serializer: Api::VariantSerializer
has_many :taxons, serializer: Api::IdSerializer
has_many :properties, serializer: Api::PropertySerializer
has_one :supplier, serializer: Api::IdSerializer
has_one :primary_taxon, serializer: Api::TaxonSerializer
has_one :master, serializer: Api::MasterVariantSerializer
end

View File

@@ -0,0 +1,3 @@
class Api::PropertySerializer < ActiveModel::Serializer
end

View File

@@ -0,0 +1,11 @@
class Api::TaxonImageSerializer < ActiveModel::Serializer
attributes :id, :alt, :small_url, :large_url
def small_url
object.attachment.url(:small, false)
end
def large_url
object.attachment.url(:large, false)
end
end

View File

@@ -1,7 +1,8 @@
class Api::VariantSerializer < ActiveModel::Serializer
attributes :id, :is_master, :count_on_hand, :name_to_display, :on_demand,
:price
attributes :id, :is_master, :count_on_hand, :name_to_display, :unit_to_display, :on_demand
attributes :price
has_many :images, serializer: Api::ImageSerializer
def price

View File

@@ -142,11 +142,10 @@ describe ShopController do
end
it "includes the primary taxon" do
taxon = mock_model(Spree::Taxon, name: "fruitbat")
taxon = create(:taxon)
Spree::Product.any_instance.stub(:primary_taxon).and_return taxon
taxon.stub_chain(:icon, :url).and_return ""
xhr :get, :products
response.body.should have_content "fruitbat"
response.body.should have_content taxon.name
end
end
end