raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-03-19 04:49:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor #sort_by_supplier_id

Browse Source
This commit is contained in:
Matt-Yorkley
2019-11-03 14:37:38 +00:00
committed by luisramos0
parent ab30307b1a
commit a1146aed1b
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
app/serializers/api/admin/order_cycle_serializer.rb
View File

@@ -33,7 +33,7 @@ class Api::Admin::OrderCycleSerializer < ActiveModel::Serializer
end
def editable_variants_for_incoming_exchanges
sort_by_supplier_id(permissions.all_incoming_editable_variants.all)
variant_ids_by_supplier_id(permissions.all_incoming_editable_variants.all)
end
def editable_variants_for_outgoing_exchanges
@@ -79,17 +79,10 @@ class Api::Admin::OrderCycleSerializer < ActiveModel::Serializer
@visible_enterprises ||= permissions.visible_enterprises
end
def sort_by_supplier_id(variants)
collection = {}
variants.map do |variant|
supplier_id = variant.product.supplier_id
if collection.key? supplier_id
collection[supplier_id] << variant.id
else
collection[supplier_id] = [variant.id]
end
def variant_ids_by_supplier_id(variants)
grouped_by_supplier = variants.group_by(&:supplier_id)
grouped_by_supplier.each do |supplier_id, grouped_variants|
grouped_by_supplier[supplier_id] = grouped_variants.map(&:id)
end
collection
end
end