raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor code for validating variant in reference to existing product

Browse Source
This commit is contained in:
Kristina Lim
2019-06-10 01:23:31 +08:00
parent 70614de955
commit 8c69ee67b8
1 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
app/models/product_import/entry_validator.rb
View File

@@ -164,12 +164,22 @@ module ProductImport
def variant_of_product_validation(entry)
return if entry.producer.blank? || entry.name.blank?
validate_unit_type_unchanged(entry)
validate_variant_unit_name_unchanged(entry)
end
def validate_unit_type_unchanged(entry)
return if entry.unit_type.blank?
reference_entry = all_entries_for_product(entry).first
if entry.unit_type.present? && entry.unit_type.to_s != reference_entry.unit_type.to_s
mark_as_not_updatable(entry, "unit_type")
elsif entry.variant_unit_name.present? && entry.variant_unit_name.to_s != reference_entry.variant_unit_name.to_s
mark_as_not_updatable(entry, "variant_unit_name")
end
return if entry.unit_type.to_s == reference_entry.unit_type.to_s
mark_as_not_updatable(entry, "unit_type")
end
def validate_variant_unit_name_unchanged(entry)
return if entry.variant_unit_name.blank?
reference_entry = all_entries_for_product(entry).first
return if entry.variant_unit_name.to_s == reference_entry.variant_unit_name.to_s
mark_as_not_updatable(entry, "variant_unit_name")
end
def producer_validation(entry)