raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-03-23 05:28:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Extract method to make code easier to read

Browse Source
This commit is contained in:
Luis Ramos
2020-08-31 16:18:36 +01:00
committed by Andy Brett
parent 9204687e4d
commit 83ae13d7c7
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
lib/open_food_network/option_value_namer.rb
View File

@@ -77,19 +77,25 @@ module OpenFoodNetwork
}
}
# Find the largest available and compatible unit where unit_value comes
# to >= 1 when expressed in it.
# If there is none available where this is true, use the smallest available unit.
scales = units[@variant.product.variant_unit]
product_scale = @variant.product.variant_unit_scale
product_scale_system = scales[product_scale.to_f]['system']
largest_unit = find_largest_unit(scales, product_scale_system)
[largest_unit[0], largest_unit[1]["name"]]
end
# Find the largest available and compatible unit where unit_value comes
# to >= 1 when expressed in it.
# If there is none available where this is true, use the smallest available unit.
def find_largest_unit(scales, product_scale_system)
largest_unit = scales.select { |scale, unit_info|
unit_info['system'] == product_scale_system &&
@variant.unit_value / scale >= 1
}.max
largest_unit = units[@variant.product.variant_unit].first if largest_unit.nil?
return scales.first if largest_unit.nil?
[largest_unit[0], largest_unit[1]["name"]]
largest_unit
end
def pluralize(unit_name, count)