Merge pull request #13227 from chitty/rubocop-style-autocorrection-fix

Autocorrect rubocop offenses Style/RedundantAssignment and Style/RedundantArgument

.rubocop_todo.yml

@@ -702,19 +702,6 @@ Style/PreferredHashMethods:
   Exclude:
     - 'app/controllers/api/v0/shipments_controller.rb'
 
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: Methods.
-Style/RedundantArgument:
-  Exclude:
-    - 'engines/dfc_provider/app/services/authorization_control.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/RedundantAssignment:
-  Exclude:
-    - 'spec/models/database_spec.rb'
-
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: AutoCorrect, AllowComments.

engines/dfc_provider/app/services/authorization_control.rb

@@ -47,7 +47,7 @@ class AuthorizationControl
   end
 
   def access_token
-    @request.headers['Authorization'].to_s.split(' ').last
+    @request.headers['Authorization'].to_s.split.last
   end
 
   def ofn_api_token

spec/models/database_spec.rb

@@ -102,7 +102,7 @@ RSpec.describe "Database" do
     orphaned_records_query = generate_orphaned_records_query(model_class, foreign_key_table_name,
                                                              foreign_key_column)
 
-    migration = <<~MIGRATION
+    <<~MIGRATION
       # Orphaned records can be found before running this migration with the following SQL:
 
       #{orphaned_records_query}
@@ -113,8 +113,6 @@ RSpec.describe "Database" do
         end
       end
     MIGRATION
-
-    migration
   end
 
   def generate_orphaned_records_query(model_class, foreign_key_table_name, foreign_key_column)