raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug: set difference comparison of string with number

Browse Source
This commit is contained in:
Rohan Mitchell
2015-11-10 11:18:31 +11:00
parent 888e4d80ef
commit 7fffa03d8d
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/spree/order_populator_decorator.rb
View File

@@ -76,7 +76,7 @@ Spree::OrderPopulator.class_eval do
end
def variants_removed(variants_data)
variant_ids_given = variants_data.map { |data| data[:variant_id] }
variant_ids_given = variants_data.map { |data| data[:variant_id].to_i }
(variant_ids_in_cart - variant_ids_given).uniq
end

4
spec/models/spree/order_populator_spec.rb
View File

@@ -100,12 +100,12 @@ module Spree
it "returns nothing when all items in the cart are provided" do
op.stub(:variant_ids_in_cart) { [123] }
op.send(:variants_removed, [{variant_id: 123}]).should == []
op.send(:variants_removed, [{variant_id: '123'}]).should == []
end
it "returns nothing when items are added to cart" do
op.stub(:variant_ids_in_cart) { [123] }
op.send(:variants_removed, [{variant_id: 123}, {variant_id: 456}]).should == []
op.send(:variants_removed, [{variant_id: '123'}, {variant_id: '456'}]).should == []
end
it "does not return duplicates" do