raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-29 21:17:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix time in reports spec

Browse Source 
Some specs were starting to fail because I created an order in the past
while the default report is for the last month only. It didn't include
that order any more.

I now defined the dates everywhere to remove this variable of the
current date.
This commit is contained in:
Maikel Linke
2022-06-27 16:19:38 +10:00
parent 6a80cb8bfa
commit 721fc0fd3f
1 changed files with 24 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
spec/lib/reports/orders_and_fulfillment/order_cycle_customer_totals_report_spec.rb
View File

@@ -7,8 +7,12 @@ describe Reporting::Reports::OrdersAndFulfillment::OrderCycleCustomerTotals do
let!(:customer) { create(:customer, enterprise: distributor, user: user, code: "JHN") }
let(:user) { create(:user, email: "john@example.net") }
let(:current_user) { distributor.owner }
let(:params) { { display_summary_row: true } }
let(:params) { { display_summary_row: true, q: search_params } }
let(:search_params) {
{ completed_at_gt: 1.week.before(order_date), completed_at_lt: 1.week.after(order_date) }
}
let(:report) { described_class.new(current_user, params) }
let(:order_date) { Date.parse("2022-05-26") }
let(:report_table) do
report.table_rows
@@ -23,7 +27,7 @@ describe Reporting::Reports::OrdersAndFulfillment::OrderCycleCustomerTotals do
user: customer.user,
customer: customer,
distributor: distributor,
completed_at: Date.parse("2022-05-26"),
completed_at: order_date,
).tap do |order|
order.line_items[0].product.supplier.update(name: "Apple Farmer")
order.line_items[0].product.update(name: "Apples")
@@ -73,8 +77,12 @@ describe Reporting::Reports::OrdersAndFulfillment::OrderCycleCustomerTotals do
create(:shipping_method, distributors: [distributor], name: "Third")
}
let!(:order) do
create(:completed_order_with_totals, line_items_count: 1, user: customer.user,
customer: customer, distributor: distributor)
create(
:completed_order_with_totals,
line_items_count: 1, user: customer.user,
customer: customer, distributor: distributor,
completed_at: order_date,
)
end
before do
@@ -90,8 +98,12 @@ describe Reporting::Reports::OrdersAndFulfillment::OrderCycleCustomerTotals do
context "displaying payment fees" do
context "with both failed and completed payments present" do
let!(:order) {
create(:order_ready_to_ship, user: customer.user,
customer: customer, distributor: distributor)
create(
:order_ready_to_ship,
user: customer.user,
customer: customer, distributor: distributor,
completed_at: order_date,
)
}
let(:completed_payment) { order.payments.completed.first }
let!(:failed_payment) { create(:payment, order: order, state: "failed") }
@@ -110,8 +122,12 @@ describe Reporting::Reports::OrdersAndFulfillment::OrderCycleCustomerTotals do
context 'when a variant override applies' do
let!(:order) do
create(:completed_order_with_totals, line_items_count: 1, user: customer.user,
customer: customer, distributor: distributor)
create(
:completed_order_with_totals,
line_items_count: 1, user: customer.user,
customer: customer, distributor: distributor,
completed_at: order_date,
)
end
let(:overidden_sku) { 'magical_sku' }