Refresh products cache when taxons or classifications are changed or destroyed

This commit is contained in:
Rohan Mitchell
2016-02-03 14:53:55 +11:00
parent 7c4e9e5838
commit 6d80d91873
4 changed files with 51 additions and 2 deletions

View File

@@ -1,6 +1,15 @@
Spree::Classification.class_eval do
belongs_to :product, :class_name => "Spree::Product", touch: true
after_save :refresh_products_cache
before_destroy :dont_destroy_if_primary_taxon
after_destroy :refresh_products_cache
private
def refresh_products_cache
product.refresh_products_cache
end
def dont_destroy_if_primary_taxon
if product.primary_taxon == taxon

View File

@@ -1,7 +1,12 @@
Spree::Taxon.class_eval do
has_many :classifications, :dependent => :destroy
self.attachment_definitions[:icon][:path] = 'public/images/spree/taxons/:id/:style/:basename.:extension'
self.attachment_definitions[:icon][:url] = '/images/spree/taxons/:id/:style/:basename.:extension'
after_save :refresh_products_cache
# Indicate which filters should be used for this taxon
def applicable_filters
@@ -45,4 +50,11 @@ Spree::Taxon.class_eval do
taxons
end
private
def refresh_products_cache
products(:reload).each &:refresh_products_cache
end
end

View File

@@ -2,8 +2,8 @@ require 'spec_helper'
module Spree
describe Classification do
let(:product) { create(:simple_product) }
let(:taxon) { create(:taxon) }
let!(:product) { create(:simple_product) }
let!(:taxon) { create(:taxon) }
let(:classification) { create(:classification, taxon: taxon, product: product) }
it "won't destroy if classification is the primary taxon" do
@@ -11,5 +11,18 @@ module Spree
classification.destroy.should be_false
classification.errors.messages[:base].should == ["Taxon #{taxon.name} is the primary taxon of #{product.name} and cannot be deleted"]
end
describe "callbacks" do
it "refreshes the products cache on save" do
expect(OpenFoodNetwork::ProductsCache).to receive(:product_changed).with(product)
classification
end
it "refreshes the products cache on destroy" do
classification
expect(OpenFoodNetwork::ProductsCache).to receive(:product_changed).with(product)
classification.destroy
end
end
end
end

View File

@@ -7,6 +7,21 @@ module Spree
let(:t1) { create(:taxon) }
let(:t2) { create(:taxon) }
describe "callbacks" do
let(:product) { create(:simple_product, taxons: [t1]) }
it "refreshes the products cache on save" do
expect(OpenFoodNetwork::ProductsCache).to receive(:product_changed).with(product)
t1.name = 'asdf'
t1.save
end
it "refreshes the products cache on destroy" do
expect(OpenFoodNetwork::ProductsCache).to receive(:product_changed).with(product)
t1.destroy
end
end
describe "finding all supplied taxons" do
let!(:p1) { create(:simple_product, supplier: e, taxons: [t1, t2]) }