Add explanatory comment on soft-deleted variant stock logic

2026-02-27 01:43:22 +00:00 · 2020-05-05 12:19:05 +02:00
parent 0a28abbf2d
commit 6afda87baf
1 changed files with 2 additions and 0 deletions
--- a/app/models/spree/stock/quantifier.rb
+++ b/app/models/spree/stock/quantifier.rb
@@ -11,6 +11,8 @@ module Spree
      end

      def total_on_hand
+        # Associated stock_items no longer exist if the variant has been soft-deleted. A variant
+        # may still be in an active cart after it's deleted, so this will mark it as out of stock.
        return 0 if @variant.deleted?

        stock_items.sum(&:count_on_hand)