raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-13 23:37:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

update product feature test to use ulr helpers

Browse Source
This commit is contained in:
Gaetan Riou
2020-07-24 15:25:37 +10:00
parent 459708dbc8
commit 684ae2ca22
2 changed files with 25 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/features/admin/bulk_product_update_spec.rb
View File

@@ -521,7 +521,7 @@ feature '
find("a.edit-product").click
end
expect(URI.parse(current_url).path).to eq "/admin/products/#{p1.permalink}/edit"
expect(URI.parse(current_url).path).to eq spree.edit_admin_product_path(v1.product.permalink)
end
it "shows an edit button for products, which takes the user to the standard edit page for that product, url includes selected filter" do
@@ -536,7 +536,7 @@ feature '
end
uri = URI.parse(current_url)
expect("#{uri.path}?#{uri.query}").to eq "/admin/products/#{p1.permalink}/edit?producerFilter=#{p1.supplier.id}"
expect("#{uri.path}?#{uri.query}").to eq spree.edit_admin_product_path(v1.product.permalink, producerFilter: p1.supplier.id)
end
it "shows an edit button for variants, which takes the user to the standard edit page for that variant" do
@@ -550,7 +550,7 @@ feature '
end
uri = URI.parse(current_url)
expect(URI.parse(current_url).path).to eq "/admin/products/#{v1.product.permalink}/variants/#{v1.id}/edit"
expect(URI.parse(current_url).path).to eq spree.edit_admin_product_variant_path(v1.product.permalink, v1.id)
end
it "shows an edit button for variants, which takes the user to the standard edit page for that variant, url includes selected filter" do
@@ -568,7 +568,7 @@ feature '
end
uri = URI.parse(current_url)
expect("#{uri.path}?#{uri.query}").to eq "/admin/products/#{v1.product.permalink}/variants/#{v1.id}/edit?producerFilter=#{p1.supplier.id}"
expect("#{uri.path}?#{uri.query}").to eq spree.edit_admin_product_variant_path(v1.product.permalink, v1.id, producerFilter: p1.supplier.id)
end
end

31
spec/features/admin/products_spec.rb
View File

@@ -162,19 +162,30 @@ feature '
# Check the url still includes the filters
uri = URI.parse(current_url)
expect("#{uri.path}?#{uri.query}").to eq "#{spree.edit_admin_product_path(product)}?#{filter_query}"
expect("#{uri.path}?#{uri.query}").to eq spree.edit_admin_product_path(product, producerFilter: 2)
# Link back to the bulk product update page should include the filters
expect(page).to have_link(I18n.t('admin.products.back_to_products_list'), href: %r{admin\/products#\?#{filter_query}})
expect(page).to have_link(I18n.t(:cancel), href: %r{admin\/products#\?#{filter_query}})
expected_admin_product_url = Regexp.new(Regexp.escape("#{spree.admin_products_path}#?#{filter_query}"))
expect(page).to have_link(I18n.t('admin.products.back_to_products_list'), href: expected_admin_product_url)
expect(page).to have_link(I18n.t(:cancel), href: expected_admin_product_url)
# Sidebar link should include the filters
expect(page).to have_link(I18n.t('admin.products.tabs.product_details'), href: %r{admin\/products\/#{product.permalink}\/edit\?#{filter_query}})
expect(page).to have_link(I18n.t('admin.products.tabs.images'), href: %r{admin\/products\/#{product.permalink}\/images\?#{filter_query}})
expect(page).to have_link(I18n.t('admin.products.tabs.variants'), href: %r{admin\/products\/#{product.permalink}\/variants\?#{filter_query}})
expect(page).to have_link(I18n.t('admin.products.tabs.product_properties'), href: %r{admin\/products\/#{product.permalink}\/product_properties\?#{filter_query}})
expect(page).to have_link(I18n.t('admin.products.tabs.group_buy_options'), href: %r{admin\/products\/#{product.permalink}\/group_buy_options\?#{filter_query}})
expect(page).to have_link(I18n.t(:search), href: %r{admin\/products\/#{product.permalink}\/seo\?#{filter_query}})
expected_product_url = Regexp.new(Regexp.escape(spree.edit_admin_product_path(product.permalink, producerFilter: 2)))
expect(page).to have_link(I18n.t('admin.products.tabs.product_details'), href: expected_product_url)
expected_product_image_url = Regexp.new(Regexp.escape(spree.admin_product_images_path(product.permalink, producerFilter: 2)))
expect(page).to have_link(I18n.t('admin.products.tabs.images'), href: expected_product_image_url)
expected_product_variant_url = Regexp.new(Regexp.escape(spree.admin_product_variants_path(product.permalink, producerFilter: 2)))
expect(page).to have_link(I18n.t('admin.products.tabs.variants'), href: expected_product_variant_url)
expected_product_properties_url = Regexp.new(Regexp.escape(spree.admin_product_product_properties_path(product.permalink, producerFilter: 2)))
expect(page).to have_link(I18n.t('admin.products.tabs.product_properties'), href: expected_product_properties_url)
expected_product_group_buy_option_url = Regexp.new(Regexp.escape(spree.group_buy_options_admin_product_path(product.permalink, producerFilter: 2)))
expect(page).to have_link(I18n.t('admin.products.tabs.group_buy_options'), href: expected_product_group_buy_option_url)
expected_product_seo_url = Regexp.new(Regexp.escape(spree.seo_admin_product_path(product.permalink, producerFilter: 2)))
expect(page).to have_link(I18n.t(:search), href: expected_product_seo_url)
end
scenario "editing product group buy options" do