raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-08 22:56:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not restore adjustments that aren't in the hash

Browse Source 
This way we don't modify adjustments that get created as part of the
passed block. We don't know how this might be used in the future.
This commit is contained in:
Pau Perez
2019-01-23 10:48:20 +01:00
parent f4b790eefa
commit 59f39b14f4
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/controllers/spree/orders_controller_decorator.rb
View File

@@ -139,17 +139,21 @@ Spree::OrdersController.class_eval do
end
# Sets the adjustments to open to perform the block's action and restores
# their state to whatever the they had.
# their state to whatever the they had. Note that it does not change any new
# adjustments that might get created in the yielded block.
def with_open_adjustments
previous_states = @order.adjustments.each_with_object({}) do |adjustment, hash|
hash[adjustment.id] = adjustment.state
hash[adjustment.id] = { adjustment: adjustment, previous_state: adjustment.state }
end
@order.adjustments.each(&:open)
yield
@order.adjustments.each_with_index do |adjustment, index|
adjustment.update_attribute(:state, previous_states[adjustment.id])
previous_states.each do |adjustment_id, adjustment_pair|
adjustment = adjustment_pair[:adjustment]
previous_state = adjustment_pair[:previous_state]
adjustment.update_attribute(:state, previous_state)
end
end