raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-03-01 02:03:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Per review, stream line the css

Browse Source 
Reuse existing css when possible, and use variable for z-index so its
easier to track usage of z-index
This commit is contained in:
Gaetan Craig-Riou
2023-11-23 16:24:30 +11:00
committed by Konrad
parent aaa8f3f572
commit 56b75ad9fb
5 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/views/admin/_terms_of_service_banner.html.haml
View File

@@ -1,5 +1,5 @@
.banner-container#banner-container
.terms-of-service-banner
#banner-container
.terms-of-service-banner.form-actions
.column-left
%p= t("admin.terms_of_service_have_been_updated_html", tos_link: link_to(t("admin.terms_of_service"), TermsOfServiceFile.current_url, target: "_blank"))
.column-right

4
app/webpacker/css/admin/globals/variables.scss
View File

@@ -149,3 +149,7 @@ $border-radius: 3px !default;
$font-weight-bold: 600 !default;
$font-weight-normal: 400 !default;
// z-index
//--------------------------------------------------------------
$tos-banner-z-index: 102;

4
app/webpacker/css/admin/terms_of_service_banner.scss
View File

@@ -1,9 +1,9 @@
.banner-container {
#banner-container {
position: fixed;
bottom: 0;
left: 0;
width: 100%;
z-index: 1000;
z-index: $tos-banner-z-index;
.terms-of-service-banner {
padding: 18px;

4
app/webpacker/css/admin_v3/globals/variables.scss
View File

@@ -176,3 +176,7 @@ $font-weight-normal: 400 !default;
$btn-relaxed-height: 40px !default;
$btn-regular-height: 32px !default;
$btn-condensed-height: 26px !default;
// z-index
//--------------------------------------------------------------
$tos-banner-z-index: 102;

11
app/webpacker/css/admin_v3/terms_of_service_banner.scss
View File

@@ -1,18 +1,13 @@
.banner-container {
#banner-container {
position: fixed;
bottom: 0;
left: 0;
width: 100%;
z-index: 1000;
z-index: $tos-banner-z-index;
padding: 0 1.5%;
min-height: 50px;
.terms-of-service-banner {
background-color: $fair-pink;
border: none;
border-left: 4px solid $red;
border-radius: 4px;
margin: 0.5em 0;
padding: 0;
display: flex;
.column-left {