Refactor code for brevity

2026-03-25 05:45:15 +00:00 · 2015-06-30 12:54:03 +10:00
parent 8deb4ef9d4
commit 4cc8eb90fc
1 changed files with 6 additions and 9 deletions
--- a/app/controllers/checkout_controller.rb
+++ b/app/controllers/checkout_controller.rb
@@ -83,17 +83,14 @@ class CheckoutController < Spree::CheckoutController
    params[:order]
  end

+  # Perform order.next, guarding against StaleObjectErrors
  def advance_order_state(order)
-    result = false
-    tries = 3
+    tries ||= 3
+    order.next

-    begin
-      result = order.next
-    rescue ActiveRecord::StaleObjectError
-      retry unless (tries -= 1).zero?
-    end
-
-    result
+  rescue ActiveRecord::StaleObjectError
+    retry unless (tries -= 1).zero?
+    false
  end