raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix rubocop issues

Browse Source
This commit is contained in:
Luis Ramos
2020-10-16 15:59:51 +01:00
parent e860e2ca57
commit 4a2684e3d9
2 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.rubocop_todo.yml
View File

@@ -563,7 +563,6 @@ Style/ClassAndModuleChildren:
- 'app/serializers/api/admin/calculator/flat_percent_item_total_serializer.rb'
- 'app/serializers/api/admin/calculator_serializer.rb'
- 'app/serializers/api/admin/column_preference_serializer.rb'
- 'app/serializers/api/admin/customer_serializer.rb'
- 'app/serializers/api/admin/enterprise_fee_serializer.rb'
- 'app/serializers/api/admin/enterprise_relationship_permission_serializer.rb'
- 'app/serializers/api/admin/enterprise_relationship_serializer.rb'
@@ -851,7 +850,6 @@ Style/FrozenStringLiteralComment:
- 'app/serializers/api/admin/calculator/flat_percent_item_total_serializer.rb'
- 'app/serializers/api/admin/calculator_serializer.rb'
- 'app/serializers/api/admin/column_preference_serializer.rb'
- 'app/serializers/api/admin/customer_serializer.rb'
- 'app/serializers/api/admin/enterprise_fee_serializer.rb'
- 'app/serializers/api/admin/enterprise_relationship_permission_serializer.rb'
- 'app/serializers/api/admin/enterprise_relationship_serializer.rb'

11
app/serializers/api/admin/customer_serializer.rb
View File

@@ -1,3 +1,5 @@
# frozen_string_literal: true
class Api::Admin::CustomerSerializer < ActiveModel::Serializer
attributes :id, :email, :enterprise_id, :user_id, :code, :tags, :tag_list, :name,
:allow_charges, :default_card_present?, :balance, :balance_status
@@ -14,13 +16,13 @@ class Api::Admin::CustomerSerializer < ActiveModel::Serializer
end
def balance
Spree::Money.new(balance_value, { currency: Spree::Config[:currency] }).to_s
Spree::Money.new(balance_value, currency: Spree::Config[:currency]).to_s
end
def balance_status
if balance_value > 0
if balance_value.positive?
"credit_owed"
elsif balance_value < 0
elsif balance_value.negative?
"balance_due"
else
""
@@ -49,6 +51,7 @@ class Api::Admin::CustomerSerializer < ActiveModel::Serializer
end
def balance_value
@balance_value ||= OpenFoodNetwork::UserBalanceCalculator.new(object.email, object.enterprise).balance
@balance_value ||=
OpenFoodNetwork::UserBalanceCalculator.new(object.email, object.enterprise).balance
end
end