raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-27 01:43:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move more reset variant code for re-use

Browse Source
This commit is contained in:
Maikel Linke
2025-03-27 13:33:52 +11:00
parent c43bd0c24b
commit 48e3b5b05e
2 changed files with 23 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
app/controllers/admin/dfc_product_imports_controller.rb
View File

@@ -86,26 +86,8 @@ module Admin
end
end
# Reset stock for any variants that were removed from the catalog.
#
# When variants are removed from the remote catalog, we can't place
# backorders for them anymore. If our copy of the product has limited
# stock then we need to set the stock to zero to prevent any more sales.
#
# But if our product is on-demand/backorderable then our stock level is
# a representation of remaining local stock. We then need to limit sales
# to this local stock and set on-demand to false.
#
# We don't delete the variant because it may come back at a later time and
# we don't want to lose the connection to previous orders.
def reset_absent_variants(catalog)
absent_variants(catalog).map do |variant|
if variant.on_demand
variant.on_demand = false
else
variant.on_hand = 0
end
end
DfcCatalogImporter.new(@enterprise.supplied_variants, catalog).reset_absent_variants
end
def absent_variants(catalog)

22
app/services/dfc_catalog_importer.rb
View File

@@ -8,6 +8,28 @@ class DfcCatalogImporter
@catalog = catalog
end
# Reset stock for any variants that were removed from the catalog.
#
# When variants are removed from the remote catalog, we can't place
# backorders for them anymore. If our copy of the product has limited
# stock then we need to set the stock to zero to prevent any more sales.
#
# But if our product is on-demand/backorderable then our stock level is
# a representation of remaining local stock. We then need to limit sales
# to this local stock and set on-demand to false.
#
# We don't delete the variant because it may come back at a later time and
# we don't want to lose the connection to previous orders.
def reset_absent_variants
absent_variants.map do |variant|
if variant.on_demand
variant.on_demand = false
else
variant.on_hand = 0
end
end
end
def absent_variants
present_ids = catalog.products.map(&:semanticId)
catalog_url = FdcUrlBuilder.new(present_ids.first).catalog_url