raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-28 01:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor #process! nested ifs to guard clauses

Browse Source 
Following Rubocop's indications.
This commit is contained in:
Pau Perez
2020-07-13 09:43:18 +02:00
parent 66dbd85eb4
commit 42658b5255
1 changed files with 15 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
app/models/spree/payment/processing.rb
View File

@@ -4,23 +4,21 @@ module Spree
class Payment < ActiveRecord::Base
module Processing
def process!
if payment_method&.source_required?
if source
if !processing?
if payment_method.supports?(source)
if payment_method.auto_capture?
purchase!
else
authorize!
end
else
invalidate!
raise Core::GatewayError, Spree.t(:payment_method_not_supported)
end
end
else
raise Core::GatewayError, Spree.t(:payment_processing_failed)
end
return unless payment_method&.source_required?
raise Core::GatewayError, Spree.t(:payment_processing_failed) unless source
return if processing?
unless payment_method.supports?(source)
invalidate!
raise Core::GatewayError.new(Spree.t(:payment_method_not_supported))
end
if payment_method.auto_capture?
purchase!
else
authorize!
end
end