raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Splitting out specs for pending changes service

Browse Source
This commit is contained in:
Rob Harrington
2015-05-13 16:39:43 +10:00
parent ffac0e4ceb
commit 3849b39d3e
2 changed files with 121 additions and 121 deletions
Download Patch File Download Diff File Expand all files Collapse all files

119
spec/javascripts/unit/admin/index_utils/services/pending_changes_spec.js.coffee Normal file
View File

@@ -0,0 +1,119 @@
describe "Pending Changes", ->
dataSubmitter = pendingChanges = null
beforeEach ->
dataSubmitter = jasmine.createSpy('dataSubmitter').andReturn {
then: (thenFn) ->
thenFn({propertyName: "new_value"})
}
module 'admin.indexUtils', ($provide) ->
$provide.value 'dataSubmitter', dataSubmitter
return
inject (_pendingChanges_) ->
pendingChanges = _pendingChanges_
describe "adding a new change", ->
it "adds a new object with key of id if it does not already exist", ->
expect(pendingChanges.pendingChanges).toEqual {}
expect(pendingChanges.pendingChanges["1"]).not.toBeDefined()
pendingChanges.add 1, "propertyName", { a: 1 }
expect(pendingChanges.pendingChanges["1"]).toBeDefined()
it "adds a new object with key of the altered attribute name if it does not already exist", ->
pendingChanges.add 1, "propertyName", { a: 1 }
expect(pendingChanges.pendingChanges["1"]).toBeDefined()
expect(pendingChanges.pendingChanges["1"]["propertyName"]).toEqual { a: 1 }
it "replaces the existing object when adding a change to an attribute which already exists", ->
pendingChanges.add 1, "propertyName", { a: 1 }
expect(pendingChanges.pendingChanges["1"]).toBeDefined()
expect(pendingChanges.pendingChanges["1"]["propertyName"]).toEqual { a: 1 }
pendingChanges.add 1, "propertyName", { b: 2 }
expect(pendingChanges.pendingChanges["1"]["propertyName"]).toEqual { b: 2 }
it "adds an attribute to key to a line item object when one already exists", ->
pendingChanges.add 1, "propertyName1", { a: 1 }
pendingChanges.add 1, "propertyName2", { b: 2 }
expect(pendingChanges.pendingChanges["1"]).toEqual { propertyName1: { a: 1}, propertyName2: { b: 2 } }
describe "removing all existing changes", ->
it "resets pendingChanges object", ->
pendingChanges.pendingChanges = { 1: { "propertyName1": { a: 1 }, "propertyName2": { b: 2 } } }
expect(pendingChanges.pendingChanges["1"]["propertyName1"]).toBeDefined()
expect(pendingChanges.pendingChanges["1"]["propertyName2"]).toBeDefined()
pendingChanges.removeAll()
expect(pendingChanges.pendingChanges["1"]).not.toBeDefined()
expect(pendingChanges.pendingChanges).toEqual {}
describe "removing an existing change", ->
it "deletes a change if it exists", ->
pendingChanges.pendingChanges = { 1: { "propertyName1": { a: 1 }, "propertyName2": { b: 2 } } }
expect(pendingChanges.pendingChanges["1"]["propertyName1"]).toBeDefined()
pendingChanges.remove 1, "propertyName1"
expect(pendingChanges.pendingChanges["1"]).toBeDefined()
expect(pendingChanges.pendingChanges["1"]["propertyName1"]).not.toBeDefined()
it "deletes a line item object if it is empty", ->
pendingChanges.pendingChanges = { 1: { "propertyName1": { a: 1 } } }
expect(pendingChanges.pendingChanges["1"]["propertyName1"]).toBeDefined()
pendingChanges.remove 1, "propertyName1"
expect(pendingChanges.pendingChanges["1"]).not.toBeDefined()
it "does nothing if key with specified attribute does not exist", ->
pendingChanges.pendingChanges = { 1: { "propertyName1": { a: 1 } } }
expect(pendingChanges.pendingChanges["1"]["propertyName1"]).toBeDefined()
pendingChanges.remove 1, "propertyName2"
expect(pendingChanges.pendingChanges["1"]["propertyName1"]).toEqual { a: 1 }
it "does nothing if key with specified id does not exist", ->
pendingChanges.pendingChanges = { 1: { "propertyName1": { a: 1 } } }
expect(pendingChanges.pendingChanges["1"]["propertyName1"]).toBeDefined()
pendingChanges.remove 2, "propertyName1"
expect(pendingChanges.pendingChanges["1"]).toEqual { "propertyName1": { a: 1 } }
describe "submitting an individual change to the server", ->
change = null
beforeEach ->
object = {id: 1}
scope = { reset: jasmine.createSpy('reset') };
attr = "propertyName"
change = { object: object, scope: scope, attr: attr }
it "sends the correct object to dataSubmitter", ->
pendingChanges.submit change
expect(dataSubmitter.calls.length).toEqual 1
expect(dataSubmitter).toHaveBeenCalledWith change
it "calls remove with id and attribute name", ->
spyOn(pendingChanges, "remove").andCallFake(->)
pendingChanges.submit change
expect(pendingChanges.remove.calls.length).toEqual 1
expect(pendingChanges.remove).toHaveBeenCalledWith 1, "propertyName"
it "calls reset on the relevant scope", ->
pendingChanges.submit change
expect(change.scope.reset).toHaveBeenCalledWith "new_value"
describe "cycling through all changes to submit to server", ->
it "sends the correct object to dataSubmitter", ->
spyOn(pendingChanges, "submit").andCallFake(->)
pendingChanges.pendingChanges =
1: { "prop1": { attr: "prop1", value: 1 }, "prop2": { attr: "prop2", value: 2 } }
2: { "prop1": { attr: "prop1", value: 2 }, "prop2": { attr: "prop2", value: 4 } }
7: { "prop2": { attr: "prop2", value: 5 } }
pendingChanges.submitAll()
expect(pendingChanges.submit.calls.length).toEqual 5
expect(pendingChanges.submit).toHaveBeenCalledWith { attr: "prop1", value: 1 }
expect(pendingChanges.submit).toHaveBeenCalledWith { attr: "prop2", value: 2 }
expect(pendingChanges.submit).toHaveBeenCalledWith { attr: "prop1", value: 2 }
expect(pendingChanges.submit).toHaveBeenCalledWith { attr: "prop2", value: 4 }
expect(pendingChanges.submit).toHaveBeenCalledWith { attr: "prop2", value: 5 }
it "returns an array of promises representing all sumbit requests", ->
spyOn(pendingChanges, "submit").andCallFake (change) -> change.value
pendingChanges.pendingChanges =
1: { "prop1": { attr: "prop1", value: 1 } }
2: { "prop1": { attr: "prop1", value: 2 }, "prop2": { attr: "prop1", value: 4 } }
expect(pendingChanges.submitAll()).toEqual [ 1, 2, 4 ]

123
spec/javascripts/unit/bulk_order_management_spec.js.coffee
View File

@@ -33,8 +33,8 @@ describe "AdminOrderMgmtCtrl", ->
httpBackend.flush()
expect(scope.suppliers).toEqual [{ id : '0', name : 'All' }, 'list of suppliers']
expect(scope.distributors).toEqual [ { id : '0', name : 'All' }, 'list of distributors' ]
expect(scope.orderCycles).toEqual [ { id : '0', name : 'All' }, 'oc1', 'oc2', 'oc3' ]
expect(scope.distributors).toEqual [ { id : '0', name : 'All' }, 'list of distributors' ]
expect(scope.orderCycles).toEqual [ { id : '0', name : 'All' }, 'oc1', 'oc2', 'oc3' ]
expect(scope.initialiseVariables.calls.length).toBe 1
expect(scope.fetchOrders.calls.length).toBe 1
@@ -350,125 +350,6 @@ describe "AdminOrderMgmtCtrl", ->
spyOn(VariantUnitManager, "getUnitName").andReturn "kg"
expect(scope.formattedValueWithUnitName(2000,unitsVariant)).toEqual "2 kg"
describe "managing pending changes", ->
dataSubmitter = pendingChangesService = null
beforeEach ->
dataSubmitter = jasmine.createSpy('dataSubmitter').andReturn {
then: (thenFn) ->
thenFn({propertyName: "new_value"})
}
beforeEach ->
module "ofn.admin", ($provide) ->
$provide.value 'dataSubmitter', dataSubmitter
return
beforeEach inject (pendingChanges) ->
pendingChangesService = pendingChanges
describe "adding a new change", ->
it "adds a new object with key of id if it does not already exist", ->
expect(pendingChangesService.pendingChanges).toEqual {}
expect(pendingChangesService.pendingChanges["1"]).not.toBeDefined()
pendingChangesService.add 1, "propertyName", { a: 1 }
expect(pendingChangesService.pendingChanges["1"]).toBeDefined()
it "adds a new object with key of the altered attribute name if it does not already exist", ->
pendingChangesService.add 1, "propertyName", { a: 1 }
expect(pendingChangesService.pendingChanges["1"]).toBeDefined()
expect(pendingChangesService.pendingChanges["1"]["propertyName"]).toEqual { a: 1 }
it "replaces the existing object when adding a change to an attribute which already exists", ->
pendingChangesService.add 1, "propertyName", { a: 1 }
expect(pendingChangesService.pendingChanges["1"]).toBeDefined()
expect(pendingChangesService.pendingChanges["1"]["propertyName"]).toEqual { a: 1 }
pendingChangesService.add 1, "propertyName", { b: 2 }
expect(pendingChangesService.pendingChanges["1"]["propertyName"]).toEqual { b: 2 }
it "adds an attribute to key to a line item object when one already exists", ->
pendingChangesService.add 1, "propertyName1", { a: 1 }
pendingChangesService.add 1, "propertyName2", { b: 2 }
expect(pendingChangesService.pendingChanges["1"]).toEqual { propertyName1: { a: 1}, propertyName2: { b: 2 } }
describe "removing all existing changes", ->
it "resets pendingChanges object", ->
pendingChangesService.pendingChanges = { 1: { "propertyName1": { a: 1 }, "propertyName2": { b: 2 } } }
expect(pendingChangesService.pendingChanges["1"]["propertyName1"]).toBeDefined()
expect(pendingChangesService.pendingChanges["1"]["propertyName2"]).toBeDefined()
pendingChangesService.removeAll()
expect(pendingChangesService.pendingChanges["1"]).not.toBeDefined()
expect(pendingChangesService.pendingChanges).toEqual {}
describe "removing an existing change", ->
it "deletes a change if it exists", ->
pendingChangesService.pendingChanges = { 1: { "propertyName1": { a: 1 }, "propertyName2": { b: 2 } } }
expect(pendingChangesService.pendingChanges["1"]["propertyName1"]).toBeDefined()
pendingChangesService.remove 1, "propertyName1"
expect(pendingChangesService.pendingChanges["1"]).toBeDefined()
expect(pendingChangesService.pendingChanges["1"]["propertyName1"]).not.toBeDefined()
it "deletes a line item object if it is empty", ->
pendingChangesService.pendingChanges = { 1: { "propertyName1": { a: 1 } } }
expect(pendingChangesService.pendingChanges["1"]["propertyName1"]).toBeDefined()
pendingChangesService.remove 1, "propertyName1"
expect(pendingChangesService.pendingChanges["1"]).not.toBeDefined()
it "does nothing if key with specified attribute does not exist", ->
pendingChangesService.pendingChanges = { 1: { "propertyName1": { a: 1 } } }
expect(pendingChangesService.pendingChanges["1"]["propertyName1"]).toBeDefined()
pendingChangesService.remove 1, "propertyName2"
expect(pendingChangesService.pendingChanges["1"]["propertyName1"]).toEqual { a: 1 }
it "does nothing if key with specified id does not exist", ->
pendingChangesService.pendingChanges = { 1: { "propertyName1": { a: 1 } } }
expect(pendingChangesService.pendingChanges["1"]["propertyName1"]).toBeDefined()
pendingChangesService.remove 2, "propertyName1"
expect(pendingChangesService.pendingChanges["1"]).toEqual { "propertyName1": { a: 1 } }
describe "submitting an individual change to the server", ->
it "sends the correct object to dataSubmitter", ->
changeObj = { element: {} }
pendingChangesService.submit 1, "propertyName", changeObj
expect(dataSubmitter.calls.length).toEqual 1
expect(dataSubmitter).toHaveBeenCalledWith changeObj
it "calls remove with id and attribute name", ->
changeObj = { element: {} }
spyOn(pendingChangesService, "remove").andCallFake(->)
pendingChangesService.submit 1, "propertyName", changeObj
expect(pendingChangesService.remove.calls.length).toEqual 1
expect(pendingChangesService.remove).toHaveBeenCalledWith 1, "propertyName"
it "resets the dbValue attribute of the element in question", ->
element = { dbValue: 2 }
changeObj = { element: element }
pendingChangesService.submit 1, "propertyName", changeObj
expect(element.dbValue).toEqual "new_value"
describe "cycling through all changes to submit to server", ->
it "sends the correct object to dataSubmitter", ->
spyOn(pendingChangesService, "submit").andCallFake(->)
pendingChangesService.pendingChanges =
1: { "prop1": 1, "prop2": 2 }
2: { "prop1": 2, "prop2": 4 }
7: { "prop2": 5 }
pendingChangesService.submitAll()
expect(pendingChangesService.submit.calls.length).toEqual 5
expect(pendingChangesService.submit).toHaveBeenCalledWith '1', "prop1", 1
expect(pendingChangesService.submit).toHaveBeenCalledWith '1', "prop2", 2
expect(pendingChangesService.submit).toHaveBeenCalledWith '2', "prop1", 2
expect(pendingChangesService.submit).toHaveBeenCalledWith '2', "prop2", 4
expect(pendingChangesService.submit).toHaveBeenCalledWith '7', "prop2", 5
it "returns an array of promises representing all sumbit requests", ->
spyOn(pendingChangesService, "submit").andCallFake (id,attrName,changeObj) ->
id
pendingChangesService.pendingChanges =
1: { "prop1": 1 }
2: { "prop1": 2, "prop2": 4 }
expect(pendingChangesService.submitAll()).toEqual [ '1','2','2' ]
describe "dataSubmitter service", ->
qMock = httpMock = {}
switchClassSpy = resolveSpy = rejectSpy = dataSubmitterService = null