raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-06 22:36:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid reloading the payment every time, so that in-memory data is not wiped out

Browse Source 
When checkout fails and the payment states dont match (inside the if), in-memory data of the failed payment can be lost but updating the payment state is the fundamental part here so that further checkout attempts work. We may improve this update statement so that all the data of the failed payment is persisted
This commit is contained in:
Luis Ramos
2020-07-29 22:34:45 +01:00
parent 9e9e0d0bd8
commit 2136eecd09
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/services/order_workflow.rb
View File

@@ -64,8 +64,8 @@ class OrderWorkflow
def persist_all_payments
order.payments.each do |payment|
original_payment_state = payment.state
if original_payment_state != payment.reload.state
payment.update(state: original_payment_state)
if original_payment_state != Spree::Payment.find(payment.id).state
payment.reload.update(state: original_payment_state)
end
end
end