raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-27 01:43:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

DRY by extracting calculation to method

Browse Source
This commit is contained in:
Rohan Mitchell
2015-07-24 07:17:20 +10:00
parent 3abce54115
commit 17fb4a7247
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/open_food_network/reports/bulk_coop_report.rb
View File

@@ -30,11 +30,11 @@ module OpenFoodNetwork::Reports
end
def total_amount(lis)
lis.sum { |li| (li.quantity || 0) * (li.variant.unit_value || 0) / (li.product.variant_unit_scale || 1) }
lis.sum { |li| (li.quantity || 0) * scaled_amount(li) }
end
def total_max_quantity_amount(lis)
lis.sum { |li| (li.max_quantity || 0) * (li.variant.unit_value || 0) / (li.product.variant_unit_scale || 1) }
lis.sum { |li| (li.max_quantity || 0) * scaled_amount(li) }
end
def units_required(lis)
@@ -56,9 +56,14 @@ module OpenFoodNetwork::Reports
def max_quantity_amount(lis)
lis.sum do |li|
max_quantity = [li.max_quantity || 0, li.quantity || 0].max
max_quantity * (li.variant.unit_value || 0) / (li.product.variant_unit_scale || 1)
max_quantity * scaled_amount(li)
end
end
def scaled_amount(li)
(li.variant.unit_value || 0) / (li.product.variant_unit_scale || 1)
end
end
end
end