Don't modify params object, but use an intermediate variable

`@params_fields_to_show`
This commit is contained in:
Jean-Baptiste Bellet
2022-06-03 09:29:40 +02:00
parent 214a470896
commit 16babf8250
2 changed files with 7 additions and 3 deletions

View File

@@ -47,8 +47,12 @@ module Admin
# Initialize data
params[:display_summary_row] = true if request.get?
if OpenFoodNetwork::FeatureToggle.enabled?(:report_inverse_columns_logic,
spree_current_user) && request.get?
params[:fields_to_show] = @report.columns.keys
spree_current_user)
@params_fields_to_show = if request.get?
@report.columns.keys
else
params[:fields_to_show]
end
end
@data = Reporting::FrontendData.new(spree_current_user)

View File

@@ -26,7 +26,7 @@
- if feature? :report_inverse_columns_logic, spree_current_user
.alpha.two.columns= label_tag nil, t(:report_columns)
.omega.fourteen.columns
= select_tag(:fields_to_show, options_for_select(@report.available_headers, params[:fields_to_show]),
= select_tag(:fields_to_show, options_for_select(@report.available_headers, @params_fields_to_show),
class: "select2 fullwidth", multiple: true)
- else
.alpha.two.columns= label_tag nil, t(:report_hide_columns)