Adjust logic and specs

app/helpers/reports_helper.rb

@@ -63,6 +63,6 @@ module ReportsHelper
   end
 
   def prices_sum(prices_list)
-    prices_list.sum
+    prices_list.compact.sum
   end
 end

lib/reporting/reports/payments/itemised_payment_totals.rb

@@ -11,7 +11,7 @@ module Reporting
             product_total_price: proc { |orders| prices_sum(orders.map(&:item_total)) },
             shipping_total_price: proc { |orders| prices_sum(orders.map(&:ship_total)) },
             outstanding_balance_price: proc do |orders|
-              prices_sum(orders.map(&:outstanding_balance))
+              prices_sum(orders.map(&:outstanding_balance).map(&:amount))
             end,
             total_price: proc { |orders| prices_sum(orders.map(&:total)) }
           }

lib/reporting/reports/payments/payment_totals.rb

@@ -14,7 +14,7 @@ module Reporting
             eft_price: proc { |orders| total_by_payment_method(orders, "EFT") },
             paypal_price: proc { |orders| total_by_payment_method(orders, "PayPal") },
             outstanding_balance_price: proc { |orders|
-              prices_sum(orders.map(&:outstanding_balance))
+              prices_sum(orders.map(&:outstanding_balance).map(&:amount))
             }
           }
         end

spec/helpers/admin/reports_helper_spec.rb

@@ -24,7 +24,7 @@ RSpec.describe ReportsHelper do
 
   describe "#prices_sum" do
     it "sums to prices list roundind to 2 decimals" do
-      expect(helper.prices_sum([1, nil, 2.333333, 1.5, 2.0])).to eq(6.83)
+      expect(helper.prices_sum([1, nil, 2.33, 1.5, 2.0])).to eq(6.83)
     end
   end
 end