raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve code comments on dodgy and/but critical checkout process method

Browse Source
This commit is contained in:
Luis Ramos
2020-07-30 17:12:41 +01:00
parent e739c5185e
commit 0359d103b2
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/services/order_workflow.rb
View File

@@ -59,15 +59,21 @@ class OrderWorkflow
persist_all_payments if order.state == "payment"
end
# When a payment fails, the order state machine rollbacks all transactions
# Here we ensure we always persist all payments
# When a payment fails, the order state machine stays in 'payment' and rollbacks all transactions
# This rollback also reverts the payment state from 'failed', 'void' or 'invalid' to 'pending'
# Despite the rollback, the in-memory payment still has the correct state, so we persist it
def persist_all_payments
order.payments.each do |payment|
original_payment_state = payment.state
if original_payment_state != Spree::Payment.find(payment.id).state
payment.reload.update(state: original_payment_state)
in_memory_payment_state = payment.state
if different_from_db_payment_state?(in_memory_payment_state, payment.id)
payment.reload.update(state: in_memory_payment_state)
end
end
end
# Verifies if the in-memory payment state is different from the one stored in the database
# This is be done without reloading the payment so that in-memory data is not changed
def different_from_db_payment_state?(in_memory_payment_state, payment_id)
in_memory_payment_state != Spree::Payment.find(payment_id).state
end
end