raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-28 21:07:16 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
v4.4.5
openfoodnetwork/app/models
History
Neal Chambers 2a76b1972f Safely autocorrect Lint/SafeNavigationChain 
Inspecting 1480 files
........................................................................................................................................................................................................................................................................................................................................W............................W..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Offenses:

app/models/spree/line_item.rb:283:55: W: [Corrected] Lint/SafeNavigationChain: Do not chain ordinary method call after safe navigation operator.
        self.final_weight_volume = variant&.unit_value * quantity
                                                      ^^^^^^^^^^^
app/models/spree/line_item.rb:283:57: C: [Corrected] Layout/SpaceAroundMethodCallOperator: Avoid using spaces around a method call operator.
        self.final_weight_volume = variant&.unit_value&. * quantity
                                                        ^
app/models/spree/stock/availability_validator.rb:31:77: W: [Corrected] Lint/SafeNavigationChain: Do not chain ordinary method call after safe navigation operator.
        return line_item.order.shipments.first if line_item.order&.shipments.any?
                                                                            ^^^^^

1480 files inspected, 3 offenses detected, 3 offenses corrected
2023-07-30 21:29:19 +09:00
..
calculator
Safely autocorrect Lint/AmbiguousOperatorPrecedence
2023-07-30 21:29:19 +09:00
concerns
Fix Layout/LineLength
2023-06-23 09:08:04 +09:00
invoice
replace attr with attr_reader
2023-06-18 21:03:13 +02:00
preference_sections
Use rubocop auto correct to add frozen string literal to all files
2021-06-17 23:07:26 +01:00
product_import
Merge pull request #10964 from macanudo527/fix_linelength_bundle1
2023-06-26 12:10:39 +10:00
spree
Safely autocorrect Lint/SafeNavigationChain
2023-07-30 21:29:19 +09:00
tag_rule
Simplify safe navigation operator use < and []
2021-09-10 14:40:46 +10:00
.gitkeep
…
adjustment_metadata.rb
Validate and enforce AdjustmentMetadata associations
2023-06-14 15:07:43 +10:00
application_record.rb
Gracefully deal with missing S3 config
2023-06-23 12:41:36 +10:00
column_preference.rb
Require user of column preference record
2023-06-14 15:07:43 +10:00
content_configuration.rb
Give ContentConfig an updated_at attribute and a usable cache_key
2023-05-08 14:07:50 +01:00
coordinator_fee.rb
Require associations of CoordinatorFee
2023-06-14 15:08:05 +10:00
custom_tab.rb
Limit size to 20 char for the custom tab title
2023-06-08 11:27:07 +02:00
customer.rb
Safely autocorrect Layout/LineLength
2023-07-24 09:14:13 +09:00
distributor_payment_method.rb
Require associations on DistributorPaymentMethod
2023-06-14 15:08:22 +10:00
distributor_shipping_method.rb
Require associations on DistributorShippingMethod
2023-06-14 15:09:12 +10:00
enterprise_fee.rb
Simplify error when tax rate can't be inherited
2023-05-11 12:46:17 +01:00
enterprise_group.rb
Set images to public-read
2023-06-14 10:56:10 +01:00
enterprise_relationship_permission.rb
Update OCs after ERs Permissions are Revoked
2023-04-04 09:37:13 +09:00
enterprise_relationship.rb
Update OCs after ERs Permissions are Revoked
2023-04-04 09:37:13 +09:00
enterprise_role.rb
Remove Spree.user_class
2021-12-10 18:18:20 +00:00
enterprise.rb
Safely autocorrect Lint/AmbiguousOperatorPrecedence
2023-07-30 21:29:19 +09:00
exchange_fee.rb
Use rubocop auto correct to add frozen string literal to all files
2021-06-17 23:07:26 +01:00
exchange_variant.rb
Only delete related exchange variants if exchange is outgoing
2023-05-22 11:09:29 +01:00
exchange.rb
Remove master variant from product
2023-06-16 21:23:44 +01:00
inventory_item.rb
Use rubocop auto correct to add frozen string literal to all files
2021-06-17 23:07:26 +01:00
invoice.rb
replace status:status with cancelled:boolean on invoice model
2023-07-11 09:15:25 +01:00
order_balance.rb
Remove the old balance's code branch
2021-04-19 11:52:41 +02:00
order_cycle_schedule.rb
Add ApplicationRecord for customisations
2021-04-15 15:59:03 +10:00
order_cycle.rb
Prevent creating duplicate webhook notifications [migration]
2023-03-07 15:38:50 +11:00
producer_property.rb
Use rubocop auto correct to add frozen string literal to all files
2021-06-17 23:07:26 +01:00
proxy_order.rb
Fix Layout/LineLength
2023-06-23 09:08:04 +09:00
report_blob.rb
Expire report files after 1 week, maximum for S3
2023-05-15 19:41:45 +02:00
report_rendering_options.rb
create ReportRenderingOptions model
2022-11-24 10:25:59 +01:00
schedule.rb
Fix Layout/LineLength
2023-06-23 09:08:04 +09:00
stripe_account.rb
Use rubocop auto correct to add frozen string literal to all files
2021-06-17 23:07:26 +01:00
subscription_line_item.rb
Adding a scope on subscription_line_item.rb to select records where price estimate is nil
2022-05-11 13:45:13 -04:00
subscription.rb
Fix Layout/LineLength
2023-06-23 09:08:04 +09:00
tag_rule.rb
Use rubocop auto correct to add frozen string literal to all files
2021-06-17 23:07:26 +01:00
terms_of_service_file.rb
Remove outdated ignoring of columns
2022-10-26 10:42:19 +11:00
variant_override.rb
Fix Layout/LineLength
2023-06-23 09:08:04 +09:00
voucher.rb
Use order total excluding discounts in voucher calculations
2023-06-14 10:19:30 +01:00
webhook_endpoint.rb
2. Add model WebhookEndpoint [migration]
2023-03-07 15:38:50 +11:00