mirror of
https://github.com/openfoodfoundation/openfoodnetwork
synced 2026-01-31 21:37:16 +00:00
ff588cec40
The line item sorting by id has been replaced by sorting by completed_at
time: ccb183d60b
While that's a good idea, the query param to order was only defined in
the client Javascript and there was no default ordering. Line items also
get their completed_at date from the order. So it's the same for all
items of the same order and the ordering with that group of line items
was random.
Now we are adding an order in addition. Items are first sorted by date
and then by id if there's any ambiguity.
92 lines
2.4 KiB
Ruby
92 lines
2.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
module Admin
|
|
class BulkLineItemsController < Spree::Admin::BaseController
|
|
include PaginationData
|
|
# GET /admin/bulk_line_items.json
|
|
#
|
|
def index
|
|
order_params = params[:q]&.delete :order
|
|
orders = order_permissions.editable_orders.ransack(order_params).result
|
|
|
|
@line_items = order_permissions.
|
|
editable_line_items.where(order_id: orders).
|
|
includes(:variant).
|
|
ransack(params[:q]).result.order(:id)
|
|
|
|
@pagy, @line_items = pagy(@line_items) if pagination_required?
|
|
|
|
render json: {
|
|
line_items: serialized_line_items,
|
|
pagination: pagination_data
|
|
}
|
|
end
|
|
|
|
# PUT /admin/bulk_line_items/:id.json
|
|
#
|
|
def update
|
|
load_line_item
|
|
authorize_update!
|
|
|
|
# `with_lock` acquires an exclusive row lock on order so no other
|
|
# requests can update it until the transaction is commited.
|
|
# See https://github.com/rails/rails/blob/3-2-stable/activerecord/lib/active_record/locking/pessimistic.rb#L69
|
|
# and https://www.postgresql.org/docs/current/static/sql-select.html#SQL-FOR-UPDATE-SHARE
|
|
order.with_lock do
|
|
if order.contents.update_item(@line_item, line_item_params)
|
|
render body: nil, status: :no_content # No Content, does not trigger ng resource auto-update
|
|
else
|
|
render json: { errors: @line_item.errors }, status: :precondition_failed
|
|
end
|
|
end
|
|
end
|
|
|
|
# DELETE /admin/bulk_line_items/:id.json
|
|
#
|
|
def destroy
|
|
load_line_item
|
|
authorize! :update, order
|
|
|
|
order.contents.remove(@line_item.variant)
|
|
render body: nil, status: :no_content # No Content, does not trigger ng resource auto-update
|
|
end
|
|
|
|
private
|
|
|
|
def load_line_item
|
|
@line_item = Spree::LineItem.find(params[:id])
|
|
end
|
|
|
|
def model_class
|
|
Spree::LineItem
|
|
end
|
|
|
|
def serialized_line_items
|
|
ActiveModel::ArraySerializer.new(
|
|
@line_items, each_serializer: Api::Admin::LineItemSerializer
|
|
)
|
|
end
|
|
|
|
def authorize_update!
|
|
authorize! :update, order
|
|
authorize! :read, order
|
|
end
|
|
|
|
def order
|
|
@line_item.order
|
|
end
|
|
|
|
def line_item_params
|
|
params.require(:line_item).permit(:price, :quantity, :final_weight_volume)
|
|
end
|
|
|
|
def order_permissions
|
|
::Permissions::Order.new(spree_current_user)
|
|
end
|
|
|
|
def page
|
|
params[:page] || 1
|
|
end
|
|
end
|
|
end
|