mirror of
https://github.com/openfoodfoundation/openfoodnetwork
synced 2026-01-24 20:36:49 +00:00
- this before block was causing multiple nevigation to the index - one from the spec itself, one from here.
473 lines
17 KiB
Ruby
473 lines
17 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe Admin::BulkLineItemsController, type: :controller do
|
|
describe '#index' do
|
|
render_views
|
|
|
|
let(:line_item_attributes) {
|
|
%i[id quantity max_quantity price supplier final_weight_volume units_product units_variant
|
|
order]
|
|
}
|
|
let!(:dist1) { FactoryBot.create(:distributor_enterprise) }
|
|
let!(:order1) {
|
|
FactoryBot.create(:order, state: 'complete', completed_at: 1.day.ago, distributor: dist1,
|
|
billing_address: FactoryBot.create(:address) )
|
|
}
|
|
let!(:order2) {
|
|
FactoryBot.create(:order, state: 'complete', completed_at: Time.zone.now, distributor: dist1,
|
|
billing_address: FactoryBot.create(:address) )
|
|
}
|
|
let!(:order3) {
|
|
FactoryBot.create(:order, state: 'complete', completed_at: Time.zone.now, distributor: dist1,
|
|
billing_address: FactoryBot.create(:address) )
|
|
}
|
|
let!(:line_item1) { FactoryBot.create(:line_item_with_shipment, order: order1) }
|
|
let!(:line_item2) { FactoryBot.create(:line_item_with_shipment, order: order2) }
|
|
let!(:line_item3) { FactoryBot.create(:line_item_with_shipment, order: order2) }
|
|
let!(:line_item4) { FactoryBot.create(:line_item_with_shipment, order: order3) }
|
|
|
|
context "as a normal user" do
|
|
before { allow(controller).to receive_messages spree_current_user: create(:user) }
|
|
|
|
it "should deny me access to the index action" do
|
|
get :index, format: :json
|
|
expect(response).to redirect_to unauthorized_path
|
|
end
|
|
end
|
|
|
|
context "as an administrator" do
|
|
before do
|
|
allow(controller).to receive_messages spree_current_user: create(:admin_user)
|
|
end
|
|
|
|
context "when no ransack params are passed in" do
|
|
before do
|
|
get :index, format: :json
|
|
end
|
|
|
|
it "retrieves a list of line_items with appropriate attributes, " \
|
|
"including line items with appropriate attributes" do
|
|
keys = json_response['line_items'].first.keys.map(&:to_sym)
|
|
expect(line_item_attributes.all?{ |attr| keys.include? attr }).to eq(true)
|
|
end
|
|
|
|
it "sorts line_items in ascending id line_item" do
|
|
expect(line_item_ids[0]).to be < line_item_ids[1]
|
|
expect(line_item_ids[1]).to be < line_item_ids[2]
|
|
end
|
|
|
|
it "formats final_weight_volume as a float" do
|
|
expect(json_response[:line_items]).to all(include(final_weight_volume: a_kind_of(Float)))
|
|
end
|
|
|
|
it "returns distributor object with id key" do
|
|
expect(json_response[:line_items].pluck(:supplier)).to all(include(:id))
|
|
end
|
|
end
|
|
|
|
context "when ransack params are passed in for line items" do
|
|
before do
|
|
get :index, as: :json, params: { q: { order_id_eq: order2.id } }
|
|
end
|
|
|
|
it "retrives a list of line items which match the criteria" do
|
|
expect(line_item_ids).to match_array [line_item2.id, line_item3.id]
|
|
end
|
|
end
|
|
|
|
context "when ransack params are passed in for orders" do
|
|
before do
|
|
get :index, as: :json, params: { q: { order: { completed_at_gt: 2.hours.ago } } }
|
|
end
|
|
|
|
it "retrives a list of line items whose orders match the criteria" do
|
|
expect(line_item_ids).to eq [line_item2.id, line_item3.id, line_item4.id]
|
|
end
|
|
end
|
|
end
|
|
|
|
context "as an enterprise user" do
|
|
let(:supplier) { create(:supplier_enterprise) }
|
|
let(:distributor1) { create(:distributor_enterprise) }
|
|
let(:distributor2) { create(:distributor_enterprise) }
|
|
let(:coordinator) { create(:distributor_enterprise) }
|
|
let(:order_cycle) { create(:simple_order_cycle, coordinator:) }
|
|
let!(:order1) {
|
|
create(:order, order_cycle:, state: 'complete',
|
|
completed_at: Time.zone.now, distributor: distributor1,
|
|
billing_address: create(:address) )
|
|
}
|
|
let!(:line_item1) {
|
|
create(:line_item_with_shipment, order: order1,
|
|
variant: create(:variant, supplier:))
|
|
}
|
|
let!(:line_item2) {
|
|
create(:line_item_with_shipment, order: order1,
|
|
variant: create(:variant, supplier:))
|
|
}
|
|
let!(:order2) {
|
|
create(:order, order_cycle:, state: 'complete',
|
|
completed_at: Time.zone.now, distributor: distributor2,
|
|
billing_address: create(:address) )
|
|
}
|
|
let!(:line_item3) {
|
|
create(:line_item_with_shipment, order: order2,
|
|
variant: create(:variant, supplier:))
|
|
}
|
|
|
|
context "producer enterprise" do
|
|
before do
|
|
allow(controller).to receive_messages spree_current_user: supplier.owner
|
|
end
|
|
|
|
context "with no distributor allows to edit orders" do
|
|
before { get :index, as: :json }
|
|
|
|
it "does not display line items for which my enterprise is a supplier" do
|
|
expect(response).to redirect_to unauthorized_path
|
|
end
|
|
end
|
|
|
|
context "with distributor allows to edit orders" do
|
|
before do
|
|
distributor1.update_columns(enable_producers_to_edit_orders: true)
|
|
get :index, as: :json
|
|
end
|
|
|
|
it "retrieves a list of line_items from the supplier" do
|
|
keys = json_response['line_items'].first.keys.map(&:to_sym)
|
|
expect(line_item_attributes.all?{ |attr| keys.include? attr }).to eq(true)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "coordinator enterprise" do
|
|
before do
|
|
allow(controller).to receive_messages spree_current_user: coordinator.owner
|
|
get :index, as: :json
|
|
end
|
|
|
|
it "retrieves a list of line_items" do
|
|
keys = json_response['line_items'].first.keys.map(&:to_sym)
|
|
expect(line_item_attributes.all?{ |attr| keys.include? attr }).to eq(true)
|
|
end
|
|
end
|
|
|
|
context "hub enterprise" do
|
|
before do
|
|
allow(controller).to receive_messages spree_current_user: distributor1.owner
|
|
get :index, as: :json
|
|
end
|
|
|
|
it "retrieves a list of line_items" do
|
|
keys = json_response['line_items'].first.keys.map(&:to_sym)
|
|
expect(line_item_attributes.all?{ |attr| keys.include? attr }).to eq(true)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "paginating" do
|
|
before do
|
|
allow(controller).to receive_messages spree_current_user: create(:admin_user)
|
|
end
|
|
|
|
context "with pagination args" do
|
|
it "returns paginated results" do
|
|
get :index, params: { page: 1, per_page: 2 }, as: :json
|
|
|
|
expect(line_item_ids).to eq [line_item1.id, line_item2.id]
|
|
expect(json_response['pagination']).to eq(
|
|
{ 'page' => 1, 'per_page' => 2, 'pages' => 2, 'results' => 4 }
|
|
)
|
|
end
|
|
|
|
it "returns paginated results for a second page" do
|
|
get :index, params: { page: 2, per_page: 2 }, as: :json
|
|
|
|
expect(line_item_ids).to eq [line_item3.id, line_item4.id]
|
|
expect(json_response['pagination']).to eq(
|
|
{ 'page' => 2, 'per_page' => 2, 'pages' => 2, 'results' => 4 }
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#update' do
|
|
let(:supplier) { create(:supplier_enterprise) }
|
|
let(:distributor1) { create(:distributor_enterprise) }
|
|
let(:coordinator) { create(:distributor_enterprise) }
|
|
let(:order_cycle) { create(:simple_order_cycle, coordinator:) }
|
|
let!(:order1) {
|
|
create(:order, order_cycle:, state: 'complete',
|
|
completed_at: Time.zone.now,
|
|
distributor: distributor1,
|
|
billing_address: create(:address) )
|
|
}
|
|
let!(:line_item1) {
|
|
line_item1 = create(:line_item_with_shipment,
|
|
order: order1,
|
|
variant: create(:variant, supplier:))
|
|
# make sure shipment is available through db reloads of this line_item
|
|
line_item1.tap(&:save!)
|
|
}
|
|
let(:line_item_params) { { quantity: 3, final_weight_volume: 3000, price: 3.00 } }
|
|
let(:params) { { id: line_item1.id, order_id: order1.number, line_item: line_item_params } }
|
|
|
|
context "as an enterprise user" do
|
|
context "producer enterprise" do
|
|
before do
|
|
allow(controller).to receive_messages spree_current_user: supplier.owner
|
|
spree_put :update, params
|
|
end
|
|
|
|
it "does not allow access" do
|
|
expect(response).to redirect_to unauthorized_path
|
|
end
|
|
end
|
|
|
|
context "coordinator enterprise" do
|
|
render_views
|
|
|
|
before do
|
|
allow(controller).to receive_messages spree_current_user: coordinator.owner
|
|
end
|
|
|
|
# Used in admin/orders/bulk_management
|
|
context 'when the request is JSON (angular)' do
|
|
before { params[:format] = :json }
|
|
|
|
it "updates the line item" do
|
|
spree_put :update, params
|
|
line_item1.reload
|
|
expect(line_item1.quantity).to eq 3
|
|
expect(line_item1.final_weight_volume).to eq 3000
|
|
expect(line_item1.price).to eq 3.00
|
|
end
|
|
|
|
it "returns an empty JSON response" do
|
|
spree_put :update, params
|
|
expect(response.body).to eq ""
|
|
end
|
|
|
|
it 'returns a 204 response' do
|
|
spree_put :update, params
|
|
expect(response.status).to eq 204
|
|
end
|
|
|
|
it 'applies enterprise fees locking the order with an exclusive row lock' do
|
|
allow(Spree::LineItem)
|
|
.to receive(:find).with(line_item1.id.to_s).and_return(line_item1)
|
|
|
|
expect(line_item1.order).to receive(:with_lock).and_call_original
|
|
expect(line_item1.order).to receive(:update_line_item_fees!)
|
|
expect(line_item1.order).to receive(:update_order_fees!)
|
|
expect(line_item1.order).to receive(:update_order!).once
|
|
|
|
spree_put :update, params
|
|
end
|
|
|
|
context 'when the line item params are not correct' do
|
|
let(:line_item_params) { { price: 'hola' } }
|
|
let(:errors) { { 'price' => ['is not a number'] } }
|
|
|
|
it 'returns a JSON with the errors' do
|
|
spree_put :update, params
|
|
expect(response.parsed_body['errors']).to eq(errors)
|
|
end
|
|
|
|
it 'returns a 412 response' do
|
|
spree_put :update, params
|
|
expect(response.status).to eq 412
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context "hub enterprise" do
|
|
before do
|
|
allow(controller).to receive_messages spree_current_user: distributor1.owner
|
|
put :update, params:, xhr: true
|
|
end
|
|
|
|
it "updates the line item" do
|
|
line_item1.reload
|
|
expect(line_item1.quantity).to eq 3
|
|
expect(line_item1.final_weight_volume).to eq 3000
|
|
expect(line_item1.price).to eq 3.00
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#destroy' do
|
|
render_views
|
|
|
|
let(:supplier) { create(:supplier_enterprise) }
|
|
let(:distributor1) { create(:distributor_enterprise) }
|
|
let(:coordinator) { create(:distributor_enterprise) }
|
|
let(:order_cycle) { create(:simple_order_cycle, coordinator:) }
|
|
let!(:order1) {
|
|
create(:order, order_cycle:, state: 'complete',
|
|
completed_at: Time.zone.now, distributor: distributor1,
|
|
billing_address: create(:address) )
|
|
}
|
|
let!(:line_item1) {
|
|
create(:line_item_with_shipment, order: order1,
|
|
variant: create(:variant, supplier:))
|
|
}
|
|
let(:params) { { id: line_item1.id, order_id: order1.number } }
|
|
|
|
before do
|
|
allow(controller).to receive_messages spree_current_user: coordinator.owner
|
|
end
|
|
|
|
# Used in admin/orders/bulk_management
|
|
context 'when the request is JSON (angular)' do
|
|
before { params[:format] = :json }
|
|
|
|
it 'destroys the line item' do
|
|
expect {
|
|
spree_delete :destroy, params
|
|
}.to change { Spree::LineItem.where(id: line_item1).count }.from(1).to(0)
|
|
end
|
|
|
|
it 'returns an empty JSON response' do
|
|
spree_delete :destroy, params
|
|
expect(response.body).to eq ""
|
|
end
|
|
|
|
it 'returns a 204 response' do
|
|
spree_delete :destroy, params
|
|
expect(response.status).to eq 204
|
|
end
|
|
end
|
|
end
|
|
|
|
context "updating the order's taxes, fees, and states" do
|
|
let(:distributor) { create(:distributor_enterprise_with_tax) }
|
|
let!(:order_cycle) {
|
|
create(:order_cycle, distributors: [distributor],
|
|
coordinator_fees: [line_item_fee1, line_item_fee2, order_fee])
|
|
}
|
|
let(:outgoing_exchange) { order_cycle.exchanges.outgoing.first }
|
|
|
|
let!(:order) {
|
|
create(:order_with_line_items, line_items_count: 2, distributor:,
|
|
order_cycle:)
|
|
}
|
|
let(:line_item1) { order.line_items.first }
|
|
let(:line_item2) { order.line_items.last }
|
|
|
|
let!(:zone) { create(:zone_with_member) }
|
|
let(:tax_included) { true }
|
|
let(:tax_rate5) { create(:tax_rate, amount: 0.05, zone:, included_in_price: tax_included) }
|
|
let(:tax_rate10) {
|
|
create(:tax_rate, amount: 0.10, zone:, included_in_price: tax_included)
|
|
}
|
|
let(:tax_rate15) {
|
|
create(:tax_rate, amount: 0.15, zone:, included_in_price: tax_included)
|
|
}
|
|
let(:tax_cat5) { create(:tax_category, tax_rates: [tax_rate5]) }
|
|
let(:tax_cat10) { create(:tax_category, tax_rates: [tax_rate10]) }
|
|
let(:tax_cat15) { create(:tax_category, tax_rates: [tax_rate15]) }
|
|
|
|
let!(:shipping_method) {
|
|
create(:shipping_method_with, :shipping_fee, tax_category: tax_cat5, name: "Shiperoo",
|
|
distributors: [distributor])
|
|
}
|
|
let!(:payment_method) { create(:payment_method, :per_item, distributors: [distributor]) }
|
|
|
|
let(:line_item_fee1) {
|
|
create(:enterprise_fee, :per_item, amount: 1, inherits_tax_category: false,
|
|
tax_category: tax_cat15)
|
|
}
|
|
let(:line_item_fee2) {
|
|
create(:enterprise_fee, :per_item, amount: 2, inherits_tax_category: true)
|
|
}
|
|
let(:order_fee) { create(:enterprise_fee, :flat_rate, amount: 3, tax_category: tax_cat15 ) }
|
|
|
|
before do
|
|
outgoing_exchange.variants << [line_item1.variant, line_item2.variant]
|
|
allow(order).to receive(:tax_zone) { zone }
|
|
line_item1.variant.update_columns(tax_category_id: tax_cat5.id)
|
|
line_item2.variant.update_columns(tax_category_id: tax_cat10.id)
|
|
|
|
order.shipments.map(&:refresh_rates)
|
|
order.select_shipping_method(shipping_method.id)
|
|
Orders::WorkflowService.new(order).advance_to_payment
|
|
order.finalize!
|
|
order.recreate_all_fees!
|
|
order.create_tax_charge!
|
|
order.update_order!
|
|
order.payments << create(:payment, payment_method:, amount: order.total,
|
|
state: "completed")
|
|
|
|
allow(controller).to receive(:spree_current_user) { distributor.owner }
|
|
allow(Spree::LineItem).to receive(:find) { line_item1 }
|
|
allow(line_item1).to receive(:order) { order }
|
|
end
|
|
|
|
describe "updating a line item" do
|
|
let(:line_item_params) { { quantity: 3 } }
|
|
let(:params) { { id: line_item1.id, order_id: order.number, line_item: line_item_params } }
|
|
|
|
it "correctly updates order totals and states" do
|
|
expect(order.total).to eq 35.0
|
|
expect(order.shipment_adjustments.shipping.sum(:amount)).to eq 6.0
|
|
expect(order.shipment_adjustments.tax.sum(:amount)).to eq 0.29
|
|
expect(order.item_total).to eq 20.0
|
|
expect(order.adjustment_total).to eq 15.0
|
|
expect(order.included_tax_total).to eq 1.22
|
|
expect(order.payment_state).to eq "paid"
|
|
|
|
expect(order).to receive(:update_order!).at_least(:once).and_call_original
|
|
expect(order).to receive(:create_tax_charge!).at_least(:once).and_call_original
|
|
|
|
spree_put :update, params
|
|
order.reload
|
|
|
|
expect(order.total).to eq 67.0
|
|
expect(order.shipment_adjustments.sum(:amount)).to eq 12.57
|
|
expect(order.item_total).to eq 40.0
|
|
expect(order.adjustment_total).to eq 27.0
|
|
expect(order.included_tax_total).to eq 3.38
|
|
expect(order.payment_state).to eq "balance_due"
|
|
end
|
|
end
|
|
|
|
describe "deleting a line item" do
|
|
let(:params) { { id: line_item1.id, order_id: order.number } }
|
|
|
|
it "correctly updates order totals and states" do
|
|
expect(order.total).to eq 35.0
|
|
expect(order.shipment_adjustments.shipping.sum(:amount)).to eq 6.0
|
|
expect(order.shipment_adjustments.tax.sum(:amount)).to eq 0.29
|
|
expect(order.item_total).to eq 20.0
|
|
expect(order.adjustment_total).to eq 15.0
|
|
expect(order.included_tax_total).to eq 1.22
|
|
expect(order.payment_state).to eq "paid"
|
|
|
|
spree_delete :destroy, params
|
|
order.reload
|
|
|
|
expect(order.total).to eq 19.0
|
|
expect(order.shipment_adjustments.shipping.sum(:amount)).to eq 3.0
|
|
expect(order.shipment_adjustments.tax.sum(:amount)).to eq 0.14
|
|
expect(order.item_total).to eq 10.0
|
|
expect(order.adjustment_total).to eq 9.0
|
|
expect(order.included_tax_total).to eq 0.84
|
|
expect(order.payment_state).to eq "credit_owed"
|
|
end
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def line_item_ids
|
|
json_response['line_items'].pluck(:id)
|
|
end
|
|
end
|